From: Mulyadi Santosa <mulyadi.santosa@gmail.com>
To: mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] generate-cmdlist.sh should be either executable or run as parameter of "."
Date: Sat, 26 Sep 2009 02:01:41 +0700 [thread overview]
Message-ID: <f284c33d0909251201w422e9687x8cd3a784e85adf7d@mail.gmail.com> (raw)
I believe this is just a small glitch. generate-cmdlist.sh by default
should be made as executable. But since one might forgot to do it, we
could simply call it as an argument "." or "source" or even "sh -c". I
pick "."
Tested in 2.6.31
Signed-off-by: Mulyadi Santosa <mulyadi.santosa@gmail.com>
--- linux-2.6.31/tools/perf/Makefile.bak 2009-09-12 22:28:37.000000000 +0700
+++ linux-2.6.31/tools/perf/Makefile 2009-09-26 01:51:04.000000000 +0700
@@ -682,7 +682,7 @@
common-cmds.h: util/generate-cmdlist.sh command-list.txt
common-cmds.h: $(wildcard Documentation/perf-*.txt)
- $(QUIET_GEN)util/generate-cmdlist.sh > $@+ && mv $@+ $@
+ $(QUIET_GEN). util/generate-cmdlist.sh > $@+ && mv $@+ $@
$(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh
$(QUIET_GEN)$(RM) $@ $@+ && \
next reply other threads:[~2009-09-25 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 19:01 Mulyadi Santosa [this message]
2009-09-30 12:08 ` Ingo Molnar
2009-09-30 12:17 ` Sam Ravnborg
2009-10-01 8:11 ` Ingo Molnar
2009-10-01 9:58 ` [tip:perf/urgent] perf tools: Run generate-cmdlist.sh properly tip-bot for Mulyadi Santosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f284c33d0909251201w422e9687x8cd3a784e85adf7d@mail.gmail.com \
--to=mulyadi.santosa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®