From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74EB4315D35 for ; Wed, 11 Feb 2026 11:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770810962; cv=none; b=NOMr8apEHIjAqjczIfx+8s4EjA8i1fvg+JJIRzaB+CBYMJTPrhyaFLAm1m1sfTjt3o7BXVkw1K7ygrDVN7gmylMPYD9sPCmNEhF3ndxe+AB9n7FYDpVkMUot1clEnk/8Inl2FF+LTmI89g21GnTQICyl5p8RS4+wFMOLLxCFvM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770810962; c=relaxed/simple; bh=+0oTiVEciU4czR3f/w4qaJMu4GmlPg8+p7LTIxCV06A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HUwc8l8YfpHrKmKjLN13BtknqPP7zmxZvGVBW/cvewmxAm9RhF0IHA8xlDqVUzG5GBv4Nq8XlBN7F2pLLw15j6O1KDP0ufExCQI35phUlqWmbDxu/HWSthLm5Rz3JHzvdj4tTDYiO8i/sd92hldgCcoo9yMGM4QHKQOu8p5LoWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LBmVtAhl; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=K0XKRK8e; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LBmVtAhl"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="K0XKRK8e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770810960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aY/0evCgUnAgU67WTuuAcR9YOZDCXErhCMNHMcMC0To=; b=LBmVtAhlyK7nxiOrE1qrhiRXYda0KAGm3cbNmaeG7cFIJb/W3G2ajEPZbA8xolV8ZU4hu2 fu6UDT9LBOof6DxLU+TX+I9rz5kgng4jstKeVDZQ+k0Fl8x04tQ2dKLi+SPpKrBwc8Q9KL Yp3rWsus+63zW9KCZpTrLXYeRDpgMAk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-y7I8rI0LNkmYb8kzBZnwHg-1; Wed, 11 Feb 2026 06:55:59 -0500 X-MC-Unique: y7I8rI0LNkmYb8kzBZnwHg-1 X-Mimecast-MFC-AGG-ID: y7I8rI0LNkmYb8kzBZnwHg_1770810958 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-435a2de6ec0so2621698f8f.0 for ; Wed, 11 Feb 2026 03:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770810958; x=1771415758; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aY/0evCgUnAgU67WTuuAcR9YOZDCXErhCMNHMcMC0To=; b=K0XKRK8epYl8IZBDshFy7nylL+9Gx1BrBDEz6hfb2bQRcpkwityShmWhrfi6iGFqa1 GLrVTo61vNWfHVn0ZAOyCyZs91z0b1aVd09/b0rhLWexnpcD3nNMsPy4VxjSLAMn1GqU sQVKzYF4qNM1atz/RW5zpdVcIALP6JzzRlugpqfFMc2ilFnzkTgjLn3KRc3xlE7D5+R8 l3KgxyznpqLkwhiwhZclbqbBfLs1YXGU2VWTIfB/mBT6dvC1xkmYX4K4vcW3YoeGMcbQ Ab/M12SLWisyKsjuOkqKQ/gC0g36hjI/01IvhC7ufz3ZDNmNnd1hh5v8zk66xxaN4wUH 7tFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770810958; x=1771415758; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aY/0evCgUnAgU67WTuuAcR9YOZDCXErhCMNHMcMC0To=; b=k6i7FtKfVmVdeiw9huBEfvJ+OgnlkFCYfY/tiS/S904S5XhKlNZ89siMuwdbAAcmXe H2TKAKos377QGv5zmmIRpMSTUZjFu8vc8hOFV9lEWbD3e6Ds69lf6r4E/wHX/QKGWheh HUVPdhN/Y63r7OQUekSDkDnQ1N83S/u6ucUwGtKK30BaI49zb3ZlSN/7P/NrVMaZ+ZP6 +1YgAXqvjCBSF8NO1969mi2v+wB+ByrYRGuIfuIriLumraByyB1KEL1aOJruiS1Vbr+M MbprfaZ582nzm7kWzrw5rylQlqzGHHDRETcHn+GayPTaFfbPsa+tFwn0blRrLumOxh/5 Uo9Q== X-Forwarded-Encrypted: i=1; AJvYcCUvmquuyhXAVIgHcGeybSvVo6hx8+BIH4oiaEeO+21Q1P6KQoHJDLILprSQw09InX5FKGeyDuWR53Hx8mc=@vger.kernel.org X-Gm-Message-State: AOJu0YxNWASpsegmHNf3LxDTY26I4LqJWOASgGozyw7VnspaalXtI9ii VFBq+aeNtxy1TlKhYrSqErVeZeOqvsRZt5IQzCyFGGSNXl1aK2CRE9okoCWhlB50CYps+0Kss+n t2udo1fTul61LdBtGQMT4s1YaMzZJZ7xUrtzp76/lfIFISkFjQu94SYqv/dVHM6zfJg== X-Gm-Gg: AZuq6aLRbcasPNRRaLcE7wXvmHmCvzfG6MIVDS5gwmXK/BFSL+YvZUB+VhNJGOaWHU7 gMWHj4OR3WmCcIikARM5T8Vm9nFonhsnk3GSqFDjRGBZgqzjPDQv8gP9XZXgALnEUikMaZv+YAx v8vOP+lBGxY9aKGBmb8/ga94tZOKPmI4N8ru8Wa1nZlQLLtgK0fbwIGPisCAb/gjktAQi2cqG9R 70b385aAxTbWjOxanLUALMSVqYD1n9yW1IkfzaEfXqXl1nRcHCHr0L0uB+KM0yasBgqPvo3QRsx iQLaQOl/ZldP/P+VkLt4pm/EX3enc64ir+4/YUxdGQgx2MMyd9ZuoQXwlF7L+YoidsOyrlxy1m+ Q4WqnooqCxVnnMgp3CCnRMxdOOw== X-Received: by 2002:a05:6000:18a8:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-43782c259e6mr3400549f8f.23.1770810957920; Wed, 11 Feb 2026 03:55:57 -0800 (PST) X-Received: by 2002:a05:6000:18a8:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-43782c259e6mr3400519f8f.23.1770810957451; Wed, 11 Feb 2026 03:55:57 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.220]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783dfc54csm4207496f8f.25.2026.02.11.03.55.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Feb 2026 03:55:56 -0800 (PST) Message-ID: Date: Wed, 11 Feb 2026 12:55:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] docs: ethtool: clarify the bit-by-bit bitset format description To: Yohei Kojima , Andrew Lunn , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/7/26 11:25 AM, Yohei Kojima wrote: > Clarify the bit-by-bit bitset format's behavior around mandatory > attributes and bit identification. More specifically, the following > changes are made: > > * Rephrase a misleading sentence which implies name and index are > mutually exclusive > * Describe that ETHTOOL_A_BITSET_BITS nest is mandatory > * Describe that a request fails if inconsistent identifiers are given > > Signed-off-by: Yohei Kojima > --- > Current ethtool-netlink documentation doesn't describe several behavior > around bit-by-bit bitset, which makes it hard to develop a ethtool > library without digging into the kernel code. This patch eases the gap > between the kernel behavior and the documentation by adding descriptions > around the mandatory attribute and bit identification. This needs review by someone provided with English natural language skills far better than mine. I'm wrapping the net-next PR right now; this has to be deferred after the merge window, I'm sorry. /P