mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Tobias Schumacher <ts@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger	 <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Gerd Bayer <gbayer@linux.ibm.com>,
	Halil Pasic	 <pasic@linux.ibm.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Thomas Gleixner	 <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 1/2] genirq: Change hwirq parameter to irq_hw_number_t
Date: Mon, 17 Nov 2025 16:56:50 +0100	[thread overview]
Message-ID: <f289fab008aa4b814907b35d3f1a712ecd438461.camel@linux.ibm.com> (raw)
In-Reply-To: <20251117-implement-msi-domain-v2-1-a110ea0721fe@linux.ibm.com>

On Mon, 2025-11-17 at 09:59 +0100, Tobias Schumacher wrote:
> The irqdomain implementation internally represents hardware IRQs as
> irq_hw_number_t, which is defined as unsigned long int. When providing
> an irq_hw_number_t to the generic_handle_domain() functions that expect
> and unsigned int hwirq, this can lead to a loss of information. Change
> the hwirq parameter to irq_hw_number_t to support the full range of
> hwirqs.
> 
> Signed-off-by: Tobias Schumacher <ts@linux.ibm.com>
> ---
>  include/linux/irqdesc.h | 6 +++---
>  kernel/irq/irqdesc.c    | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> 

Looks good and this also made it very clean to combine function IDs
with the MSI index. Thanks!

Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>

  parent reply	other threads:[~2025-11-17 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  8:59 [PATCH v2 0/2] genirq: s390/pci: Migrate MSI interrupts to irqdomain API Tobias Schumacher
2025-11-17  8:59 ` [PATCH v2 1/2] genirq: Change hwirq parameter to irq_hw_number_t Tobias Schumacher
2025-11-17 11:26   ` Thomas Gleixner
2025-11-17 15:56   ` Niklas Schnelle [this message]
2025-11-17  8:59 ` [PATCH v2 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain API Tobias Schumacher
2025-11-17 17:20   ` Niklas Schnelle
2025-11-17 22:46   ` Farhan Ali
     [not found]     ` <c5823dcc4bfb96a632f159f79af43d98@imap.linux.ibm.com>
2025-11-18 10:15       ` Niklas Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f289fab008aa4b814907b35d3f1a712ecd438461.camel@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=ts@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®