From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbeENJjX (ORCPT ); Mon, 14 May 2018 05:39:23 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:48970 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752392AbeENJjV (ORCPT ); Mon, 14 May 2018 05:39:21 -0400 From: Philippe CORNU To: Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Rob Herring , "Mark Rutland" , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Yannick FERTRE , Benjamin Gaignard , Alexandre TORGUE Subject: Re: [PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies Thread-Topic: [PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies Thread-Index: AQHT3GqO5f7596VGtE+CsIvlD/pnwKQu9GaA Date: Mon, 14 May 2018 09:38:58 +0000 Message-ID: References: <20180425075314.19137-1-philippe.cornu@st.com> <20180425075314.19137-3-philippe.cornu@st.com> In-Reply-To: <20180425075314.19137-3-philippe.cornu@st.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-14_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w4E9dSsM012861 Hi Laurent, Archit, Andrzej & Yannick, Do you have any comments on this v2 driver part? (more details regarding v1/v2 differences in the cover letter https://www.spinics.net/lists/dri-devel/msg174137.html) Thank you, Philippe :-) On 04/25/2018 09:53 AM, Philippe Cornu wrote: > Add the optional power supplies using the description found in > "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > > The sii902x input IOs are not "io safe" so it is important to > enable/disable voltage regulators during probe/remove phases to > avoid damages. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/bridge/sii902x.c | 38 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 34 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index 60373d7eb220..c367d7b91ade 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -86,6 +87,7 @@ struct sii902x { > struct drm_bridge bridge; > struct drm_connector connector; > struct gpio_desc *reset_gpio; > + struct regulator_bulk_data supplies[2]; > }; > > static inline struct sii902x *bridge_to_sii902x(struct drm_bridge *bridge) > @@ -392,23 +394,42 @@ static int sii902x_probe(struct i2c_client *client, > return PTR_ERR(sii902x->reset_gpio); > } > > + sii902x->supplies[0].supply = "iovcc"; > + sii902x->supplies[1].supply = "vcc12"; > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(sii902x->supplies), > + sii902x->supplies); > + if (ret) { > + dev_err(dev, "Failed to get power supplies: %d\n", ret); > + return ret; > + } > + > + ret = regulator_bulk_enable(ARRAY_SIZE(sii902x->supplies), > + sii902x->supplies); > + if (ret) { > + dev_err(dev, "Failed to enable power supplies: %d\n", ret); > + return ret; > + } > + > + usleep_range(10000, 20000); > + > sii902x_reset(sii902x); > > ret = regmap_write(sii902x->regmap, SII902X_REG_TPI_RQB, 0x0); > if (ret) > - return ret; > + goto err_disable_regulator; > > ret = regmap_bulk_read(sii902x->regmap, SII902X_REG_CHIPID(0), > &chipid, 4); > if (ret) { > dev_err(dev, "regmap_read failed %d\n", ret); > - return ret; > + goto err_disable_regulator; > } > > if (chipid[0] != 0xb0) { > dev_err(dev, "Invalid chipid: %02x (expecting 0xb0)\n", > chipid[0]); > - return -EINVAL; > + ret = -EINVAL; > + goto err_disable_regulator; > } > > /* Clear all pending interrupts */ > @@ -424,7 +445,7 @@ static int sii902x_probe(struct i2c_client *client, > IRQF_ONESHOT, dev_name(dev), > sii902x); > if (ret) > - return ret; > + goto err_disable_regulator; > } > > sii902x->bridge.funcs = &sii902x_bridge_funcs; > @@ -434,6 +455,12 @@ static int sii902x_probe(struct i2c_client *client, > i2c_set_clientdata(client, sii902x); > > return 0; > + > +err_disable_regulator: > + regulator_bulk_disable(ARRAY_SIZE(sii902x->supplies), > + sii902x->supplies); > + > + return ret; > } > > static int sii902x_remove(struct i2c_client *client) > @@ -443,6 +470,9 @@ static int sii902x_remove(struct i2c_client *client) > > drm_bridge_remove(&sii902x->bridge); > > + regulator_bulk_disable(ARRAY_SIZE(sii902x->supplies), > + sii902x->supplies); > + > return 0; > } > >