From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-scsi@vger.kernel.org, storagedev@microchip.com,
Don Brace <don.brace@microchip.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] hpsa: fix a memory leak in hpsa_find_cfgtables()
Date: Sat, 10 Jan 2026 07:55:14 +0100 [thread overview]
Message-ID: <f29e2dbc-9a37-4e45-9d4b-c52526b7d0c5@web.de> (raw)
In-Reply-To: <20260108073251.315271-1-lihaoxiang@isrc.iscas.ac.cn>
> If write_driver_ver_to_cfgtable() fails, add iounmap() to
> release the memory allocated by remap_pci_mem().
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n526
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n659
> Found by manual static code review.
Can such information indicate a contradiction?
Regards,
Markus
prev parent reply other threads:[~2026-01-10 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:32 Haoxiang Li
2026-01-10 6:55 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f29e2dbc-9a37-4e45-9d4b-c52526b7d0c5@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=don.brace@microchip.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®