From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751515AbcHZHeL (ORCPT ); Fri, 26 Aug 2016 03:34:11 -0400 Received: from mail-cys01nam02on0064.outbound.protection.outlook.com ([104.47.37.64]:39136 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750929AbcHZHeH (ORCPT ); Fri, 26 Aug 2016 03:34:07 -0400 X-Greylist: delayed 893 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 Aug 2016 03:34:06 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH v2 1/2] sdhci-of-arasan: Modify arasan sdhci documentation about broken-cd and non-removable properties. To: Zach Brown , References: <1472166111-28872-1-git-send-email-zach.brown@ni.com> CC: , , , , , , , , From: Michal Simek Message-ID: Date: Fri, 26 Aug 2016 09:19:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472166111-28872-1-git-send-email-zach.brown@ni.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22536.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(24454002)(199003)(76176999)(19580395003)(54356999)(19580405001)(63266004)(106466001)(31686004)(50986999)(83506001)(36756003)(4326007)(586003)(230700001)(19300405004)(2906002)(31696002)(92566002)(33646002)(230783001)(626004)(50466002)(64126003)(15975445007)(8936002)(5660300001)(81156014)(65806001)(47776003)(8676002)(77096005)(305945005)(81166006)(65956001)(2950100001)(87936001)(11100500001)(23746002)(189998001)(9786002)(7846002)(4001350100001)(5001770100001)(356003)(36386004)(65826006)(107986001)(562404015);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR02MB1141;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT049;1:lonogI30MhfXJwGEo4q74Jo2kJk4o/wlMHPdhJv0GYf9YL4QoFtCfBJkq69oQtqBHcWoj4pKmkdx9+iDWe10ApdshbrPB7fo7BbiYAfO+bgdEoFldvceOLgHiZ1LqXjsR5sEoYurHy3Ep5yqs/ZTPW/1My/22kOEgFiroyXJs2wQ7AT64y4VhIawEPVWoaKRixEyfTMTLxFwHiVIWPWQneXGVxzwEGCqeRNMcw0LgSI0jsPM3evemR8yi2PuxoEdbb21TwxF7/4j3hj0eQ7Q3Yx9iO9MniNg9m/Y4ok9k/OdJK0Fg4MVy/Ih/vPKp8sJri34RdM3QdArGQBga0Ka7ioEEY+KyWISRGKViQXmvR/Ot6BglXeHXU01xZkHv3gqySIbYzbDIvgf6NwBvG27ZA2ejh3hy/6wtZP8qZ789MUOGrnoWZBDdXjru1muDwSouDsUKY5v+Dv0u3eomHCgTqLPYPA67EHB3g/KcJx/O8JhNIdD4XfoNuJfz277ImqAPqspGpRCk6TZ13oJtci+vMkGtp+fZMM6iPCxGcEtqsK+U/sdegvmIywjGGS4zGbN4bkQS0PF5MYLV33yuZXb2lQ8A9joMkbYD4AgTntj7Mk= X-MS-Office365-Filtering-Correlation-Id: 5b1d369c-7289-4dd5-f784-08d3cd8145b5 X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1141;2:29k2O7SUoBq6KK1/2nXZyK/ikPnzMpugttLQCwTdy9I3SaGutFshj0YgVB+Nr7i0ItzqT5Ae+RhJYg1/v8YvO/jZgu5xTcTSsWoerCDKgRBzIB2ZjZkYSarrK/gHqyUp0+0vMTev6Iq3JoKfB8/lk/B0FmmHeN6ZhOTAZnTSDPVJ5bsbu2CNZ7oth0JN6JRv;3:6GY0pHpl2zzBfCkt21uPyXePlR3Jb4lumqOwEaGenD/8shJHw4Ft0iJiptPhB2C94v2O1zOw+yi58qkGlxOXv1TVSVK0u3Y4AQHYKHrR4xrZRU/H13xYGpJirPDtf34A7Q3kQ6LYem4ZksA5ItxT2lQSuAYtgD+IBJx/vtQYod1AehivlSPdvW+ZWUQOfTXRU7xvnUzu/5vkM0b2+t08C/aCyvN3J8ak8HhciZ4rHXWsN3kpJSeNPQd4yIaZNbVgtYc1NwcFqHnzv1af4GpnwA==;25:Bn1iz8z61Hamyxo5EamxQCP+4nbqGsZCQUf06Ub/eer8qJH9PyOiPtMRZW8b9XsRtnUzlzP7+6wxllGVYzMuX9A0Uv/bZu0GWaWGjwxI8TKlyoWvkkbWeoc+4IbItMmys7OKl9YGEht0TSU+XrtQSnLOzNqYEjFca8nisW+lHRyxCHF6IQuE2ajy8cHk2Vb92UnxExgx5qvKhIDVOlcoYMBoswWNpofxWXBzfiCp+4eQP7o5elBOU0VnDxHjWspfGK+7FKuc01Mi8FuqrVdKJtjQfYIiFL3OxvUVZ5JjygKI+XNOGjdKEJP9cR6x/+7g42zcnfwgYM4O+M6tdpJVJeBzLu0d9+ieJ9LRd7AXEa1OBy4rMi2LOCZVlyQZ4kGZK7yLdsl6QS0FEx8/5i/l5K/G4pmQOlMNQck4myC8czc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BN3PR02MB1141; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1141;31:tetyUBrKX5ZWJTUd5aBa7q/HTnN47MXqtoQMwfgri1pQG2Ih1OoQPmSgE9Grn1hc0Cq/TfgEkMV9y16A6e6dIi3/syfmFNQuWFi67tV/xwlPYpO1HnXqDijCgVQtHbwSEqbgHiOoU7qkYwVrpzcCqh85KHFT613kEBKv+hXof+LpIVF6jcqgc0X7M9e9glrpDz03fAJLjc/LSphxTHhqCqJ0ZmrVQliY/6aQb4AuS+I=;20:XvC54tsLPrequoTm8c2hrjCiCCrrj+Dvv6lZAG154dlOrZc+vozsBHjCgHYzNLVV7ZsZoap1H14L7RYVAFPZ3o58oO5SUDLZGvsiDzaK9nNwdoc5c0FOSx84Cajkj7Gy9D72+Pp3GHwyvnHOaLHwzU9RMRBw85noOIGmRoTeLDLxLSlU7BZqNhbKCG8o4MBOpDkfBGE3yvrcgZ2L58Z/h+3VSmQ+mgRCOrPgwPPK3GnCnIP0sh/rZgaKAh+LwXML1vWHmMeaHtrZh6h1pyAkQtd4FEtUe3IVBhwA0tUU54nstUj13rZNr5eh0u0nGrZH/gsSFJrxqGHjqK9/7aNLOAJQ4Lpra6kJRHVj1qBVxkAvmf6Fw8gPQYdD9V2K0/S/Q54OEUkb0rV+PjXFUmVYrsQTr56EJx8u2v3Pchum4blWig9dodLQa155EFP3HK1q4xYGG784mKAaZetwESVOShUxrTY692j2LnTMBj0IXPCRyI7gec7rGQtIoVaK1cr8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(189271028609987)(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BN3PR02MB1141;BCL:0;PCL:0;RULEID:;SRVR:BN3PR02MB1141; X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1141;4:TMNSiUjKIN3OP16GvtrhnY1va8You5+T8EYEjqLE8ufF0gWP+OTGLRW05wTGgrxsbG3uHettNzQUmL+CGW3L6vGjH3Oz4cGaYAFTx3fUoI9RsVion3pWOq+551PHjbtq1SH/mLkFC6+/RZG9oHtzt/kCOAjmZbpIM/7LZV4j4haOT9cOmdv7c+DlV1YWbrk3IJHAj7WdoBza7bJJBcfDbxe9nwFwR6o9iPAmQzLT5ww0FKUFi0YD5hqx98orCE7M+fKtS0WjoMdKJa9rzH32Z1gAupIRnUtJzbS0iHg6yNBfuOdV4cd3O+wKuWEIYdMVXDggzfAKvQti59Hj+4Q6mM66wQDBJfoZuk0SPFCaUIVYKs7lXB9PouLfWoIcUelv2ISpqStAg4f6iGPXJ7UhQMll9+yo68qPV9H9zoi2s7+Jj4lY0L8Gce1SEdB3jgrEERn62GWvQSSYYYeMkg02cmiCCzxjqybc7ofhf6GNA5gnfAy4uBFmrYXiSesB2MC20BYiycREdvMTRwkIdjKD3nSxCWudDLtWUN1hZiTbY0TCgyiMgmhTJ9Ohq/pgsZvhs3swGlTFqXQxFvfDvQP3dQhVALhqhvIOfoVnTk5l/ms= X-Forefront-PRVS: 00462943DE X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR02MB1141;23:NdHM14/le0lGUAtyeCzAYgBF2Z2kpdiJFrtkN?= =?Windows-1252?Q?f1ToIeTva8Obz8fddyD8/LQTha1aC5gESGFU0cwRdXV0OXXqvD/PLVUT?= =?Windows-1252?Q?RtMmE8n6mRGYMKSJZ38d17SGlMwa4HI2UGFhuZbZyHCibbtLJ7qncCG1?= =?Windows-1252?Q?aVJXQKeyJlVrlWM9C5f6tVdeKmCPccwjtLs/Ed+oYdtY77CORBkJBBrZ?= =?Windows-1252?Q?r7IDsZ/oIitacwg7j7Q2kMQHJMEpoHLBzdbKtCJTW8M5IbTEYbWbdBdI?= =?Windows-1252?Q?EkOQTfUUCleou1wo6T2NxwryLbnGuL/VRdUMpjn1ZjKw3A9UX0bMMUlW?= =?Windows-1252?Q?mqfb87Yk218dg+Nobji7XC4eo3FJMi8Qo5q3WRglj/KJFEfJPNT2fmTI?= =?Windows-1252?Q?mS7+YlNT9sijcLQIz2EgumL6en0uPDR5/Szbgb+134jwEHAb3fK1FhMH?= =?Windows-1252?Q?LhXNEd3SBq7aVHFcqMMk/ZR+S9YvjITr6uwZ9jhLwvz93SDGcgco0Pi9?= =?Windows-1252?Q?JGLJnNIvp7WgbxEFphwDsHGClYGrPh+UIcivZmd2Haj/GEFvybd1mS3a?= =?Windows-1252?Q?IHRjE8NlxkDKGHL/500on32RVsVfoiAOPT9HWGX6FEv53rls8VfuNmSD?= =?Windows-1252?Q?UrTOW+psHphGqMMoja23UHAE1A1rBzBI6Ugob7Hq2DObfV1Ctu79kTAd?= =?Windows-1252?Q?yKH0ZWjGq7RVeRTldoDT+EFJmdbjruL8a/e9BF4wrv0JrWbMM1KC1cC7?= =?Windows-1252?Q?WxyHAT+0yOvOU7ytWE+7eI8q/RFxL6MOWUhyovX2L5n5PcR1tg6c+Ps3?= =?Windows-1252?Q?t4Y6zKCzo/vu0jQJo+T3TFEsuGiOJL5HFtJ8P8+4GFWlAycZsJ7SJ9DI?= =?Windows-1252?Q?0tyZnt6RPeH8p/QvgKLixOGikQs0aJNQXBb8kyUnGRVJEJL5GvlA6YaZ?= =?Windows-1252?Q?Fho37iUGl9I8BUMl+QlZzEhcNWCuQvVWqO61KkhQif4Odw4s3Wv9t0i2?= =?Windows-1252?Q?QnR8iZ3vNFWxgKOLGj1ED6ihsDbsqr+rfQtaOV0AHbqloIHYlxHhzfx/?= =?Windows-1252?Q?qdtnLWP8LbyAENnXYMlL7//o0OtK0Zle/uHXkJq09q6nbJ1kYLXxKugQ?= =?Windows-1252?Q?iLqIqmkF1uZyKzdUcZ32ggdZOU0Lauh3MFDcCr9SmB0AiZI697PSCznV?= =?Windows-1252?Q?/HFLuSL52H6qv0s1Lv7g6OVRsNUgm6kxsDW9aJu2maDpvglYXPNxRTzq?= =?Windows-1252?Q?/CXrGqHe4J2rLN/Z0UulNPOeKVzFoVtoLSoVRutWoodFoo7stiAR+qQf?= =?Windows-1252?Q?A//3dMoMftJ/8sEEhCebi5f0ZcGuJhT83c5z5/u4Mu0RWAlpFxwJ1fiJ?= =?Windows-1252?Q?tlci1FUEE0Fh/59mU84hEUYDmOHqtPR+Fv782z6Sd2AMB/I85sIqAE?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR02MB1141;6:x5nr3d2LFB0tOJ3ev0VdIGWM/y+EHLXw+/ePRU+5CN1pYGtyzVOx2wcHG0gMyMVMnFk3mL0Pfjwr3ZSuUtgBHziMTy4q9Ot8YR2V3tb4qaX3cqsJj33hSBHDkPYzCyzGzsbRdXuvky5ripo6OGgTl8722Xua4UMbJgDmVxBFD8sX3HZ6r5EEvd6zm8e6bm0kjvRL4f6fzrNxm4kS2zUcDJ2qAWf7hSIknIa9b6NTsH+9ZzYciOxhxUU2Tou4lUwdbZ4bAWz+wUuWoT4tqH0JBnKr1EHtClrUC+6aiqgZ8V6D305pNzjQmJUurFhbuvoDpJcYN2SFvLgbgwABh0omsQ==;5:bUFttLJLjWYFmJxLGSHmz+wCgaIP5RWp12uJemAgfXWKYQ7g2vJm6/VekjQbGOyLpYSrNW33agIxnmqPDOcBFkPIT0T+NnHMVHBfa/z+tbw2/Q4zP3g1iNtNkOeKlgaG4mogM88OYNEanOka7nD0tA==;24:f1LaLrf7mh2qT9fWdA3wnrU8S4An4HMIsUzHqaM/9/sHJ4kt349dl/s6Rpn324JF5XIg9PUev3l5RPjZsKDnuIhxlK1nddUk/6ymDKPxobw=;7:qak5jQPyBFKJw7NcuyUm+kk5td7kW9DK+1C05aivXe/kTtaPFV88Qatq/KZodN8A2OCfe0y6AArg/3Yvx3L2NYC9T8YFZfBTqt+eQjCHakgftTLL/VN8bTp1+8nk3lsWMuhK0IWA46JYwWP5HsdgK5ZwpanmAibZck28mQ9HwO6u6whNsvr2fkF8WKCsmrdJ7hsnnFsTueXaCIRvz5UtM1XSBXMnQTqdBg5K3p42VzpDctH2OmzLv75/qpovfqik SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 07:19:08.8087 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR02MB1141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.8.2016 01:01, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > Additionally in some situations it will make sense to use the > "broken-cd" and "non-removable" property together. > i.e the sd device is non-removable so polling doesn't make sense, but > the CD is broken and the controller will need to be in test mode to > function. > > This patch modifies the documentation to reflect those differences > from the standard behaviours. > > Signed-off-by: Zach Brown > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..b41c448 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -37,6 +37,14 @@ Optional Properties: > in place we will export a clock representing the Card Clock. This clock > is expected to be consumed by our PHY. You must also specify > > +Card detection: > +The arasan controller does not work > +when the CD bit is not supplied unless in test mode. > +- broken-cd: The CD bit is not supplied and the controller will > + need to be set to test mode to function. > +- non-removable: like normal, except it can now be partnered with > + broken-cd, which will turn off polling, but keep test mode on. > + > Example: > sdhci@e0100000 { > compatible = "arasan,sdhci-8.9a"; > @@ -72,4 +80,4 @@ Example: > phy-names = "phy_arasan"; > #clock-cells = <0>; > status = "disabled"; > - }; > + } ; Probably you don't need this change. M