mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Liu, Jingqi" <jingqi.liu@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wang, Wei W" <wei.w.wang@intel.com>
Subject: Re: [PATCH RESEND] KVM: x86: Expose CLDEMOTE CPU feature to guest VM
Date: Wed, 13 Jun 2018 18:23:10 +0200	[thread overview]
Message-ID: <f2a4ab77-3d29-2c8e-2494-df46881df5e4@redhat.com> (raw)
In-Reply-To: <09D68D4CF52CAF489B702DEBDD12D3D352728A00@SHSMSX103.ccr.corp.intel.com>

On 04/06/2018 09:19, Liu, Jingqi wrote:
> Hi Paolo,
> 
> I had changed the Signed-off-by chain.
> Could you help to review?
> Thanks.

The patch has been applied, thanks.

Paolo

> On 5/22/2018 5:01 PM, Liu, Jingqi wrote:
> 
>>
>> The CLDEMOTE instruction hints to hardware that the cache line that contains
>> the linear address should be moved("demoted") from the cache(s) closest to the
>> processor core to a level more distant from the processor core. This may
>> accelerate subsequent accesses to the line by other cores in the same coherence
>> domain, especially if the line was written by the core that demotes the line.
>>
>> This patch exposes the cldemote feature to the guest.
>>
>> The release document ref below link:
>> https://software.intel.com/sites/default/files/managed/c5/15/\
>> architecture-instruction-set-extensions-programming-reference.pdf
>> This patch has a dependency on https://lkml.org/lkml/2018/4/23/928
>>
>> Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
>> ---
>>  arch/x86/kvm/cpuid.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index
>> 82055b9..72d8c49 100644
>> --- a/arch/x86/kvm/cpuid.c
>> +++ b/arch/x86/kvm/cpuid.c
>> @@ -403,7 +403,8 @@ static inline int __do_cpuid_ent(struct
>> kvm_cpuid_entry2 *entry, u32 function,
>>  	const u32 kvm_cpuid_7_0_ecx_x86_features =
>>  		F(AVX512VBMI) | F(LA57) | F(PKU) | 0 /*OSPKE*/ |
>>  		F(AVX512_VPOPCNTDQ) | F(UMIP) | F(AVX512_VBMI2) | F(GFNI)
>> |
>> -		F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
>> F(AVX512_BITALG);
>> +		F(VAES) | F(VPCLMULQDQ) | F(AVX512_VNNI) |
>> F(AVX512_BITALG) |
>> +		F(CLDEMOTE);
>>
>>  	/* cpuid 7.0.edx*/
>>  	const u32 kvm_cpuid_7_0_edx_x86_features =
>> --
>> 1.8.3.1
> 


      reply	other threads:[~2018-06-13 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  9:01 Jingqi Liu
2018-06-04  7:19 ` Liu, Jingqi
2018-06-13 16:23   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2a4ab77-3d29-2c8e-2494-df46881df5e4@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jingqi.liu@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wei.w.wang@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®