From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdJMQdp (ORCPT ); Fri, 13 Oct 2017 12:33:45 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:56124 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbdJMQdn (ORCPT ); Fri, 13 Oct 2017 12:33:43 -0400 X-Google-Smtp-Source: ABhQp+QJd+05j/F1R42Hm9Df9Q2eZBQS8dp28zNtnk6XV2/aQJgQqzxZkA0xSoGfgabpojiIHPEpCQ== Subject: Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops To: Bart Van Assche , "ming.lei@redhat.com" Cc: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "tom81094@gmail.com" , "paolo.valente@linaro.org" , "linux-scsi@vger.kernel.org" , "oleksandr@natalenko.name" , "john.garry@huawei.com" , "osandov@fb.com" , "loberman@redhat.com" References: <20171012183704.22326-1-ming.lei@redhat.com> <20171012183704.22326-5-ming.lei@redhat.com> <9a741c03-90a3-e583-ddde-0ed71c8570a2@kernel.dk> <20171013001919.GA24715@ming.t460p> <6efdb459-8746-562d-06dc-5b3e172076e1@kernel.dk> <20171013160731.GA30899@ming.t460p> <1507912260.13345.0.camel@wdc.com> From: Jens Axboe Message-ID: Date: Fri, 13 Oct 2017 10:33:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507912260.13345.0.camel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2017 10:31 AM, Bart Van Assche wrote: > On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: >> Actually it is in hot path, for example, lpfc and qla2xx's queue depth is 3, > > Sorry but I doubt whether that is correct. More in general, I don't know any modern > storage HBA for which the default queue depth is so low. That does seem insanely low. BTW, even a low depth isn't an issue, as long as we know what it roughly is. -- Jens Axboe