Re: [PATCH v3 4/4] arm64: dts: qcom: lemans-evk: Enable secondary USB controller in host mode

[Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>]

On 1/19/2026 12:01 PM, Dmitry Baryshkov wrote:
> On Mon, Jan 19, 2026 at 09:42:03AM +0530, Swati Agarwal wrote:
>> On Wed, Jan 14, 2026 at 11:39 AM Dmitry Baryshkov
>> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>>>
>>> On Wed, Jan 14, 2026 at 11:10:26AM +0530, Swati Agarwal wrote:
>>>> On Tue, Jan 13, 2026 at 4:59 PM Dmitry Baryshkov
>>>> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>>>>>
>>>>> On Tue, Jan 13, 2026 at 01:32:41PM +0530, Swati Agarwal wrote:
>>>>>> On Sat, Dec 20, 2025 at 9:47 PM Dmitry Baryshkov
>>>>>> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>>>>>>>
>>>>>>> On Sat, Dec 20, 2025 at 12:05:37PM +0530, Swati Agarwal wrote:
>>>>>>>> Enable secondary USB controller in host mode on lemans EVK Platform.
>>>>>>>>
>>>>>>>> For secondary USB Typec port, there is a genesys USB HUB GL3590 having 4
>>>>>>>> ports sitting in between SOC and HD3SS3220 Type-C port controller and SS
>>>>>>>> lines run from the SoC through the hub to the Port controller. Mark the
>>>>>>>> second USB controller as host only capable.
>>>>>>>>
>>>>>>>> Add HD3SS3220 Type-C port controller along with Type-c connector for
>>>>>>>> controlling vbus supply.
>>>>>>>>
>>>>>>>> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
>>>>>>>> ---

[...]

>>>>>>>> +&usb_1 {
>>>>>>>> +     dr_mode = "host";
>>>>>>>> +
>>>>>>>> +     #address-cells = <1>;
>>>>>>>> +     #size-cells = <0>;
>>>>>>>> +
>>>>>>>> +     status = "okay";
>>>>>>>> +
>>>>>>>> +     usb_hub_2_x: hub@1 {
>>>>>>>> +             compatible = "usb5e3,610";
>>>>>>>> +             reg = <1>;
>>>>>>>> +             peer-hub = <&usb_hub_3_x>;
>>>>>>>> +             #address-cells = <1>;
>>>>>>>> +             #size-cells = <0>;
>>>>>>>> +
>>>>>>>> +             ports {
>>>>>>>> +                     #address-cells = <1>;
>>>>>>>> +                     #size-cells = <0>;
>>>>>>>> +
>>>>>>>> +                     port@1 {
>>>>>>>> +                             reg = <1>;
>>>>>>>> +
>>>>>>>> +                             usb_hub_2_1: endpoint {
>>>>>>>> +                                     remote-endpoint = <&usb1_hs_in>;
>>>>>>>> +                             };
>>>>>>>
>>>>>>> Are all other ports disconnected? If so, why do we need a hub?
>>>>>> Hi Dmitry,
>>>>>> I didn't understand your query, can you give more context to it?
>>>>>
>>>>> You have described one port of the hub. How are other ports routed? Are
>>>>> they connected to outer ports? To some other devices? Unconnected?
>>>> Hi Dmitry,
>>>> I would like to put it this way, USB HUB has 4 ports but only one port
>>>> of the hub is used between SOC and Type-C controller.
>>>> Remaining 3 ports are used by other devices.
>>>
>>> Which devices?
>> Hi Dmitry,
>>
>> For Lemans EVK standalone corekit board, there are 4 ports as follows:-
>>
>> 1) p1 is connected to type c port controller.
>> 2) p4 is used for the m.2 E key (NFA765 Bluetooth) on corekit. This
>> isn't used on a standard core kit, only if we optionally replace the
>> wifi card with the NFA765 which uses USB for BT. standard kits all use
>> UART for BT.
> 
> Nice. Hopefully Mani patches will be landed soon and we can describe
> this one properly.
> 
>>
>> Remaining 2 ports will become functional when the interface plus
>> mezzanine is stacked on top of corekit.
>>
>> 3) p2 is connected to another hub which is present on the mezz through
>> which 4 type-A ports are connected.
>> 4) p3 is used for the m.2 B key for a 5G card when the mezz is connected.
> 
> Please add a comment for these two, e.g. routed to the connector ABCDEF.
> 

Hi Dmitry,

  Thanks for the review. Can we send v4 with the following changes:

  Add 4 ports each to hs and ss hub nodes and link the first port to 
Type-C connector and add comments for the other 3 ports. When M.2 E 
conncetor comes up, we can link the second port to it in a different patch.

  Let me know if the above is reasonable.

Regards,
Krishna,