mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
To: Johnny Kim <johnny.kim@atmel.com>
Cc: "Raphaël Beamonte" <raphael.beamonte@gmail.com>,
	"Rachel Kim" <rachel.kim@atmel.com>,
	"Dean Lee" <dean.lee@atmel.com>,
	"Chris Park" <chris.park@atmel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] staging: wilc1000: code style: fix globals initialized to false
Date: Sun, 16 Aug 2015 01:30:13 -0400	[thread overview]
Message-ID: <f2aa32ae321011c30cb9af96ff32fcc56c5faf0e.1439702894.git.raphael.beamonte@gmail.com> (raw)
In-Reply-To: <cover.1439702894.git.raphael.beamonte@gmail.com>
In-Reply-To: <cover.1439702894.git.raphael.beamonte@gmail.com>

Globals should not be initialized to 0 or NULL.

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 4 ++--
 drivers/staging/wilc1000/wilc_wlan.c      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index bab5319..53c4ca9 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -536,7 +536,7 @@ typedef enum {
 tstrWILC_WFIDrv *terminated_handle;
 tstrWILC_WFIDrv *gWFiDrvHandle;
 #ifdef DISABLE_PWRSAVE_AND_SCAN_DURING_IP
-bool g_obtainingIP = false;
+bool g_obtainingIP;
 #endif
 u8 P2P_LISTEN_STATE;
 static struct task_struct *HostIFthreadHandler;
@@ -558,7 +558,7 @@ static u8 gapu8RcvdSurveyResults[2][MAX_SURVEY_RESULT_FRAG_SIZE];
 
 static u8 gapu8RcvdAssocResp[MAX_ASSOC_RESP_FRAME_SIZE];
 
-bool gbScanWhileConnected = false;
+bool gbScanWhileConnected;
 
 static s8 gs8Rssi;
 static s8 gs8lnkspd;
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
index fac16db..4c40955 100644
--- a/drivers/staging/wilc1000/wilc_wlan.c
+++ b/drivers/staging/wilc1000/wilc_wlan.c
@@ -482,7 +482,7 @@ static int wilc_wlan_txq_filter_dup_tcp_ack(void)
 #endif
 
 #ifdef TCP_ENHANCEMENTS
-bool EnableTCPAckFilter = false;
+bool EnableTCPAckFilter;
 
 void Enable_TCP_ACK_Filter(bool value)
 {
-- 
2.1.4


  parent reply	other threads:[~2015-08-16  5:30 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-16  5:30 [PATCH 0/3] staging: wilc1000: code style patches Raphaël Beamonte
2015-08-16  5:30 ` [PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements Raphaël Beamonte
2015-08-17  9:08   ` Dan Carpenter
2015-08-17 14:39     ` Raphaël Beamonte
2015-08-17 16:08       ` [PATCH 0/5] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-17 19:28         ` [PATCHv2 " Raphaël Beamonte
2015-08-17 19:28           ` [PATCHv2 1/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-17 19:28           ` [PATCHv2 2/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 19:55             ` Greg Kroah-Hartman
2015-08-17 23:06               ` [PATCHv3] staging: wilc1000: use netdev_* " Raphaël Beamonte
2015-08-18  4:24                 ` Sudip Mukherjee
2015-08-18  5:27                   ` Raphaël Beamonte
2015-08-18  6:10                     ` Sudip Mukherjee
2015-08-19  2:58                 ` Greg Kroah-Hartman
2015-08-17 19:28           ` [PATCHv2 3/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 19:28           ` [PATCHv2 4/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 20:01             ` Greg Kroah-Hartman
2015-08-17 19:28           ` [PATCHv2 5/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 19:41             ` Arend van Spriel
2015-08-17 23:12               ` [PATCHv3] " Raphaël Beamonte
2015-08-17 23:46                 ` Dan Carpenter
2015-08-18  9:15                   ` Dan Carpenter
2015-08-18 17:06                     ` Raphaël Beamonte
2015-08-19  2:59                       ` Greg Kroah-Hartman
2015-08-19  3:14                         ` [PATCHv4 0/2] staging: wilc1000: code improvements Raphaël Beamonte
2015-08-19  3:14                         ` [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-09-03  1:19                           ` Greg Kroah-Hartman
2015-09-05 16:25                             ` Raphaël Beamonte
2015-09-05 16:29                               ` Raphaël Beamonte
2015-08-19  3:14                         ` [PATCHv4 2/2] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 23:15               ` [PATCHv2 5/5] " Raphaël Beamonte
2015-08-17 16:08       ` [PATCH 1/5] staging: wilc1000: remove DECLARE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 16:08       ` [PATCH 2/5] staging: wilc1000: remove FREE_WILC_BUFFER() Raphaël Beamonte
2015-08-17 17:42         ` Dan Carpenter
2015-08-17 16:08       ` [PATCH 3/5] staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid possible memory leak Raphaël Beamonte
2015-08-17 17:31         ` Dan Carpenter
2015-08-17 16:08       ` [PATCH 4/5] staging: wilc1000: use pr_* instead of printk Raphaël Beamonte
2015-08-17 17:47         ` Dan Carpenter
2015-08-17 17:59           ` Raphaël Beamonte
2015-08-17 18:06             ` Dan Carpenter
2015-08-17 16:08       ` [PATCH 5/5] staging: wilc1000: remove void function return statements that are not useful Raphaël Beamonte
2015-08-16  5:30 ` Raphaël Beamonte [this message]
2015-08-16  5:30 ` [PATCH 3/3] staging: wilc1000: code style: fix open brace { on wrong line Raphaël Beamonte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2aa32ae321011c30cb9af96ff32fcc56c5faf0e.1439702894.git.raphael.beamonte@gmail.com \
    --to=raphael.beamonte@gmail.com \
    --cc=chris.park@atmel.com \
    --cc=dean.lee@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome