From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9BDE42D747 for ; Mon, 27 Jul 2026 20:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184383; cv=none; b=aZ0VWX6G3qH+0i7ScD1KASQW+/w4fb6OuUsOFG/MlmyGeZMone5VZRqrYqCQFnIFoE1d6DZforCOvDqt+C/3hyM96tNBn+YzDu3/M7SQ/8srf01aBfVEyYxKq2oUroMZVB200jaNTejiESz9VPMhtNTcR+XYt7ChaAaC6TAcwqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184383; c=relaxed/simple; bh=OkxpDyQ63m+V46aRfjIrSXchUPYHF8ldi0EciBaxCjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y1/6FRNckXmiZJpHhv7uCOp6RK8s25Hh60GZArqdA5/NCP46nJy7V254g7yn/3f/v3C/l+3qhpa7FpE8GhuZ+jUmhnA7UP/fKnTjSg1TZ0WIfI4BcKjwjx6MHboVWbAyuRD4lpsQyK+zRc4qvT628Xnp6S7cBPM88LxbkdGU86Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L6Q5UGTM; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L6Q5UGTM" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cfff5f88dbso12622335ad.3 for ; Mon, 27 Jul 2026 13:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184382; x=1785789182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hqjCqMJEUGFa3ccm1OGMDSf5byzjSENws28lRdT9gkQ=; b=L6Q5UGTM9YuGCm1+PBoSym3n4nT+jEHME9LHVZtoV4FOKWe15VYUgic1sOlGdBLtWc J/pH3ehgS+hRGL+pYkxSZIS9vJ4siwZTjsiv0eLvu+eHcHmQeCG9rsD29SqmiJCwIqS6 /9zTLRVUZqxo7WW47GcnI9cicDxPEe7ylPyOyG3zTFw2lCg0bBs0zxh2HyrJ8WtSdfZ0 8jCVYI5IiD5aNR+73UabwjgLDLaLMfblmbRYIbJNCUHyq6lPu1tMWOX/4pp+oNor+E8f DVqMJUXLDn+oy/CF9czUYpHQFoyNMdY3mp51Nxb4x6GUxAKDnSf3AIJ3JZhBqVb46Z5G yj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184382; x=1785789182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hqjCqMJEUGFa3ccm1OGMDSf5byzjSENws28lRdT9gkQ=; b=k0Os5TO40KVQH/ouqR0G4/TzU87La6IRAiUHqXYHneLryGs7d3JLDfrd7L+a8rDWmI zGbqivDZ8LtPBnbTKvl+iU4Sf1res3ILaGhjQCrikUw2JjPJ4KbSM0NrDGfb5WPk3fhY gmm7Oai0Avdk+vIjS6kjMmpftRlu8qEMmALIyHNhbmPAFjX1/7TJ+C731L2GrFnZFJ09 jwq5j4YvhknJqVYLMlQMTp+rTXaj9t7fYpXxwOQ7k64Vt23AZ66I4ZaoBE/H7dfjM2zh pnTbXL4IagsdD9afF4ei+Ey85vYvoSAmwxXjgSUxSwUA2lfSVFCqdpTpbrP43CGn5qE6 Fi6w== X-Forwarded-Encrypted: i=1; AHgh+RruZh4Em2jbxOmjQDuuewmEvGSRtuFZ4Ny8h8G/wdhYmPT079SOccU57rI5DZHqux/GdZnYoC0JYh6SSmc=@vger.kernel.org X-Gm-Message-State: AOJu0YyB76gJr92uNyjMS96INonAf3pY6B7JFD7bEJxNyrJIJ4c8EYNU ulaysWuzd1MEfY54s+quOSRLRTZw8w6+/yBtHo18lrqYFGoV4I0roGEQ X-Gm-Gg: AR+sD13z55+IvRVPEIL2AmV9ynzKzPpttu5EIM69URKrUHZDtwN+ptmiCr8lErV6O4r R5X+Wl+PzreTNDomP8ggPo4p42omVPDTKB5j7TumN1lMoYSf2RFm7FkgthT8l+TRhhxE3U2Gwko nBMI7xwZjmzIF5c0O22QNGTQ0FlBgLG/tC1v/fDyfxx8sAzJ0k2u9EY3UBaaTQ7cySih7+K7LX2 X06il+/vwJGLQ30KKU32DbkjbSVD9DfxVLMFLqmJ1vROwTOvtxxdNqUCS53ZHBT7tgfaDfA6Iko yK9J0Z1O5dyfbokanoDFzGY+zLymLrnJ7acQN8Tidq4RXHZLcr/wseS37JEu0PYonycBR3kjywu pC7k/eWjQeqkryAf/aUfDDkBfy2U7TxaGKpyNaXEHxUkamemE0NXDuoZ4IZW0tFrj3bE48KgUIK MgiSp2 X-Received: by 2002:a17:903:246:b0:2c9:a9c0:80b6 with SMTP id d9443c01a7336-2d00f3e0af2mr8180295ad.34.1785184382087; Mon, 27 Jul 2026 13:33:02 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:32:57 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Logan Gunthorpe Subject: [PATCH v2 28/64] dmaengine: plx_dma: use channel BH helpers Date: Mon, 27 Jul 2026 13:28:56 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the device tasklet with the per-channel BH helper so completion callbacks run via dma_chan_*_bh. Signed-off-by: Allen Pais --- drivers/dma/plx_dma.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 84941a918b01..9d6bbdfa5a69 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -105,7 +105,6 @@ struct plx_dma_dev { struct dma_chan dma_chan; struct pci_dev __rcu *pdev; void __iomem *bar; - struct tasklet_struct desc_task; spinlock_t ring_lock; bool ring_active; @@ -241,9 +240,10 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev) rcu_read_unlock(); } -static void plx_dma_desc_task(struct tasklet_struct *t) +static void plx_dma_desc_task(struct dma_chan *chan) { - struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task); + struct plx_dma_dev *plxdev = container_of(chan, struct plx_dma_dev, + dma_chan); plx_dma_process_desc(plxdev); } @@ -366,7 +366,7 @@ static irqreturn_t plx_dma_isr(int irq, void *devid) return IRQ_NONE; if (status & PLX_REG_INTR_STATUS_DESC_DONE && plxdev->ring_active) - tasklet_schedule(&plxdev->desc_task); + dma_chan_schedule_bh(&plxdev->dma_chan); writew(status, plxdev->bar + PLX_REG_INTR_STATUS); @@ -471,7 +471,7 @@ static void plx_dma_free_chan_resources(struct dma_chan *chan) if (irq > 0) synchronize_irq(irq); - tasklet_kill(&plxdev->desc_task); + dma_chan_kill_bh(&plxdev->dma_chan); plx_dma_abort_desc(plxdev); @@ -510,7 +510,7 @@ static int plx_dma_create(struct pci_dev *pdev) goto free_plx; spin_lock_init(&plxdev->ring_lock); - tasklet_setup(&plxdev->desc_task, plx_dma_desc_task); + dma_chan_init_bh(&plxdev->dma_chan, plx_dma_desc_task); RCU_INIT_POINTER(plxdev->pdev, pdev); plxdev->bar = pcim_iomap_table(pdev)[0]; -- 2.43.0