From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC8CE81DE9 for ; Fri, 6 Oct 2023 11:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbjJFL7x (ORCPT ); Fri, 6 Oct 2023 07:59:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230503AbjJFL7u (ORCPT ); Fri, 6 Oct 2023 07:59:50 -0400 X-Greylist: delayed 595 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Oct 2023 04:59:48 PDT Received: from 10.mo581.mail-out.ovh.net (10.mo581.mail-out.ovh.net [178.33.250.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2F50CE for ; Fri, 6 Oct 2023 04:59:48 -0700 (PDT) Received: from director6.ghost.mail-out.ovh.net (unknown [10.108.16.32]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 26FF626922 for ; Fri, 6 Oct 2023 11:49:52 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-8w4bk (unknown [10.110.115.151]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id CF0061FEB2; Fri, 6 Oct 2023 11:49:49 +0000 (UTC) Received: from RCM-web7.webmail.mail.ovh.net ([151.80.29.19]) by ghost-submission-6684bf9d7b-8w4bk with ESMTPSA id ToM7MF30H2X07Q0AgIPZcA (envelope-from ); Fri, 06 Oct 2023 11:49:49 +0000 MIME-Version: 1.0 Date: Fri, 06 Oct 2023 13:49:49 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Miquel Raynal Cc: Srinivas Kandagatla , Greg Kroah-Hartman , Michael Walle , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Marko , Thomas Petazzoni , Luka Perkov , Randy Dunlap , Chen-Yu Tsai , Daniel Golle Subject: Re: [PATCH v12 5/7] nvmem: core: Rework layouts to become regular devices In-Reply-To: <20231005155907.2701706-6-miquel.raynal@bootlin.com> References: <20231005155907.2701706-1-miquel.raynal@bootlin.com> <20231005155907.2701706-6-miquel.raynal@bootlin.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: rafal@milecki.pl X-Originating-IP: 31.11.218.106 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 17609074545689144221 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrgeeigdegfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeggfffhvfevufgjfhgfkfigihgtgfesthekjhdttderjeenucfhrhhomheptfgrfhgrlhcuofhilhgvtghkihcuoehrrghfrghlsehmihhlvggtkhhirdhplheqnecuggftrfgrthhtvghrnhepjedvlefguedthfefleehgeeftdeludeluedvgfeffeevhfevtdehteejteefheegnecukfhppeduvdejrddtrddtrddupdefuddruddurddvudekrddutdeipdduhedurdektddrvdelrdduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkedupdhmohguvgepshhmthhpohhuth Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-10-05 17:59, Miquel Raynal wrote: > +static struct bus_type nvmem_layout_bus_type = { > + .name = "nvmem-layouts", > + .match = nvmem_layout_bus_match, > +}; > + > +static struct device nvmem_layout_bus = { > + .init_name = "nvmem-layouts", > +}; Nitpicking: would it be more consistent and still make sense to use singular form "nvmem-layout"? By looking at my /sys/bus/ I can see there: 1. cpu (not cpus) 2. gpio (not gpios) 3. node (not nodes) 4. nvmem (not nvmems) etc. -- Rafał Miłecki