From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EB2819CCFC for ; Mon, 20 Jan 2025 09:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.89 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737364506; cv=fail; b=B2o50vm5UMfxkdvj7TE+zRtPG5rOeDkIh0NcnLn76LfO41ThYtF9SULPKDduvimdEu6NUpNnyAKKH63H1FZ/j+j9wP/6aK2hdKhd008kNsuHeLbCFKtA/zeMkNvj6TWdgtUldBekzFlpCUJHg1v7g2pwDKQ2yjRr0WLSkDuyKDE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737364506; c=relaxed/simple; bh=0pnPJHtEu44pwx4dMY0pxEu6Pnl4BRy2PjONyEvdvmY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fFA4h8bx+pAsYjXmhdKrtkXRy9lA/cEm7V6hGxvApee56iLuJ2zQFecV/LJ1AxPms9/lgSlhfLldkzVcdxD/X21jLdbMvZhb/WUF5Jnq4sWUeQ1YyJXlfYJ//J1a/iGpzEv3yvwI8a7mVu4NFATeZH4K6LSb2VUCcqK2ICmPszQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=flBQd+Qs; arc=fail smtp.client-ip=40.107.92.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="flBQd+Qs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P1YtQZByc/ChDRE7ojw0XzyuMVkCEyRmlm+3+bNEm5wuoPw0+btJ8Cp55n/5UYL3YeBwlOTlsqonMJdZvGls5XpVScktyWnP+4QBFJHq5vutylgeTUlRJ3ckvMPYlVscmVEIPrNSaEtZyyu4ThnoW3bEX0hFhHr5nJ1vgzF+Q590T4j3MKRwRODmC2/kIFJ6FG4OUtnAgcZeDb7zlyC/vpGf7ha0Maov42eF37E8D/QJSxWPLMFErf0jGTNOPTxKJQKbXT+1cicfpUxHm0GE60hKBLz5lT6yI7ROg/enPhvEjf3x9ru2JNkeQypUWP8IOEllT1b58RA4l+ENc4fL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Voa0WeYJQpKaPDCIq2gQeZCkZZmv9AXRZ+jhrcQZlJ8=; b=xCX0ciKWEECfo2xfFu2bXhmfMP2TdI3vJrpAUoFxotibwM5NbYT9S3MMo+NBa7xV8YQLstLn41BISSrlhCCrRyAxTO5vleWFUe4MJ4AExC4jdVC3HEdVSoBuzVoYuXwHqpArhWO0fcRpjOh3OhAcZNT3X8xvavqtIyI78N4h/cQM/sSc5kYNHjBoTgFZsxSh8Mf7C3A1j2EB1MRX7pdF0qpc1zSURcQcLp8qEJwLn8uiGVifSxTfEMF2TdqmbXtqzrhqOulZnsgUUULEz5KeUujCjPsvkU7sxm8ENki631PcHp043aLCSjyZnJ2mP5W/LB5HDsrJAUYUS81p+Q1Ahg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Voa0WeYJQpKaPDCIq2gQeZCkZZmv9AXRZ+jhrcQZlJ8=; b=flBQd+Qsb7kpiztDrjr5zDbRmhs+VXirljHbypMgjm6lhevuERlgq2URNzFoWLCtMAET58X8Rh/OaRI6FxCpsCqWCJueDVjStNZ3ky+4ZfD9sTunlWtDaOz21VRXvDXGBSwSnXriCmS3txXsjWP1HNsZrMOprjkW1PK7n9Vu0K8= Received: from BL1PR13CA0127.namprd13.prod.outlook.com (2603:10b6:208:2bb::12) by SA1PR12MB8698.namprd12.prod.outlook.com (2603:10b6:806:38b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Mon, 20 Jan 2025 09:14:59 +0000 Received: from BN2PEPF000044A3.namprd02.prod.outlook.com (2603:10b6:208:2bb:cafe::c6) by BL1PR13CA0127.outlook.office365.com (2603:10b6:208:2bb::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.13 via Frontend Transport; Mon, 20 Jan 2025 09:14:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000044A3.mail.protection.outlook.com (10.167.243.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8377.8 via Frontend Transport; Mon, 20 Jan 2025 09:14:58 +0000 Received: from [172.31.188.187] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 20 Jan 2025 03:14:54 -0600 Message-ID: Date: Mon, 20 Jan 2025 14:44:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Fix inaccurate h_nr_runnable accounting with delayed dequeue To: Madadi Vineeth Reddy CC: , , , , , , , , , , , References: <20250120050639.48966-1-vineethr@linux.ibm.com> <20250120084441.17746-1-vineethr@linux.ibm.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20250120084441.17746-1-vineethr@linux.ibm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A3:EE_|SA1PR12MB8698:EE_ X-MS-Office365-Filtering-Correlation-Id: 323b6df6-3455-4755-e200-08dd3932e9bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?STJqM2VrUEtCVldFZWNuVmpZb2VjSm1nS2c0VVZ0MUFsMlFUWnRKazhPbVR6?= =?utf-8?B?TmtJSCtRK0hWZ09xbDhUN2N1bDdvOUhZUEhuZDNqQld6UEk0Q1A5SmhFbjNh?= =?utf-8?B?SFU5NHJPNG1RUGxaT0NGLzE2ZnQ2OFUzVVdIcnBsTVBJUE02aldSUjZadDVu?= =?utf-8?B?L3BRRjVlNFFQQ0xYTjJ2TDU2RXM5VDlSU3RKNUtVWGhyS3lsMTNnTVBLanZo?= =?utf-8?B?L2h5RUJhZW1Jek02S3lRS1FHMHRFaThGNWtORGV6TERyVzhEMGlPSkVkREUx?= =?utf-8?B?OC9iTENVNVZENUw0d0hyQ1YzRjRHR3Q2ZE5DRmxVNWlob3lLajA0UHdtTjFR?= =?utf-8?B?b2d5N3VMVDcvanphOC8zTVZ0Zlg4b3FvbHhkRExxL1ErNGxFMWU5TWMyQkN6?= =?utf-8?B?Y2U2d0VTK1JYNHNQbGoyZ2RPOGxtejZyeXVOeWZldnNqQ3NqVmlLV2hGck8x?= =?utf-8?B?SG51RG50em5udDNIZHFYdkM1SXA2eEhuWnR0bHBmYTNhY01vVE9GQ2I0cTFP?= =?utf-8?B?OTk4MjhoMTAzVWRLcUxkblNPTVhJQXdUd29TS00vUnlXODE3NjJpL1VsU2VE?= =?utf-8?B?czdDblM3RHhiVFBjYXpoZlZxcGI3eWFRaG10b2w3ekp2QzQ2TmlqTkV6eUp3?= =?utf-8?B?Rk9MWFdSWWgwM3BXcHI1TGMzUkx5NnFHemM0UVRSVWR5MGdPUks1S0t3TWVq?= =?utf-8?B?OHhuMVI4Z2U2MWpCb1h0WG5jdm16Q1pldlI2bXpOWkhhbFA3ODEyRkh5aThp?= =?utf-8?B?emNUeHhZRE1uei9UWkNxMjdET2N3WHNCeVRPYlA1MjBiOC9HRURKS2ticlJM?= =?utf-8?B?ZDRZTmp6cGdQYWJUNS9mQmVwUG9pWDUvMEtHNWlGczlZLzZ4MDBzMEMyMGVU?= =?utf-8?B?R1U0WlptVEpKSXZmRGswQmJhNlJJQlhDbURDQ0NWZTlyZGRTaDI2Wkw3NnlW?= =?utf-8?B?bnFIU3laNm1rRnc1eDQ5ZnA3emVNZjlnSkpuZEZySHA1MzZ1QW9NZ21iMGdI?= =?utf-8?B?cm0vMU1ZQTYrenlaeXRIVDVBODlrbFF1blB4SXRscEYwUVNjOHB1eXNNWFpu?= =?utf-8?B?eVpPVm92RFQveFhhV1VQSG0xRnJZRncwWGpNYjZROTVNS25OVWt3elJjdE85?= =?utf-8?B?elk2L1BUVXBaYjFnRjlwY0dNUG1haWQ2K2VPMURkU2VlVEFWcEJ1Y2g5aGhG?= =?utf-8?B?dTZvZ1plK2s2eUpZS0JLZWRLd1Z3cDJmVk45emR3Qnk0WUlCZU1PTFl1R1A0?= =?utf-8?B?cGplbVB6N1FvOUJ4TEpzU0VEMXJtcnZQbStSY01oWDJIY3c3Vjd1dXZFQnRX?= =?utf-8?B?ckh2SkJpYmxCY1E3NmF3RmwycTBlb2lKQjZYdHp4OUVxcTY5YUxVVWtqUFo5?= =?utf-8?B?YzdCYXVWUjFXckVUN1dUUUdKKzVQY3RaUjBjcy9maW5rcFo4SWF1SHJpdE1o?= =?utf-8?B?TjN2bmZyaStUcHhHdGUzMU5wMnNvZHdjako5QklLNUZXY3Y1SlRFYmc0cm9k?= =?utf-8?B?MWFPL0Y3TncySzdnWkR6SEd1R3pUWCs5VXoyTWdaRmpLYjczZ2cxdUZQS1hP?= =?utf-8?B?TFVqS0xVMGZjbllSbE40OUJLdDNyalhieStLR0FSK2NKQkVJcmdLaXNzblp0?= =?utf-8?B?WTdtMXYyTWFFREdGaDdQMVpWV21tbTRydjgrQ3RvT29xamFCTGhJMVpkZTVh?= =?utf-8?B?MVlObkR2SVFqN2FrSmxrMTBmNkJoUy9SQ2tPQkFNM1lLT3R3T29DQkI2MXlz?= =?utf-8?B?ak1KanlFOEtzSHVOTEpVeUVqRG1KalZtWnl3Uk9zeGxWdEpTU3BpaVVSVWVw?= =?utf-8?B?aENlM1Bnb2NtNWhHaTRZMWZOM1poU3pjT2lEalNVRS9BQUp3M1VCeFNSUzBl?= =?utf-8?B?cThRUnAzRy9IZDJQUlV5ejg3N0VlSUVrdTZLZGFyZHlVU04yOEZGM1prMGNP?= =?utf-8?B?OFJHanZtak1UMmp4S2p1d2NNZEI4K2toajk1WTBzUXZNK1lhNlVqMDRqMW1C?= =?utf-8?Q?mxeSBARchmDDgFmU1kLoq0YLbsAm0s=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 09:14:58.8249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 323b6df6-3455-4755-e200-08dd3932e9bb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A3.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8698 On 1/20/2025 2:14 PM, Madadi Vineeth Reddy wrote: >> However, I was unable to trigger the WARN_ON by running hackbench in a >> cgroup without the patch. Could you please share the specific test >> scenario or configuration you used to reproduce it? > > My mistake: SCHED_WARN_ON is a WARN_ONCE, so I had to clear it before > running hackbench to ensure the WARN_ON could be triggered again. Yup! A WARN_ON() is hit very consistently. > > Now I am able to trigger the WARN_ON in the unpatched kernel while > running hackbench after executing `echo 1 > /sys/kernel/debug/clear_warn_once` > following the initial warning during the boot process. I have verified > that the patched kernel fixes the issue. Thank you again for testing the fix. Much appreciated! > > Thanks, > Madadi Vineeth Reddy -- Thanks and Regards, Prateek