From: Zhenhua Huang <quic_zhenhuah@quicinc.com>
To: <robdclark@gmail.com>, <will@kernel.org>, <robin.murphy@arm.com>,
<joro@8bytes.org>
Cc: <iommu@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <quic_c_gdjako@quicinc.com>,
<dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 1/1] iommu/arm-smmu-qcom: remove runtime pm enabling for TBU driver
Date: Mon, 12 Aug 2024 17:18:01 +0800 [thread overview]
Message-ID: <f2b4555e-5c31-45a2-a6d0-da2689748c41@quicinc.com> (raw)
In-Reply-To: <1722335443-30080-1-git-send-email-quic_zhenhuah@quicinc.com>
Gentle reminder for review :)
On 2024/7/30 18:30, Zhenhua Huang wrote:
> TBU driver has no runtime pm support now, adding pm_runtime_enable()
> seems to be useless. Remove it.
>
> Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index 36c6b36ad4ff..aff2fe1fda13 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -566,7 +566,6 @@ static struct acpi_platform_list qcom_acpi_platlist[] = {
>
> static int qcom_smmu_tbu_probe(struct platform_device *pdev)
> {
> - struct device *dev = &pdev->dev;
> int ret;
>
> if (IS_ENABLED(CONFIG_ARM_SMMU_QCOM_DEBUG)) {
> @@ -575,11 +574,6 @@ static int qcom_smmu_tbu_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (dev->pm_domain) {
> - pm_runtime_set_active(dev);
> - pm_runtime_enable(dev);
> - }
> -
> return 0;
> }
>
next prev parent reply other threads:[~2024-08-12 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 10:30 Zhenhua Huang
2024-08-12 9:18 ` Zhenhua Huang [this message]
2024-08-12 13:25 ` Pranjal Shrivastava
2024-08-13 2:37 ` Zhenhua Huang
2024-08-13 7:20 ` Pranjal Shrivastava
2024-08-13 7:56 ` Zhenhua Huang
2024-08-13 12:06 ` Georgi Djakov
2024-08-14 6:54 ` Zhenhua Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b4555e-5c31-45a2-a6d0-da2689748c41@quicinc.com \
--to=quic_zhenhuah@quicinc.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®