mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Chaitanya Kulkarni <kch@nvidia.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, damien.lemoal@opensource.wdc.com,
	johannes.thumshirn@wdc.com, ming.lei@redhat.com,
	shinichiro.kawasaki@wdc.com, vincent.fu@samsung.com,
	yukuai3@huawei.com
Subject: Re: [PATCH] null_blk: allow teardown on request timeout
Date: Mon, 17 Oct 2022 07:21:17 -0700	[thread overview]
Message-ID: <f2baa3b4-81c9-a6d8-0c26-3e695dad5d10@acm.org> (raw)
In-Reply-To: <20221016052006.11126-1-kch@nvidia.com>

On 10/15/22 22:20, Chaitanya Kulkarni wrote:
> In current timeout implementation null_blk just completes the request
> with error=BLK_STS_TIMEOUT without doing any cleanup, hence device
> cleanup code including handling inflight requests on timeout and
> teardown is never exercised.

Hi Chaitanya,

How about removing that code instead of adding a mechanism for 
triggering it?

> Add a module parameter rq_abort_limit to allow null_blk perform device
> cleanup when time out occurs. The non zero value of this parameter
> allows user to set the number of timeouts to occur before triggering
> cleanup/teardown work.

As Ming Lei wrote, there are no other block drivers that destroy 
themselves if a certain number of timeouts occur. It seems weird to me 
to trigger self-removal from inside a timeout handler.

Thanks,

Bart.

  parent reply	other threads:[~2022-10-17 14:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-16  5:20 Chaitanya Kulkarni
2022-10-17  1:26 ` Damien Le Moal
2022-10-17  9:25 ` Ming Lei
2022-10-17  9:30   ` Chaitanya Kulkarni
2022-10-17  9:50     ` Ming Lei
2022-10-17 10:04       ` Chaitanya Kulkarni
2022-10-17 10:16         ` Ming Lei
2022-10-17 10:46           ` Chaitanya Kulkarni
2022-10-17 14:21 ` Bart Van Assche [this message]
2022-10-19  4:19   ` Chaitanya Kulkarni
2022-10-19 17:41     ` Bart Van Assche
2022-11-02  1:09       ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2baa3b4-81c9-a6d8-0c26-3e695dad5d10@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=vincent.fu@samsung.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®