From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFD2C433FE for ; Mon, 7 Nov 2022 15:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232411AbiKGPrM (ORCPT ); Mon, 7 Nov 2022 10:47:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232084AbiKGPrI (ORCPT ); Mon, 7 Nov 2022 10:47:08 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B158A1A3B4 for ; Mon, 7 Nov 2022 07:47:07 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A00C61FB; Mon, 7 Nov 2022 07:47:13 -0800 (PST) Received: from [10.57.3.218] (unknown [10.57.3.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60F3E3F534; Mon, 7 Nov 2022 07:47:06 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 15:47:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] drm/panfrost: Remove type name from internal struct again To: Alyssa Rosenzweig Cc: Alyssa Rosenzweig , Rob Herring , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221103114036.1581854-1-steven.price@arm.com> Content-Language: en-GB From: Steven Price In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2022 13:22, Alyssa Rosenzweig wrote: > Reviewed-by: Alyssa Rosenzweig Thanks, pushed to drm-misc-fixes: c4299907c09a drm/panfrost: Remove type name from internal struct again Steve > On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote: >> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with >> native ones") accidentally reverted part of the parent commit >> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs") >> leading to the situation that the Panfrost UAPI header still doesn't >> compile correctly in C++. >> >> Revert the accidental revert and pass me a brown paper bag. >> >> Reported-by: Alyssa Rosenzweig >> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones") >> Signed-off-by: Steven Price >> --- >> include/uapi/drm/panfrost_drm.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h >> index 6f93c915cc88..9f231d40a146 100644 >> --- a/include/uapi/drm/panfrost_drm.h >> +++ b/include/uapi/drm/panfrost_drm.h >> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header { >> __u64 nbos; >> } reghdr; >> >> - struct pan_bomap_hdr { >> + struct { >> __u32 valid; >> __u64 iova; >> __u32 data[2]; >> -- >> 2.34.1 >>