From: Andrew Lunn <andrew@lunn.ch>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>,
Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH net-next 3/7] bng_en: add ethtool link settings, get_link, and nway_reset
Date: Mon, 23 Feb 2026 20:44:49 +0100 [thread overview]
Message-ID: <f2bbeb1f-962d-4e7e-9b0b-5d4a4ef762d4@lunn.ch> (raw)
In-Reply-To: <20260223163641.755200-4-bhargava.marreddy@broadcom.com>
> + if (link_info->auto_pause_setting & BNGE_LINK_PAUSE_RX)
> + linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> + lk_ksettings->link_modes.advertising);
> + if (hweight8(link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) == 1)
> + linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> + lk_ksettings->link_modes.advertising);
It is not clear to me how you are configuring pause, and in particular
if pause it being autoneg or forced.
Ethtool has:
ethtool -A|--pause devname [autoneg on|off] [rx on|off] [tx on|off]
The autoneg here is separate to global autoneg. You can have global
autoneg on, but pause autoneg off, meaning the pause configuration is
forced.
The PHY should only be advertising pause if pause autoneg is on.
Andrew
next prev parent reply other threads:[~2026-02-23 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 16:36 [PATCH net-next 0/7] bng_en: add link management and statistics support Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 1/7] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-02-25 2:32 ` Jakub Kicinski
2026-02-26 14:05 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 2/7] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-02-25 2:35 ` Jakub Kicinski
2026-02-26 14:24 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 3/7] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-02-23 19:44 ` Andrew Lunn [this message]
2026-02-24 19:19 ` Bhargava Chenna Marreddy
2026-02-24 0:12 ` [net-next,3/7] " Jakub Kicinski
2026-02-25 18:11 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 4/7] bng_en: add support for link async events Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 5/7] bng_en: add initial support for ethtool stats display Bhargava Marreddy
2026-02-23 19:52 ` Andrew Lunn
2026-02-24 19:50 ` Bhargava Chenna Marreddy
2026-02-24 21:13 ` Andrew Lunn
2026-02-26 16:28 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 6/7] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 7/7] bng_en: implement ndo_get_stats64 Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bbeb1f-962d-4e7e-9b0b-5d4a4ef762d4@lunn.ch \
--to=andrew@lunn.ch \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®