From: xiaohui.xin@intel.com
To: netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
davem@davemloft.net, herbert@gondor.hengli.com.au,
jdike@linux.intel.com
Cc: Xin Xiaohui <xiaohui.xin@intel.com>
Subject: [PATCH v12 06/17] Use callback to deal with skb_release_data() specially.
Date: Thu, 30 Sep 2010 22:04:23 +0800 [thread overview]
Message-ID: <f2bf65a8a7676bbd3e8a749ae93d99e88671d35d.1285853725.git.xiaohui.xin@intel.com> (raw)
In-Reply-To: <1285855474-12110-1-git-send-email-xiaohui.xin@intel.com>
In-Reply-To: <59d8a50047ee01e26658fd676d26c0162b79e5fd.1285853725.git.xiaohui.xin@intel.com>
From: Xin Xiaohui <xiaohui.xin@intel.com>
If buffer is external, then use the callback to destruct
buffers.
Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com>
Signed-off-by: Zhao Yu <yzhao81new@gmail.com>
Reviewed-by: Jeff Dike <jdike@linux.intel.com>
---
include/linux/skbuff.h | 3 ++-
net/core/skbuff.c | 8 ++++++++
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 74af06c..ab29675 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -197,10 +197,11 @@ struct skb_shared_info {
union skb_shared_tx tx_flags;
struct sk_buff *frag_list;
struct skb_shared_hwtstamps hwtstamps;
- skb_frag_t frags[MAX_SKB_FRAGS];
/* Intermediate layers must ensure that destructor_arg
* remains valid until skb destructor */
void * destructor_arg;
+
+ skb_frag_t frags[MAX_SKB_FRAGS];
};
/* The structure is for a skb which pages may point to
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 93c4e06..117d82b 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -217,6 +217,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
shinfo->gso_type = 0;
shinfo->ip6_frag_id = 0;
shinfo->tx_flags.flags = 0;
+ shinfo->destructor_arg = NULL;
skb_frag_list_init(skb);
memset(&shinfo->hwtstamps, 0, sizeof(shinfo->hwtstamps));
@@ -350,6 +351,13 @@ static void skb_release_data(struct sk_buff *skb)
if (skb_has_frags(skb))
skb_drop_fraglist(skb);
+ if (skb->dev && dev_is_mpassthru(skb->dev)) {
+ struct skb_ext_page *ext_page =
+ skb_shinfo(skb)->destructor_arg;
+ if (ext_page && ext_page->dtor)
+ ext_page->dtor(ext_page);
+ }
+
kfree(skb->head);
}
}
--
1.7.3
next prev parent reply other threads:[~2010-09-30 13:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 14:04 [PATCH v12 00/17] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 01/17] Add a new structure for skb buffer from external xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 02/17] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 03/17] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 04/17] Add a function make external buffer owner to query capability xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 05/17] Add a function to indicate if device use external buffer xiaohui.xin
2010-09-30 14:04 ` xiaohui.xin [this message]
2010-10-01 7:14 ` [PATCH v12 06/17] Use callback to deal with skb_release_data() specially David Miller
2010-10-11 7:06 ` Xin, Xiaohui
2010-10-11 15:27 ` David Miller
2010-10-11 15:42 ` Eric Dumazet
2010-10-12 1:24 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 07/17]Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 08/17] Modify netdev_free_page() to release " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 09/17] Don't do skb recycle, if device use " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 10/17] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-09-30 14:22 ` Eric Dumazet
2010-10-11 7:06 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 11/17] Add header file for mp device xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 13/17] Add a kconfig entry and make entry " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 12/17] Add mp(mediate passthru) device xiaohui.xin
2010-10-03 13:12 ` Michael S. Tsirkin
2010-10-18 8:30 ` Xin, Xiaohui
2010-09-30 14:04 ` [PATCH v12 14/17] Provides multiple submits and asynchronous notifications xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 15/17]An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 16/17]An example how to alloc user buffer based on " xiaohui.xin
2010-09-30 14:04 ` [PATCH v12 17/17]add two new ioctls for mp device xiaohui.xin
2010-10-01 0:00 ` [PATCH v12 00/17] Provide a zero-copy method on KVM virtio-net Xin, Xiaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bf65a8a7676bbd3e8a749ae93d99e88671d35d.1285853725.git.xiaohui.xin@intel.com \
--to=xiaohui.xin@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®