mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Li RongQing <lirongqing@baidu.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] genirq: only scan the present CPUs
Date: Fri, 6 Apr 2018 16:42:14 +0800	[thread overview]
Message-ID: <f2bf898d-c9da-dfb8-f50d-6fe8ddb122e6@cn.fujitsu.com> (raw)
In-Reply-To: <20180403112311.GF4043@hirez.programming.kicks-ass.net>

Hi Thomas, Peter,

At 04/03/2018 07:23 PM, Peter Zijlstra wrote:
> On Tue, Apr 03, 2018 at 12:25:56PM +0200, Thomas Gleixner wrote:
>> On Mon, 2 Apr 2018, Li RongQing wrote:
>>
>>> lots of application will read /proc/stat, like ps and vmstat, but we
>>> find the reading time are spreading on Purley platform which has lots
>>> of possible CPUs and interrupt.
>>>
>>> To reduce the reading time, only scan the present CPUs, not all possible
>>> CPUs, which speeds the reading of /proc/stat 20 times on Purley platform
>>> which has 56 present CPUs, and 224 possible CPUs
>>
>> Why is BIOS/ACPI telling the kernel that there are 224 possible CPUs unless
>> it supports physical CPU hotplug.
> 
> BIOS is crap, news at 11. I've got boxes like that too. Use
> possible_cpu=$nr if you're bothered by it -- it's what I do.
> 

Yes, I think so. it is a manual way to reset the number.

For this situation, I am investigating to restrict the number of
possible CPUs automatically, But, due to the limitation of ACPI
subsystem, I can do it _before_ setup_percpu_area where the number will
be used.

But, I can provider an indicator to tell the system that whether the 
physical CPU hotplug is support or not later. Can we use this indicator
like that in this situation:

    if ture

	Using for_each_possible_cpu(cpu)
    else

	Using for_each_present_cpu(cpu)	



Thanks,

	dou

> 
> 

  reply	other threads:[~2018-04-06  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02  5:45 Li RongQing
2018-04-03 10:25 ` Thomas Gleixner
2018-04-03 11:23   ` Peter Zijlstra
2018-04-06  8:42     ` Dou Liyang [this message]
2018-04-06  9:02       ` Peter Zijlstra
2018-04-06  9:05         ` Peter Zijlstra
2018-04-09  6:33           ` Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2bf898d-c9da-dfb8-f50d-6fe8ddb122e6@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®