From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4C53DC4D1 for ; Wed, 18 Mar 2026 13:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841939; cv=none; b=apGGJbBgVw9EWvID7jeWEKqlPkzABSITl1OsZzSMlb4esi1nySbCkLB87i0E40fMKrKLN/FCArH1b0OeWdVY8IDDzE4Bbqp4eg6OAYFvdurtfhrG0xk+Wfw/YSAjQe0LBOU/0NEU8d/0QuUZhU6g4V5fpsxQTadOFRUPjgnxeg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841939; c=relaxed/simple; bh=1RlgzLp5SW+ICl5p5DrXEGY9p6ID8I2Pzbdjvkx+HmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YPaVBCecuiMEKeZJ14IBYrOw4ddK8SnkdMQDNGBnHCU03CTzZOmtgza93rv4oWqjmf1UnA9l2kqXQaijzK81FC4DLSstzAFBMPCDKkOBGessRrj/BLu4xE0eL1WG0pB+cvEdURtrmWVg6C0MXVtuTmbsbo/pAx9zeiqFPZP+hBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=guGJS6aZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bgjyzQWp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="guGJS6aZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bgjyzQWp" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IDmCJn2790251 for ; Wed, 18 Mar 2026 13:52:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K09W5cRQKh+ST8g4DXzvv+55soghUxhrAcpYvLnmrXE=; b=guGJS6aZ5p04seBz d5P9S/xPoyDDxvHqnT4YLJAd2AXufUF/3hCGXsbEKy7+wpzXoK/62A8RRGSjum4u U63Si5gFZcP/wrdrpi9s4olUOOrJQqZvEjB3nXKgFkKCs0qQd2xoqhzzEs75OwfZ c+se2DMpaHq27I9wBCeRtr4daM44NWZqBiSeF0OqMjUxHM9Zxm2poDyfQcKeWFrS GBfpyI9ICRAi0q/QDViO+ADP7T2y/FNmXwy3axc4iiBMcezMzxnTT3swjnVfnDu5 ACcdoqHvknJFjIBnMiyR2Lu2C0ywgHXirbu7BPui//9YyDt24dHj1/I0MJarvITQ 9Eaj6w== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyj4g2sg0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 13:52:17 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-829b7ed8964so7046287b3a.2 for ; Wed, 18 Mar 2026 06:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773841937; x=1774446737; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K09W5cRQKh+ST8g4DXzvv+55soghUxhrAcpYvLnmrXE=; b=bgjyzQWpdLaDEwSka1UD0lAFy4Hpzq0EEWtNG1W6CGhLKjyyF8sldhjJpfl+C6BIGz FI8tfoQStjKTRMApwtyJUCJTYyVstX2lCtiHgIrYmNpQHVab9Eei4tjyZ056PBWcAE6p l9sV91i60Mu2tI4iubk6qBD0I2bzoDyraR4DJ+qJmrXT3y7dVks/XyAc/xmmCJ7WhAnj t/uIAdKnSnMPS9VTqXNwmhK7l02+YSpPpKs+l9vQYN4V6rJJCNnjYYzVLfrsEaj69LZ7 98SqqVthdgzPy7477+5NrpRPENHGCPc8HgNyPK+Np2BVipvhACwHpMdTKey7oX4hVcb9 sMBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773841937; x=1774446737; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K09W5cRQKh+ST8g4DXzvv+55soghUxhrAcpYvLnmrXE=; b=F1xW/7oQXNKzvC+9kvEaFlzWHbHH2BcmdBm+PGw1PSqq/NOJIqY902qB3vH2+mRHjG 1Ww6FCDrwcSVcPnsxefe6pOoMqekrMkszIC9S0qf7lgYVDDgWonQSPPeEjpjt7/NbI9j q0o1TWfvbiGDCIA3bojPlcB+RZASnTez3ejyq17OMWPhAnB3hiO6n30OK5xyS2mzZZu/ vzNhAgKc2JI+4le9tB9GB3JTBcJzP5zWZKl8S3Iu0OURL1aICr56zdzUJ2PNztDQuTVi UQGLSkBsIMXzQqqM2SrsAhsittXGF4+voMhb+8xYzLdFF2eqdIkRyA7Mt/eTX7scj5ii FFmg== X-Forwarded-Encrypted: i=1; AJvYcCV4MD1vj8gThZUhBgMrAWwIaU7zxc5SID8JDi+RSDR9dBgk6hfz68jUB5Hc/mtlQ3AwMy8HcJkL4wA9H8w=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7Rt9DrtH7LV4pfPUH/Zx4ayvmHmC6cIVRZufYHy7nGFKp0vIj zs2sAc9CxIT/Ky52PENHNNJb1eBGShmSPSjNkI1CKrOAoaZXOJDx1rXXhg3wtN+M6idOcr4k2Xe m2Z9aMb61QzE+dmJvVNOxARwTOFWyz7lMQjRIxKPNIBGXvQ6d7NII3uo+zXpbQ4dCk3RWZtc6gh 8= X-Gm-Gg: ATEYQzxTrKY6j8T9ntSoa5BW0bJKPrqxEo5q6zCZvfhnIljmqjFjGGGET12rKF8WAzk MA1SmjLmyTEFO8FwjUeO/tTPjHMMbXKOuqXLRFkZWDo3e9f3vYiybUiJhWH5ByVqDPWbsw6a2MK 6IKwLta/b/5nTKjBaIsk7OhSyw5OozVeeMqzc81q/8p7WHp04PRchS3ftQNMav67R2BrYSxvMW9 +H2X26elKz4TfMe7e/CIaqi84b3gd+FPwVt6GPWaQTU4YRS+lacXyTeZV9NWXtGEliuRbapZ2Hv V4uGBIYqigRDDn0za3/rrAH1pBc0KHVinxBNrfjkZQTwgtWXOjnfQ8nc6G8fzPpjzn7a/WKoePt jE6cbusNssfp7HFknf4yXVdkI4sZX5aq8FsK90pGoSA9s1fSfItjLyw== X-Received: by 2002:a05:6a00:91de:b0:82a:6dc5:4e0c with SMTP id d2e1a72fcca58-82a6dc55684mr2255287b3a.27.1773841936166; Wed, 18 Mar 2026 06:52:16 -0700 (PDT) X-Received: by 2002:a05:6a00:91de:b0:82a:6dc5:4e0c with SMTP id d2e1a72fcca58-82a6dc55684mr2255260b3a.27.1773841935652; Wed, 18 Mar 2026 06:52:15 -0700 (PDT) Received: from [10.206.101.19] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6b52e671sm3458388b3a.3.2026.03.18.06.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 06:52:15 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 19:22:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 8/8] media: qcom: iris: split platform data from firmware data To: Dmitry Baryshkov , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> <20260316-iris-platform-data-v7-8-fc79f003f51c@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260316-iris-platform-data-v7-8-fc79f003f51c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TPhIilla c=1 sm=1 tr=0 ts=69baae11 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=z6a4xJ1L6jmUStEIqdYA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: WigYkK_qOEvg2-vUkfIrOljuQZ-9eZWx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDExOCBTYWx0ZWRfX5suqTbFhXfOb MKY9a6+z0MePD5KhGnW+EoAGBjwd5oMJXHkK94H7gF0H8bRrcDqHw7PrMXkVD/mW+o01eCU99qg 46vbULeWfKKVoanAsPsL0tcir4c8uYRHljukyQkF+frkF2qvLiRYY366zEgURQuK8eIhErPg5Cr kus2OPe2VwMk7rUYLyy3a0bO6sSiXCzkMQnVK1+lYnvs5zX1U2uOuJB+OK+8pxIeHwrqF6JmWIJ ZBZnLPOd88RpfYBweRwgABtbdNz/lz+e3LLPOE3qOP5YpAmqEDKHn44hamPELpfF9kUJUcbu6qY d/B80f4TQtlyKzT7mcIKwBbGlyZKYy7ogyoj8k7jonDCriBL9Y2QMz8dM5tS2DtsqxgTLAuEzVv rzBI+p40cwdp3R7uVx6JThVndl44xYMj7BFZjmzJgBSBUrSAzIo/rucfOQpV0Ki+CxFlANM6ADO oAveBmCecK/xlbXfndA== X-Proofpoint-GUID: WigYkK_qOEvg2-vUkfIrOljuQZ-9eZWx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180118 On 3/17/2026 12:24 AM, Dmitry Baryshkov wrote: > Finalize the logical separation of the software and hardware interface > descriptions by moving hardware properties to the files specific to the > particular VPU version. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/Makefile | 6 +- > .../iris/{iris_platform_gen1.c => iris_hfi_gen1.c} | 136 ------------- > .../iris/{iris_platform_gen2.c => iris_hfi_gen2.c} | 223 --------------------- > .../platform/qcom/iris/iris_platform_common.h | 3 + > .../platform/qcom/iris/iris_platform_sm8250.h | 29 +++ > .../platform/qcom/iris/iris_platform_sm8550.h | 31 +++ > .../media/platform/qcom/iris/iris_platform_vpu2.c | 126 ++++++++++++ > .../media/platform/qcom/iris/iris_platform_vpu3x.c | 214 ++++++++++++++++++++ > 8 files changed, 407 insertions(+), 361 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/Makefile b/drivers/media/platform/qcom/iris/Makefile > index 2fde45f81727..48e415cbc439 100644 > --- a/drivers/media/platform/qcom/iris/Makefile > +++ b/drivers/media/platform/qcom/iris/Makefile > @@ -4,14 +4,16 @@ qcom-iris-objs += iris_buffer.o \ > iris_ctrls.o \ > iris_firmware.o \ > iris_hfi_common.o \ > + iris_hfi_gen1.o \ > iris_hfi_gen1_command.o \ > iris_hfi_gen1_response.o \ > + iris_hfi_gen2.o \ > iris_hfi_gen2_command.o \ > iris_hfi_gen2_packet.o \ > iris_hfi_gen2_response.o \ > iris_hfi_queue.o \ > - iris_platform_gen1.o \ > - iris_platform_gen2.o \ > + iris_platform_vpu2.o \ > + iris_platform_vpu3x.o \ > iris_power.o \ > iris_probe.o \ > iris_resources.o \ > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > similarity index 67% > rename from drivers/media/platform/qcom/iris/iris_platform_gen1.c > rename to drivers/media/platform/qcom/iris/iris_hfi_gen1.c > index b2d18459a811..60f51a1ba941 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > @@ -3,38 +3,16 @@ > * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > -#include "iris_core.h" > #include "iris_ctrls.h" > #include "iris_platform_common.h" > -#include "iris_resources.h" > #include "iris_hfi_gen1.h" > #include "iris_hfi_gen1_defines.h" > #include "iris_vpu_buffer.h" > -#include "iris_vpu_common.h" > -#include "iris_instance.h" > - > -#include "iris_platform_sc7280.h" > > #define BITRATE_MIN 32000 > #define BITRATE_MAX 160000000 > -#define BITRATE_PEAK_DEFAULT (BITRATE_DEFAULT * 2) > #define BITRATE_STEP 100 > > -static struct iris_fmt platform_fmts_sm8250_dec[] = { > - [IRIS_FMT_H264] = { > - .pixfmt = V4L2_PIX_FMT_H264, > - .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > - }, > - [IRIS_FMT_HEVC] = { > - .pixfmt = V4L2_PIX_FMT_HEVC, > - .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > - }, > - [IRIS_FMT_VP9] = { > - .pixfmt = V4L2_PIX_FMT_VP9, > - .type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > - }, > -}; > - > static struct platform_inst_fw_cap inst_fw_cap_sm8250_dec[] = { > { > .cap_id = PIPE, > @@ -248,56 +226,6 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { > }, > }; > > + > +const struct iris_platform_data sc7280_data = { > + .firmware_data = &iris_hfi_gen1_data, > + .get_vpu_buffer_size = iris_vpu_buf_size, > + .vpu_ops = &iris_vpu2_ops, > + .icc_tbl = iris_icc_info_vpu2, > + .icc_tbl_size = ARRAY_SIZE(iris_icc_info_vpu2), > + .bw_tbl_dec = sc7280_bw_table_dec, > + .bw_tbl_dec_size = ARRAY_SIZE(sc7280_bw_table_dec), > + .pmdomain_tbl = iris_pmdomain_table_vpu2, > + .pmdomain_tbl_size = ARRAY_SIZE(iris_pmdomain_table_vpu2), > + .opp_pd_tbl = sc7280_opp_pd_table, > + .opp_pd_tbl_size = ARRAY_SIZE(sc7280_opp_pd_table), > + .clk_tbl = sc7280_clk_table, > + .clk_tbl_size = ARRAY_SIZE(sc7280_clk_table), > + .opp_clk_tbl = sc7280_opp_clk_table, > + /* Upper bound of DMA address range */ > + .dma_mask = 0xe0000000 - 1, > + .fwname = "qcom/vpu/vpu20_p1.mbn", > + .inst_iris_fmts = iris_fmts_vpu2_dec, > + .inst_iris_fmts_size = ARRAY_SIZE(iris_fmts_vpu2_dec), > + .inst_caps = &platform_inst_cap_vpu2, > + .tz_cp_config_data = tz_cp_config_vpu2, > + .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_vpu2), > + .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, Drop this from platform data as well, its not platform specific and do not see it changing in future too. Regards, Vikash