From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504AbdEKNVl (ORCPT ); Thu, 11 May 2017 09:21:41 -0400 Received: from mga05.intel.com ([192.55.52.43]:46608 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754327AbdEKNVj (ORCPT ); Thu, 11 May 2017 09:21:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,324,1491289200"; d="scan'208";a="259898731" Subject: Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions To: Andy Shevchenko , Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1494262399.30052.69.camel@linux.intel.com> Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: Date: Thu, 11 May 2017 16:20:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494262399.30052.69.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2017 07:53 PM, Andy Shevchenko wrote: >> + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) { > > GENMASK(15, 0) > I don't think this increase readability compared to 0x0000ffff here. -- Jarkko