mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Jason Huang <Jason.Huang2@infineon.com>, linux-wireless@vger.kernel.org
Cc: wlan-kernel-dev-list@infineon.com,
	Chung-Hsien Hsu <Chung-Hsien.Hsu@infineon.com>,
	Chi-hsien Lin <chi-hsien.lin@cypress.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: cfg80211: report authorized connect and roam events
Date: Wed, 5 Aug 2026 15:50:50 -0700	[thread overview]
Message-ID: <f2c8c83f-e2e4-4ed1-871f-f1bb1d71c057@oss.qualcomm.com> (raw)
In-Reply-To: <20260805110116.35884-2-Jason.Huang2@infineon.com>

On 8/5/2026 4:01 AM, Jason Huang wrote:
> From: Jason Huang <jason.huang2@infineon.com>
> 
> Drivers that offload the 802.1X/FT key exchange can know that
> the link is ready for data traffic when reporting a successful
> connect or roam event. Carry that state through cfg80211 and
> include NL80211_ATTR_PORT_AUTHORIZED in the corresponding nl80211
> notification when the driver provides it.
> 
> This lets userspace avoid restarting authentication state machines
> after firmware has already completed the security exchange during
> offloaded roaming.
> 
> Assisted-by: GitHub Copilot CLI:gpt-5.5
> Signed-off-by: Chung-Hsien Hsu <Chung-Hsien.Hsu@infineon.com>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>

Jason,
why are the above signing off the patch if you are the author?

> Signed-off-by: Jason Huang <jason.huang2@infineon.com>
> ---
>  include/net/cfg80211.h       | 6 ++++++
>  include/uapi/linux/nl80211.h | 4 +++-
>  net/wireless/nl80211.c       | 6 +++++-
>  net/wireless/sme.c           | 2 ++
>  4 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 97c16d4ff127..7f576bb7325c 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -9103,6 +9103,8 @@ struct cfg80211_fils_resp_params {
>   * @assoc_encrypted: The driver should set this flag to indicate that the
>   *	(Re)Association Request/Response frames are transmitted encrypted over
>   *	the air.
> + * @authorized: Indicates whether the connection is ready to transport data
> + *	packets.
>   */
>  struct cfg80211_connect_resp_params {
>  	int status;
> @@ -9113,6 +9115,7 @@ struct cfg80211_connect_resp_params {
>  	struct cfg80211_fils_resp_params fils;
>  	enum nl80211_timeout_reason timeout_reason;
>  	bool assoc_encrypted;
> +	bool authorized;
>  
>  	const u8 *ap_mld_addr;
>  	u16 valid_links;
> @@ -9281,6 +9284,8 @@ cfg80211_connect_timeout(struct net_device *dev, const u8 *bssid,
>   * @links.bss: For MLO roaming, entry of new bss to which STA link got
>   *	roamed. For non-MLO roaming, links[0].bss points to entry of bss to
>   *	which STA got roamed (may be %NULL if %links.bssid is set)
> + * @authorized: Indicates whether the new connection is ready to transport data
> + *	packets.
>   */
>  struct cfg80211_roam_info {
>  	const u8 *req_ie;
> @@ -9297,6 +9302,7 @@ struct cfg80211_roam_info {
>  		struct ieee80211_channel *channel;
>  		struct cfg80211_bss *bss;
>  	} links[IEEE80211_MLD_MAX_NUM_LINKS];
> +	bool authorized;
>  };
>  
>  /**
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 020387d76412..66b4cfd8de86 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -2705,7 +2705,9 @@ enum nl80211_commands {
>   *	in %NL80211_CMD_CONNECT to indicate that for 802.1X authentication it
>   *	wants to use the supported offload of the 4-way handshake.
>   * @NL80211_ATTR_PMKR0_NAME: PMK-R0 Name for offloaded FT.
> - * @NL80211_ATTR_PORT_AUTHORIZED: (reserved)
> + * @NL80211_ATTR_PORT_AUTHORIZED: flag attribute used in %NL80211_CMD_CONNECT
> + *	or %NL80211_CMD_ROAM notifications to indicate that 802.1X
> + *	authentication was done by the driver or is not needed.

This attribute became deprecated when NL80211_CMD_PORT_AUTHORIZED was
introduced. Why are you not using that?

503c1fb98ba3 ("cfg80211/nl80211: add a port authorized event")


  reply	other threads:[~2026-08-05 22:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  3:04 [PATCH 1/7] " Jason Huang
2026-08-04  3:04 ` [PATCH 2/7] wifi: nl80211: add roam offload extended feature Jason Huang
2026-08-04  6:43 ` [PATCH 1/7] wifi: cfg80211: report authorized connect and roam events Johannes Berg
     [not found] ` <20260805110116.35884-1-Jason.Huang2@infineon.com>
2026-08-05 11:01   ` [PATCH v2 1/2] " Jason Huang
2026-08-05 22:50     ` Jeff Johnson [this message]
2026-08-06  4:03       ` HungTsung Huang
2026-08-05 11:01   ` [PATCH v2 2/2] wifi: nl80211: add roam offload extended feature Jason Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2c8c83f-e2e4-4ed1-871f-f1bb1d71c057@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=Chung-Hsien.Hsu@infineon.com \
    --cc=Jason.Huang2@infineon.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wlan-kernel-dev-list@infineon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®