mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.de>
To: Laurence Oberman <loberman@redhat.com>,
	"Milan P. Gandhi" <mgandhi@redhat.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com
Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors
Date: Mon, 30 Sep 2019 10:42:14 +0200	[thread overview]
Message-ID: <f2c97e860f895613ba81b69c962660b0c712723a.camel@suse.de> (raw)
In-Reply-To: <3a8ee584f9846fba94d98d0e6941fefdcbed5d71.camel@redhat.com>

On Fri, 2019-09-27 at 13:45 -0400, Laurence Oberman wrote:
> 
> Hi Martin
> 
> Agreed about log extraction, but turning that on with a busy workload
> in a production environment is not practical. We cant do it with
> systems with 1000's of luns and 1000's of IOPS/sec.
> Also second resolution is good enough for the debug we want to see.

I gather that you look at a specific problem where second resolution is
sufficient. For upstream, the generic usefulness should be considered,
and I don't think we can say today that better-than-second resolution
will never be useful, so I still vote for milliseconds.

Wrt the enablement of the option on highly loaded systems, I'm not sure
I understand. You need to enable SCSI logging anyway, don't you? Is it
an issue to have to set 2 sysfs values rather than just one?

Regards,
Martin

> 
> Regards
> Laurence
> 



  reply	other threads:[~2019-09-30  8:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  6:01 Milan P. Gandhi
2019-09-23 13:02 ` Laurence Oberman
2019-09-23 13:24   ` Milan P. Gandhi
2019-09-25 15:45 ` Bart Van Assche
2019-09-26  5:01   ` Milan P. Gandhi
2019-09-27 15:26 ` Martin Wilck
2019-09-27 17:45   ` Laurence Oberman
2019-09-30  8:42     ` Martin Wilck [this message]
2019-09-30  9:05       ` Milan P. Gandhi
2019-09-30  9:46         ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2c97e860f895613ba81b69c962660b0c712723a.camel@suse.de \
    --to=mwilck@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=martin.petersen@oracle.com \
    --cc=mgandhi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®