From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295F1C77B70 for ; Fri, 14 Apr 2023 06:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjDNG3C (ORCPT ); Fri, 14 Apr 2023 02:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbjDNG3A (ORCPT ); Fri, 14 Apr 2023 02:29:00 -0400 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291341FE7 for ; Thu, 13 Apr 2023 23:28:32 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R461e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vg2TGjn_1681453692; Received: from 30.97.49.1(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vg2TGjn_1681453692) by smtp.aliyun-inc.com; Fri, 14 Apr 2023 14:28:13 +0800 Message-ID: Date: Fri, 14 Apr 2023 14:28:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] erofs: fix potential overflow calculating xattr_isize To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230414061810.6479-1-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230414061810.6479-1-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/14 14:18, Jingbo Xu wrote: > Given on-disk i_xattr_icount is 16 bits and xattr_isize is calculated > from i_xattr_icount multiplying 4, xattr_isize has a theoretical maximum > of 256K (64K * 4). > > Thus declare xattr_isize as unsigned int to avoid the potential overflow. > > Fixes: bfb8674dc044 ("staging: erofs: add erofs in-memory stuffs") > Signed-off-by: Jingbo Xu Thanks for catching this! Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > fs/erofs/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index 8a563374b518..c86241a32ab3 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -306,7 +306,7 @@ struct erofs_inode { > > unsigned char datalayout; > unsigned char inode_isize; > - unsigned short xattr_isize; > + unsigned int xattr_isize; > > unsigned int xattr_shared_count; > unsigned int *xattr_shared_xattrs;