From: Pavel Skripkin <paskripkin@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
straube.linux@gmail.com, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 0/4] staging: r8188eu: add error handling of usb read errors
Date: Tue, 7 Jun 2022 22:04:56 +0300 [thread overview]
Message-ID: <f2cdd4ae-f273-0510-9a58-1ed56f456893@gmail.com> (raw)
In-Reply-To: <Yp8xezHITGrxv47H@kroah.com>
[-- Attachment #1.1: Type: text/plain, Size: 728 bytes --]
Hi Greg,
On 6/7/22 14:07, Greg KH wrote:
> After applying, I get the following build warning which breaks the
> build:
>
> drivers/staging/r8188eu/core/rtw_mlme_ext.c:6826:13: error: unused variable ‘res’ [-Werror=unused-variable]
> 6826 | int res;
> | ^~~
>
> Please test-build your patches before sending them out :(
>
Was curious about why my compiler didn't yell at me about that issue,
since I've done not only build test, but also tested on real hw...
Build failure occurs while applying 1/4, but 3/4 fixes it, that's why I
missed that build error
Anyway, it's only my bad. Sorry about that, will fix up in next version.
With regards,
Pavel Skripkin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2022-06-08 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 19:36 Pavel Skripkin
2022-06-06 19:36 ` [PATCH v3 1/4] staging: r8188eu: add error handling of rtw_read8 Pavel Skripkin
2022-06-06 19:37 ` [PATCH v3 2/4] staging: r8188eu: add error handling of rtw_read16 Pavel Skripkin
2022-06-06 19:37 ` [PATCH v3 3/4] staging: r8188eu: add error handling of rtw_read32 Pavel Skripkin
2022-06-06 19:37 ` [PATCH v3 4/4] MAINTAINERS: add myself as r8188eu reviewer Pavel Skripkin
2022-06-07 11:07 ` [PATCH v3 0/4] staging: r8188eu: add error handling of usb read errors Greg KH
2022-06-07 19:04 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2cdd4ae-f273-0510-9a58-1ed56f456893@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®