From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF88C00140 for ; Thu, 18 Aug 2022 23:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346105AbiHRXla convert rfc822-to-8bit (ORCPT ); Thu, 18 Aug 2022 19:41:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245581AbiHRXl2 (ORCPT ); Thu, 18 Aug 2022 19:41:28 -0400 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A5DDDB6C for ; Thu, 18 Aug 2022 16:41:27 -0700 (PDT) Received: from omf05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E422CA09C9; Thu, 18 Aug 2022 23:40:47 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA id 8645E20018; Thu, 18 Aug 2022 23:40:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH] alpha: move from strlcpy with unused retval to strscpy From: Joe Perches To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Julia Lawall Date: Thu, 18 Aug 2022 19:40:36 -0400 In-Reply-To: <20220818205936.6144-1-wsa+renesas@sang-engineering.com> References: <20220818205936.6144-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Stat-Signature: 63sffsbykz97x3rcana67aogb9xkpjgp X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 8645E20018 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18Jb/X1VWGWoojIlIDf3j/NlOmdOXB8FaU= X-HE-Tag: 1660866046-515543 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-08-18 at 22:59 +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. Nice. Last time I posted a coccinelle script for strlcpy->strscpy conversions with unused returns, there were several variants that were not converted. https://lore.kernel.org/cocci/a3279a5772b2e49b57890cd75e97360b82890798.camel@perches.com/T/#m502108bfe0cc6a41d499a4c1b55d5f5db1423465 Did you post the script you used?