From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4262F29BD85 for ; Wed, 26 Nov 2025 11:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764156080; cv=none; b=W+dVCyaIt9ENY6ds+SI8FWaeR3v87vj0gIF+Kmv3A8fkA5tYoPM/tYH3557QyZW0CuFGO9QF5Q0qjqeCvGLVW6S67ADc69p5wkLTJ4soK/tB8aVqnGhipRJzg7Lk/EHkjXL9UegS8yVrFvfRqER6BcxdMIJcQres8DU5sN7IpkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764156080; c=relaxed/simple; bh=0JlzdUPuaETWe40kZS4SHRYp1Ap/QTfPnftohIGg5vQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eWtf9JrErYMAVgVyo/Wwt8JptzMU8aCQRHnHtWtIgyYgyV3uWzggQk3tWGTOqtyEic8NZFyKawJjH+Q5n+k96w5/w1h1xs91Mczg5QgV3wrMFlQWUfZfYSLUyClkmMqLSsgV8bd00siOod4tJUcqWcJL98iUPZUlw0gU4FHaBqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30D39168F; Wed, 26 Nov 2025 03:21:11 -0800 (PST) Received: from [10.1.30.35] (e122027.cambridge.arm.com [10.1.30.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 54C003F66E; Wed, 26 Nov 2025 03:21:17 -0800 (PST) Message-ID: Date: Wed, 26 Nov 2025 11:21:15 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/gem: Correct error condition in drm_gem_objects_lookup To: David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Almeida?= , Tvrtko Ursulin References: <20251124112039.117748-1-steven.price@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251124112039.117748-1-steven.price@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/11/2025 11:20, Steven Price wrote: > When vmemdup_array_user() fails, 'handles' is set to a negative error > code and no memory is allocated. So the call to kvfree() should not > happen. Instead just return early with the error code. > > Fixes: cb77b79abf5f ("drm/gem: Use vmemdup_array_user in drm_gem_objects_lookup") > Signed-off-by: Steven Price Applied to drm-misc-next. > --- > drivers/gpu/drm/drm_gem.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 68168d58a7c8..efc79bbf3c73 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -798,13 +798,10 @@ int drm_gem_objects_lookup(struct drm_file *filp, void __user *bo_handles, > *objs_out = objs; > > handles = vmemdup_array_user(bo_handles, count, sizeof(u32)); > - if (IS_ERR(handles)) { > - ret = PTR_ERR(handles); > - goto out; > - } > + if (IS_ERR(handles)) > + return PTR_ERR(handles); > > ret = objects_lookup(filp, handles, count, objs); > -out: > kvfree(handles); > return ret; >