From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C4B1C3F02 for ; Mon, 13 Jan 2025 19:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796236; cv=none; b=ttSUZTPlQATValAManvHqulzb34lwXZ3QiuXUkut1mQk/z15ERyoLRIOqe7MLMkBzVdh0soLrdXYivReFwV19VqLK2tV+aKmU98f55psM+L89uIzFqHc3FKKKxsv2uFJbCI6A0Yu/rrDcizpw2HyQv4sx9cVWanuEsS4dH94DxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796236; c=relaxed/simple; bh=LF+AuV0ARDzMcyEv7Xj+u8fef6mjE2wu+k77sVj4s/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XyB9OvfYLm2RpftTdYUeZai94SsKi2iDnI7PYZRgXAWYb43uCtJ0pmRVDD8T3D3TDPReivmfjh/hhAwCEOuWN0v8Hpyiq0YzmF9WJ7R9X3kxmUujR2GZ4dMSGVFaeQF73OsPjk/1lvFFpefxMfKCZBxllZfGF3766h1bRx63De8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UHPowSBj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UHPowSBj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DErVUG021534 for ; Mon, 13 Jan 2025 19:23:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NXde1w5kelBQI0tygiDvTjNW7ZPGIES67vcDwSi0qjw=; b=UHPowSBj12iXa2H+ 3BwNbs9AHbPsFn8vmwYwSAw1ej4vilBphI5zLX6ywTFhyjNj9HRkVPTFxU+0wVe+ +MFNExZNcMSvzKQA5eX9GgiUlI/VhlDXNuAtMsqTib4rMEs0GQ07zg/SY8xPaxoQ aoTuvGxCQAvOXjXAvtCxMddSOxOHzPawPJMxOLcu1PE3HxVOaGSxYq2rWgXO3O/x vVDuXAP78fmuCXB9wSk/2b2ZioXsfg2fwitTfgVsSfUoLiWhh87u9Y3gTM1TTZBt XYRJARosQavNACC/KkSqUIpGLao/Ij49yEniEaZvJ9yGyibwlhF7mYxnZQ+sNHc1 iM/3Sg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44550agnw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Jan 2025 19:23:53 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2166464e236so136558325ad.1 for ; Mon, 13 Jan 2025 11:23:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736796232; x=1737401032; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NXde1w5kelBQI0tygiDvTjNW7ZPGIES67vcDwSi0qjw=; b=MjHsiVz2d3q1QtmmVcf55SzhPSUagBWNXuci1+ERv2NN5VtQoMXggbWB7KWsLswsJg qdSVdf0z7pQYQSm7JWVuhB3zgMFZ9lPvaJ+ukj6uwJKXSl6uzCwN7IVhiGxxr99VAONZ 6YP8TvAPon3Yu6GxJ4OOj9RccwGs5hV+REUQhStS9Jn21PlK1xUD9q05FP71UhlOaJbH LkVs2v3NcbU1+gbLkydeJqourkh9HHjvOI3oSAaTCIw8EOe1lBt+el9czXJdW6hiPn88 biavwOAMOaIenFqcPUblKLarFhYpDe7iEaI3CEspOtMOu36FyPKJ480aG+whq3VKrlc1 CmVA== X-Forwarded-Encrypted: i=1; AJvYcCUNhtCUvrSrnkTTQW2wXywneTtT6H1zxxG/wytApi9vtYcbFej31qriY6IVdhkSqKP76AOkShwHyz84QT4=@vger.kernel.org X-Gm-Message-State: AOJu0YzDO4Vp1pxXSHq6nuSPjdkf4QYpV/f68F1qYo/LodG54zSBnz5E mLgureC4iZyf+FJ5N0LKc7JQNwyX6h4Kr2x+CJsT5/DJF7qmaUt0js+zSfGhPw6sPQ+4dg9W0jK PLSjEJJuKoTVg8wgt0ia3V1DS3F3f/RnV9W9BCktATT98iBX1EajxIpdVu+WVlo0ur2JrMkU= X-Gm-Gg: ASbGnctGslQt6F8xyTgbpZ1mZZNRznegccvy9tlMILr+U+V1v1GzDtriQIbCiSQv99J OrOuZKd4vRcwnTWTa9E4r0Lt4uh2jTzH1gpg87Elft8BP960GJB6wt2MihX19cyWDXhmGAQLtJl A00Ju2UGwHO7n8FvtCOSCyBCcrG5VAVACJ1vKaQzhU3o+w+CJAfsa3F69N6jU741+AefvzZDxZZ Q+lvOb9UsZfF93Pzd840yW81+uGSJmjomiBbTua51Yda8UObt7CMs2nswVE/2H3QX+0Q0dGD6qm qfNxZXPoFSoGMSaUtrkcG0kgj/fQ0idEcHapnrvuibA9rtMVQA== X-Received: by 2002:a17:903:2301:b0:211:3275:3fe with SMTP id d9443c01a7336-21a83f5243cmr121124905ad.17.1736796232145; Mon, 13 Jan 2025 11:23:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXldcpH+05wO8UMutlychiEfsS4TSMNdLeLT/myX2snP2ooR13NCLU5K/VFffyts1ZTb8e5g== X-Received: by 2002:a17:903:2301:b0:211:3275:3fe with SMTP id d9443c01a7336-21a83f5243cmr121124475ad.17.1736796231715; Mon, 13 Jan 2025 11:23:51 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f12f925sm57436325ad.61.2025.01.13.11.23.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 11:23:51 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 11:23:50 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] wifi: ath12k: handle ath12k_core_restart() with hardware grouping To: Aditya Kumar Singh , Kalle Valo , Jeff Johnson , Karthikeyan Periyasamy , Harshitha Prem Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com> <20250109-fix_reboot_issues_with_hw_grouping-v1-8-fb39ec03451e@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-8-fb39ec03451e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: aBOkuzZNvGqa1rXGB0-MCFzEB_Q6seFp X-Proofpoint-GUID: aBOkuzZNvGqa1rXGB0-MCFzEB_Q6seFp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130155 On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote: > Currently, when ath12k_core_restart() is called and the ab->is_reset flag > is set, it invokes ieee80211_restart_hw() for all hardware in the same > group. However, other hardware might still be in the recovery process, > making this call inappropriate with grouping into picture. > > To address this, add a condition to check if the group is ready. If the > group is not ready, do not call ieee80211_restart_hw(). > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aditya Kumar Singh Acked-by: Jeff Johnson