From: Konrad Dybcio <konradybcio@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_riteshk@quicinc.com,
quic_vproddut@quicinc.com, quic_abhinavk@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: add DisplayPort device node
Date: Tue, 17 Sep 2024 01:35:39 +0200 [thread overview]
Message-ID: <f2d3d18f-f671-4616-a722-2e41c8e50939@kernel.org> (raw)
In-Reply-To: <ivbohyezb57mcqgfnjot3j2olgj4kvyoq2fjstgugscagsmlg7@vav3cbokzg7q>
On 16.09.2024 4:01 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 16, 2024 at 02:43:44PM GMT, Soutrik Mukhopadhyay wrote:
>> Add device tree node for the DisplayPort controller
>> and eDP PHY found on the Qualcomm SA8775P SoC.
>
> Not quite. You are also enabling it for the RIDE platforms, not just the
> SA8775p SoC.
(the patches should be split into soc and board parts)
[...]
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + dpu_intf0_out: endpoint {
Please add a newline between the last property and the subnode
Konrad
next prev parent reply other threads:[~2024-09-16 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 9:13 Soutrik Mukhopadhyay
2024-09-16 14:01 ` Dmitry Baryshkov
2024-09-16 23:35 ` Konrad Dybcio [this message]
2024-10-07 10:48 ` Soutrik Mukhopadhyay
2024-10-07 10:46 ` Soutrik Mukhopadhyay
2024-09-17 7:29 ` Bjorn Andersson
2024-10-07 11:10 ` Soutrik Mukhopadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2d3d18f-f671-4616-a722-2e41c8e50939@kernel.org \
--to=konradybcio@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mukhopad@quicinc.com \
--cc=quic_riteshk@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®