From: Sibi Sankar <quic_sibis@quicinc.com>
To: Shivnandan Kumar <quic_kshivnan@quicinc.com>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<djakov@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<srinivas.kandagatla@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<quic_rgottimu@quicinc.com>, <conor+dt@kernel.org>,
<dmitry.baryshkov@linaro.org>, <abel.vesa@linaro.org>
Subject: Re: [PATCH 3/4] arm64: dts: qcom: x1e80100: Add BWMONs
Date: Thu, 13 Jun 2024 22:21:58 +0530 [thread overview]
Message-ID: <f2d81804-f4a3-d813-cbb0-5c4ada6a3fda@quicinc.com> (raw)
In-Reply-To: <b9ee77da-bd51-4d32-8f35-d38fe8b77f44@quicinc.com>
On 6/6/24 14:39, Shivnandan Kumar wrote:
>
>
> On 6/4/2024 6:41 AM, Sibi Sankar wrote:
>> Add the CPU and LLCC BWMONs on X1E80100 SoCs.
>>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Hey Shiv,
Thanks for taking time to review the series :)
>> ---
>> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 169 +++++++++++++++++++++++++
>> 1 file changed, 169 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> index 1929c34ae70a..d86c4d3be126 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> @@ -5329,6 +5329,175 @@ cpu_scp_lpri1: scp-sram-section@200 {
>> };
>> };
>> + pmu@24091000 {
>> + compatible = "qcom,x1e80100-llcc-bwmon",
>> "qcom,sc7280-llcc-bwmon";
>> + reg = <0 0x24091000 0 0x1000>;
>> +
>> + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> + interconnects = <&mc_virt MASTER_LLCC 3 &mc_virt
>> SLAVE_EBI1 3>;
>> +
>> + operating-points-v2 = <&llcc_bwmon_opp_table>;
>> +
>> + llcc_bwmon_opp_table: opp-table {
>> + compatible = "operating-points-v2";
>> +
>> + opp-0 {
>
> Nitpick,In one table, we start from ‘opp-0,’ while in the other table,
> it begins with ‘opp-1,it is better to make it consistent across table.
>
Will fix it in the next re-spin.
-Sibi
>> + opp-peak-kBps = <800000>;
>> reg = <0 0x25000000 0 0x200000>,
...
[snip]
...
>
>
> Thanks,
> Shivnandan
next prev parent reply other threads:[~2024-06-13 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 1:11 [PATCH 0/4] arm64: dts: qcom: x1e80100: Enable bwmon and fastrpc support Sibi Sankar
2024-06-04 1:11 ` [PATCH 1/4] dt-bindings: interconnect: qcom,msm8998-bwmon: Add X1E80100 BWMON instances Sibi Sankar
2024-06-04 6:46 ` Krzysztof Kozlowski
2024-06-04 1:11 ` [PATCH 2/4] soc: qcom: icc-bwmon: Allow for interrupts to be shared across instances Sibi Sankar
2024-06-04 6:46 ` Krzysztof Kozlowski
2024-06-13 17:02 ` Sibi Sankar
2024-06-14 8:24 ` Krzysztof Kozlowski
2024-06-14 20:19 ` Sibi Sankar
2024-06-14 21:42 ` Dmitry Baryshkov
2024-06-15 2:15 ` Sibi Sankar
2024-06-04 1:11 ` [PATCH 3/4] arm64: dts: qcom: x1e80100: Add BWMONs Sibi Sankar
2024-06-06 9:09 ` Shivnandan Kumar
2024-06-13 16:51 ` Sibi Sankar [this message]
2024-06-06 9:56 ` Konrad Dybcio
2024-06-13 17:18 ` Sibi Sankar
2024-06-04 1:11 ` [PATCH 4/4] arm64: dts: qcom: x1e80100: Add fastrpc nodes Sibi Sankar
2024-06-06 2:45 ` Bjorn Andersson
2024-06-13 16:50 ` Sibi Sankar
2024-06-06 10:30 ` [PATCH 0/4] arm64: dts: qcom: x1e80100: Enable bwmon and fastrpc support Konrad Dybcio
2024-06-13 17:27 ` Sibi Sankar
2024-06-18 14:39 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2d81804-f4a3-d813-cbb0-5c4ada6a3fda@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_kshivnan@quicinc.com \
--cc=quic_rgottimu@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®