From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E40A2FABEE for ; Sat, 6 Dec 2025 14:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765031468; cv=none; b=GGg82yatXqyxDWI+SM97gEFPIwGrhTWY/uAssk/C0w9H75FzbKoyQqDDqSs2L4JIdY/a933BEsKkJsKbD/9mkvaanbbrni+JW2WysMFtSrFM/7VashiTI11w/0SntszZ7cdNvVLU3KJ1OwMMxvhB8GwAo3aduFNYrHGC3EoK2Wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765031468; c=relaxed/simple; bh=Na6D7E4kSS7DZJ4XuQYO7vDIvKg3c+obHsbqi5zx/hM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GVQO6Aoyvfl7O7S5tkhoCO2q7G6eRZsnw4iLbZ2Hjn/Ey7shlSg444Sr9DMpcNaBQ7B+cKpMPaYn9951RlaUSgj/U7U/6YyM959OyaNR0Oc6brRIbRmcPyzoGEC4VXy01sa3kRBkIB3hFCmI1II6ovruNS3zz8RYr/KQQSoy1iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=dRNNNSQQ; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="dRNNNSQQ" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b73a9592fb8so725343266b.1 for ; Sat, 06 Dec 2025 06:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1765031465; x=1765636265; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sRIfQPoEDFmFqm2DpO4522h9Id16dk4sZVB/evXjzE0=; b=dRNNNSQQ0clSVGl1ScpX45IvJaO+QPBP73LOL+HnM5SF3KWXYM4/a1j4cS6tZlcJO5 dtpUjHq7lJTFVOd946oLwPNAFuznlNWUBxA9XNbdTcqQNq92UjZpKq3BN2rdIHqgw6Uj DuRJQ9E02PWGZ0MbwMEQtsEEPZyL0swixezfES3tpMOgV4tGpPYdpexjc8h33ZDmwI9Y 0udXj+inE4/3J9x06885VnMWSrHXkipie+L/AWedqgA5EEI3huNaS0XKLULVi6tvroCW vCBtbPOGGjlA5Binp5ZK0o2N7dUqkxaqX4kuyS8cPVZxxcXd6zgKZkciPUtBsW3TlNzo M3rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765031465; x=1765636265; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sRIfQPoEDFmFqm2DpO4522h9Id16dk4sZVB/evXjzE0=; b=ei7CSlseTVpRxb0MIW5HNZWk+Pj3xlJv5MQ4YtvhYXbN6R8SU3RWjymt4a02kfTBig pqhhKApcvEyneSMIaGJf0rwJZ62dpZzPjwDcrizvTq6mFjJwJGg4zrMH13ppO3EndnGi x7sSsugj+lwVtVn3p9tDdQ2Yjup1juxebXfwgn9Eyafc+HkXNqDrujOkDYdic+PFWdOW t6I4qwPSiDcNOOcphxNtPKHxuJaR/0Zrw55lxUi1N26DK1vu6qJylOdlxL8YF8VlFVn6 Nd3xfEhsTp3DTRZXB9Cpqr24Pn33hpvkdaKpvfYCm56XDS1Og4/n7anmZmGY+ipwooen eqog== X-Forwarded-Encrypted: i=1; AJvYcCXAW+o5nuYjX+dQprW7OPbxyY+Qd/1W864AE8OrHQSouf0SDRW2gBq8GTyW7L1ik6eJH/wBjnFhepBbnKg=@vger.kernel.org X-Gm-Message-State: AOJu0YxcWteuTN6Q5LNbw62zpR1Cv72M/nS/iz3K/ITVQBolDyflPhRu esLB57HN5Hk3JvOxkGogDTgPL37b5z7INCkfIIia2CP1EZfDPBIyKqrKUsmLuX0hDBQ= X-Gm-Gg: ASbGnctcj/5K2mttcW1QkyPr3ukbuJWQ0eeACc4gtACHXQm7vaPbfc3peyaomL3DW4C gFtOLZQe8hGDpRbSU6M9y9Pvu6sQDqke3gWgQgsX3fkcDmKsy/XejxcRqyHVf4IZ2ah54Eh3tuY Lwqw3a8/3Fve6Y61rIvzzgLX2d4ZlNWu5xMRehRBVtSFnHOxrwTXs3u+MPZJ0w2Lh5RzgD8Omx/ xTI4a9n6iEneJuXFYsbY1rcoVLZrVeZaAKFDM+YGgkcuRttqnPmiqdl3XSUUGpGC7JvRwrsUEUF D9sX+hH6xhWSQrOxXanOpq2e7gOZO/sq+qAgNOw9KGyVRi9qfqBan8opuAnqXCU0b4EaPV3wUPS 0wW3Hbvktc0Dh214+j+lHLMteKTJ4yThZVkhmL8eHJCs4sVD3ezrk08SB1ieZAnUfGw+mWMkvkF oOZR4ofhQhmosudke4TM8= X-Google-Smtp-Source: AGHT+IE8HnS86RZ2RRuX68coTBZlUOIBKtLFGaYMG3o3vx+kzbYCbEFgmp+n33XmwZVSgRz3VL6TJw== X-Received: by 2002:a17:907:9723:b0:afa:1d2c:bbd1 with SMTP id a640c23a62f3a-b7a23b808camr290395666b.30.1765031464792; Sat, 06 Dec 2025 06:31:04 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4975c56sm620545866b.33.2025.12.06.06.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Dec 2025 06:31:04 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2025 16:31:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent() To: Brian Masney , Michael Turquette , Stephen Boyd , Maxime Ripard , Conor Dooley , Dan Carpenter Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot References: <20251205-clk-microchip-fixes-v3-0-a02190705e47@redhat.com> <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/5/25 21:46, Brian Masney wrote: > roclk_get_parent() and sclk_get_parent() has the possibility of > returning -EINVAL, however the framework expects this call to always > succeed since the return value is unsigned. > > If there is no parent map defined, then the current value programmed in > the hardware is used. Let's use that same value in the case where > -EINVAL is currently returned. > > This index is only used by clk_core_get_parent_by_index(), and it > validates that it doesn't overflow the number of available parents. > > Reported-by: kernel test robot I'm getting this from checkpatch: Applying: clk: microchip: core: correct return value on *_get_parent() [Checking commit] 910546c58dc2 clk: microchip: core: correct return value on *_get_parent() [Checkpatch] WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #17: Reported-by: kernel test robot Reported-by: Dan Carpenter > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/ > Signed-off-by: Brian Masney Other than the above: Reviewed-by: Claudiu Beznea