From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A6BB38F65B for ; Mon, 8 Jun 2026 07:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905455; cv=none; b=SjuAwN8djru2Dd15/DOHTk9Dj/KSbMJStDYq0Bv/zgl0yKZYR+wjipgUR1D3LyOCDaRoHQWehfvkJHvKSsWy6n/Y6eIzsdoPUhrvv9bCPpu32xpEl3Mt2gyC39C+GFcbhSXBkRIJxdBnYiKXfG9ghDmZB0QonbAK8ibS+sMEd5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905455; c=relaxed/simple; bh=7xl5ZJ1KevTPBNN+h45CaAdKyk7R/YqHDdBsPsCvuZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uFH2X8VnQ5FsYV0MKTTLCyX/5v46/zQx6F686GeSkCIsLIOAjn+oM+MjHm1DtuePTRNehWq10mRyIiolfhylTuHili5orbjqTxRiNgUK08EiBIbylZTpG/ZtZOPwZI9iIWSzpFfZ9sxWkL8B3FuF10oX/icRweCsh5QWvGXlSj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B64M+k14; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P788Fx5v; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B64M+k14"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P788Fx5v" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586QppR2771081 for ; Mon, 8 Jun 2026 07:57:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= inrSZaqSNNfPmqqbbkk6A/tclz5TUzd+4OzD5QMl0o4=; b=B64M+k14a8dzXt9t pFcpXMZRmFGsxn+n9iPEZxzHjZKiTj251qd6xREojiAphU8r+OOYwMgFAT1SfXY1 o/PXmow4P024ZA6UP+DRzFkOHwFmPcAHxFtgMoWnSAvlFnvKmQw+EEes4XpByJJk FSDAHXcL9dpqZZIvyKBpK6r64IOoju+P9xgSt/J4XtpeWwnuy1NjpZtXg3QHuDqZ ntGJrBrpGI+E1mippHkJzLBc6yYmyB92DoTRJ7NFLvYyWaEHWR4cJQj6GLUjfYkQ 5kAs5eShUrDzXr+FRqgCsJiqw4nlyR1Q0s5ML1S2VX6WfIDxj9gmo+/5LXHtsmKY 7AaUgw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embx6ejmb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 07:57:33 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5176891d0a9so10666981cf.0 for ; Mon, 08 Jun 2026 00:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780905453; x=1781510253; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=inrSZaqSNNfPmqqbbkk6A/tclz5TUzd+4OzD5QMl0o4=; b=P788Fx5vRh3PUSslK9AHj9xgwWNHMrCParqpg5klVHMOOjdx0VZ6FgVJZsiCQltvUw QWNGhPFab2btNwZEZ5w6jqPXZIY7y7JbIX2vqbJJpumbVxbJqnXM8zUqBMh+HPZG9lHm RMwo6Sv3nnoVkR5tknm11eoM5gItN6PvDHjcksajMMiZeYVQPP3ENJj6h1vbhpwbRX/Q vtnO4nkFEg2tqak2b5aKekKgL1ZSS9khtikK6w8D92t0YSxFdV2v2L7x/3VZeLuluhUN oqmuWTL/DWP+lhGIOS4hKwV27LAQEhhoLs8gIR7bV4JTd8RNpF5coOU0RsGT8fBKTC8O KxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780905453; x=1781510253; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=inrSZaqSNNfPmqqbbkk6A/tclz5TUzd+4OzD5QMl0o4=; b=M+Onbp9CtIRvYx/dGyPKbG/e+HRlcaCJ+imXEr0vnpBstsxvGDPVP2Bm918uk2n+3r PJQcUSFiqdOOAnJ15GE8tuWDG+BxrDXMrCfWhA19zbXUqNQ4mY/qGjBMIVpTUcEkIDCP ADN9l3yYLx0pexw6oL17D9JnOadpJk1bGoQjVF8KF2YFgprUyDPMvo3xVfHGLYi1sZ72 ljMTEY8LW6kIguqibDJxbDh8FSkJK/ktFjIk6yS84f7NrAJ0LBsbupur3s1nfJh42qwQ b7ohBkVGGS/dyqwIEme7iHZ1gobjN0c2auQMUiod/+Wal5RJHqEFzFpxQoV6ez2vH1e7 2yEw== X-Gm-Message-State: AOJu0Yww0nxdsAEjKawP95qv9ikNyOdSZi7xmzUx5Yh3FaIP8v5LYYXh lDNm+0N88oOa5gkOQESdYPDGZXyOMtdNstFj9txPiANyIdvAZY2IYiCU3I2dP1JEvAaNnlY6egH 8WF7oXoiWr/PsvgpS8arH22M3jnDaTjKFSriIDVF1akVvVkwsZdoXu7paqlN8jXFQl7c= X-Gm-Gg: Acq92OGMahuCZ+5sxXXBMra6Et+RBgINSfSRlZVzm2W8Iu5sJnl4hF2QJCdchqI1WIe z4ZYDLlaDil47CitnQU2RuK4/xZFyeG9WPGyIoOeIFUdhBp68PHwpAr/xaKzGXcvHv1GN0V+VMT 9QEkBcf6kaiNHC86jVABthJZeOUgGgY0YFDJKnxPUK+Kk2enuBs1a1/lFvNbeGvyqdcGtBg+OVC 5HsQug0oU6X8HatonHUfHxRR8o2JS1FxTEFcYYVC5DuQuwR05RhHN03k4++EQJALcrLg4UyaY/N QZq2qMZ3isOl124KwLjoPxhRgyeJBiq27q13kP+xPtQ1hOIKIxSLhdPcMZs3Gr3horDV9pD+tYV vs+qD0gUcRhMPJTkS2bzFlt6Sq6a3PsYNd9SvVhoyF1vDWk7wPZg70kWc X-Received: by 2002:a05:620a:7113:b0:915:769d:56e with SMTP id af79cd13be357-915a9c1326dmr1339167285a.1.1780905452811; Mon, 08 Jun 2026 00:57:32 -0700 (PDT) X-Received: by 2002:a05:620a:7113:b0:915:769d:56e with SMTP id af79cd13be357-915a9c1326dmr1339164485a.1.1780905452100; Mon, 08 Jun 2026 00:57:32 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0517721c2sm798793366b.3.2026.06.08.00.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 00:57:31 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 09:57:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] crypto: qcom-rng - Allow zero as a random number To: Eric Biggers , linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Om Prakash Singh , Bjorn Andersson , Neil Armstrong , linux-arm-msm@vger.kernel.org, Olivia Mackall , stable@vger.kernel.org References: <20260530020332.143058-1-ebiggers@kernel.org> <20260530020332.143058-3-ebiggers@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260530020332.143058-3-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cvmrVV4i c=1 sm=1 tr=0 ts=6a2675ed cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hpjdtu9zJg2xOlDm1gEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA3MiBTYWx0ZWRfX8+ri11I/GuhJ F5xMaEoeM59sp29EXL5xlHDR8zkLbrVzUoLMR952DzsxKBSBxn5cY1JY8nReWGFOPovzVh4e2vz hKBD2Rs53GJCeWQ0RURzyylLBS4SR3Ng4BhVX1ZbOuq/DBKI59/lAUQRbZUom4IcFdMmcy1eSvH 1ECQJ6g/HrBUdBFziB0epVexSWAd4Ig2YY8GoyANb8YGgnEUauvwPsKCaMXIp3kpjZWc1cgqBEJ mVVG4/GSS5tNtoyh4kDVDREHLXqXIu51nKeawtWahHND3xIeuKgw2VAnMk2DRenVUuXntPVK3WD LmKPu14AVG/oRFkd2p7QNZRtQk9N+Trf6+5dVL2sU9KqCwoLDWqttPIPxWTSoajDOC3me4QBAKp hCuJ1F+HXyOzCjs2x+YR6aNKLXISvOujjO7bFU3e0N7D+5399R0SQZjtoeC+Db2F5kuQJeOfMDU 7sixmCSBVi/KqpSLfLg== X-Proofpoint-GUID: SCPPmRniw3wFgNPduynacjI15ZMGDaJy X-Proofpoint-ORIG-GUID: SCPPmRniw3wFgNPduynacjI15ZMGDaJy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080072 On 5/30/26 4:03 AM, Eric Biggers wrote: > Zero is a valid random number and needs to be allowed. Otherwise the > output is distinguishable from random. > > Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support") > Cc: stable@vger.kernel.org > Signed-off-by: Eric Biggers > --- > drivers/crypto/qcom-rng.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c > index f31a7fe07ba7..b7f3b9695dac 100644 > --- a/drivers/crypto/qcom-rng.c > +++ b/drivers/crypto/qcom-rng.c > @@ -63,13 +63,10 @@ static int qcom_rng_read(struct qcom_rng *rng, u8 *data, unsigned int max) > 200, 10000); > if (ret) > return ret; > > val = readl_relaxed(rng->base + PRNG_DATA_OUT); > - if (!val) > - return -EINVAL; > - nit: in case you respin, please keep the \n between the read and the following checks Reviewed-by: Konrad Dybcio Konrad > if ((max - currsize) >= WORD_SZ) { > memcpy(data, &val, WORD_SZ); > data += WORD_SZ; > currsize += WORD_SZ; > } else {