From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665E6C4361B for ; Wed, 9 Dec 2020 18:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25B0223C92 for ; Wed, 9 Dec 2020 18:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732951AbgLISZX (ORCPT ); Wed, 9 Dec 2020 13:25:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbgLISZH (ORCPT ); Wed, 9 Dec 2020 13:25:07 -0500 Received: from mail-wm1-x34a.google.com (mail-wm1-x34a.google.com [IPv6:2a00:1450:4864:20::34a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47DCDC0613D6 for ; Wed, 9 Dec 2020 10:24:27 -0800 (PST) Received: by mail-wm1-x34a.google.com with SMTP id g198so652208wme.7 for ; Wed, 09 Dec 2020 10:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=V2rDh/PTRpe6NWZnEeAWnr3LbupuxXOheZwv6czKP7I=; b=sJrzjf+rsOdspdQKnYG9pg0y0KJCU2rf0QxkpTRnNcP3e6Aub3MH1asP3rLsM6Yq64 6sisT6KMQfH8oNrgEGWsXTZd3a3ZzfQwWKmo2YeftvCEs8fMbw2aspmzE5p531i4LWib 1VibozdtcpLde7sbMU6UwWyMSZ89dNKXMFuU8igBRvKCyjCCajbL1nH1Xjfeuq0wS6bN JOZE9p0wa5eM3Zr0LFT/S393AuaG2VtA5OsN7wa9eLZD46TKUlW2qLXWAuuXjEA/yxPZ Tlswk9BfFM5KF/UwXKuc/0LtX+iT/vGi4np7MS7nlxVqpQPKBSpyre6qGHsDxa5L2Nyg gaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=V2rDh/PTRpe6NWZnEeAWnr3LbupuxXOheZwv6czKP7I=; b=Ug/5PUnp6B5aJqDNCyyiwtLuMw3LohFUCilSKSZD+tYvStU3d8OP0Mq/CFaaK8MzSj RJwKKHunOayyY4zyTekqwFhiAMYR7cwO999SRxx/D4Gped7mx4yVzLcGTtgw+07EJ+eG +DPX4lhX18y4x0GjlHOZqiMCqoT6GB/NlyfGnNmNeuVsv8JS+pqb/lWMD1t56Ympzpca gVySnp5DkLYgwXOcIIcYsn5rGLwZwATaFikQZmwBnZ1UOFqqOMarQVU5atIzpl0v15nq YORZ+ljEmmz/79TRsmLzv2Vni6VEjR07mOtGWvT1154dS873keJ73fHCy1OAChIw1tYc /VOg== X-Gm-Message-State: AOAM533Syt5TgR6C1IcALTh11n0X+OB/zMwBhVLJl/Z2RDWQabdlbqmW +GifATgcYaHCBK9HK8p6aohXEZhXuWttY/XH X-Google-Smtp-Source: ABdhPJyP0L7+kNbjb687i7w1wzyg+YrLTPf+fehJ67MnVyUl7tP85xcGPS2oT8rxgT392YbT4bW+Ohr26jGwv8aY Sender: "andreyknvl via sendgmr" X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:adf:e710:: with SMTP id c16mr4123641wrm.295.1607538265727; Wed, 09 Dec 2020 10:24:25 -0800 (PST) Date: Wed, 9 Dec 2020 19:24:15 +0100 In-Reply-To: Message-Id: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog Subject: [PATCH mm 1/2] kasan: don't use read-only static keys From: Andrey Konovalov To: Andrew Morton Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org __ro_after_init static keys are incompatible with usage in loadable kernel modules and cause crashes. Don't use those, use normal static keys. Signed-off-by: Andrey Konovalov --- This fix can be squashed into "kasan: add and integrate kasan boot parameters". --- mm/kasan/hw_tags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c index c91f2c06ecb5..55bd6f09c70f 100644 --- a/mm/kasan/hw_tags.c +++ b/mm/kasan/hw_tags.c @@ -43,11 +43,11 @@ static enum kasan_arg_stacktrace kasan_arg_stacktrace __ro_after_init; static enum kasan_arg_fault kasan_arg_fault __ro_after_init; /* Whether KASAN is enabled at all. */ -DEFINE_STATIC_KEY_FALSE_RO(kasan_flag_enabled); +DEFINE_STATIC_KEY_FALSE(kasan_flag_enabled); EXPORT_SYMBOL(kasan_flag_enabled); /* Whether to collect alloc/free stack traces. */ -DEFINE_STATIC_KEY_FALSE_RO(kasan_flag_stacktrace); +DEFINE_STATIC_KEY_FALSE(kasan_flag_stacktrace); /* Whether panic or disable tag checking on fault. */ bool kasan_flag_panic __ro_after_init; -- 2.29.2.576.ga3fc446d84-goog