Re: [PATCH RESEND v2 00/12] improve mremap_test

[Sarthak Sharma <sarthak.sharma@arm.com>]

On 11/2/26 3:31 PM, Sarthak Sharma wrote:
> This series fixes correctness issues in mremap_test, simplifies its
> test infrastructure and strengthens validation of remapped mappings.
> 
> Patches 1-3 remove unused command line handling, unnecessary cleanup
> checks and redundant errno handling. Patch 4 converts the test to use
> kselftest helpers and removes manual failure tracking.
> 
> Patches 5-8 fix handling of unavailable userfaultfd support, unexpected
> mremap() successes, data-corruption failures and cleanup after mmap()
> failures. Patch 9 removes perf tests and timing infrastructure.
> 
> Patches 10 and 11 replace threshold-based random-data validation with
> sampled validation and a deterministic data pattern. Patch 12
> strengthens multi VMA validation by also checking the mapping state
> of holes after remapping.
> 
> This is a resend of v2 without any changes.

Hi,

It has been some time since I've posted this series (v1 posted around 2 
months back :)) but it hasn't been reviewed enough. Requesting for some 
review on this series, if someone has some time to look at it.

> 
> Changes in v2:
> - Add a first patch to remove command-line options (David)
> - Add a second patch to remove munmap() checks from cleanup paths (David)
> - Add a third patch to simplify errno handling
> - Drop the "correct multiple VMA range size" patch
> - Add an eighth patch to fix cleanup after target mmap() failures
> - Replace fully populating and validating large mappings with
>    populating and validating 10 pages each from the start, middle
>    and end (David)
> - Extend multi VMA strengthening to userfaultfd multi VMA test
> - Fix minor formatting issues
> 
> Previous versions:
> v2: https://lore.kernel.org/all/20261006092511.145776-1-sarthak.sharma@arm.com/
> v1: https://lore.kernel.org/all/20260924050009.19974-1-sarthak.sharma@arm.com/
> 
> ---
> Sarthak Sharma (12):
>    selftests/mm: mremap_test: remove command line options
>    selftests/mm: mremap_test: drop munmap() checks from cleanup paths
>    selftests/mm: mremap_test: simplify errno handling
>    selftests/mm: mremap_test: use kselftest helpers
>    selftests/mm: mremap_test: skip test when userfaultfd is unavailable
>    selftests/mm: mremap_test: fail unexpected mremap successes
>    selftests/mm: mremap_test: fail on data corruption
>    selftests/mm: mremap_test: handle cleanup after mmap failures
>    selftests/mm: mremap_test: remove perf tests and timing
>    selftests/mm: mremap_test: replace validation threshold with sampled
>      checks
>    selftests/mm: mremap_test: replace random data with deterministic
>      pattern
>    selftests/mm: mremap_test: strengthen multi VMA validation
> 
>   tools/testing/selftests/mm/mremap_test.c | 701 ++++++++++-------------
>   1 file changed, 291 insertions(+), 410 deletions(-)
>