From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbeDZEDK (ORCPT ); Thu, 26 Apr 2018 00:03:10 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53570 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbeDZEDI (ORCPT ); Thu, 26 Apr 2018 00:03:08 -0400 Subject: Re: [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV To: Jianchao Wang , monis@mellanox.com, dledford@redhat.com, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1524714759-14654-1-git-send-email-jianchao.w.wang@oracle.com> From: Yanjun Zhu Organization: Oracle Corporation Message-ID: Date: Thu, 26 Apr 2018 12:02:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524714759-14654-1-git-send-email-jianchao.w.wang@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8874 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=964 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804260038 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/4/26 11:52, Jianchao Wang wrote: > w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV > will not be updated in update_wqe_psn, and the corresponding > wqe will not be acked in rxe_completer due to its last_psn is > zero. Finally, the other wqe will also not be able to be acked, > because the wqe of IB_OPCODE_RC_SEND_ONLY_INV with last_psn 0 > is still there. This causes large amount of io timeout when > nvmeof is over rxe. > > Add RXE_START_MASK for IB_OPCODE_RC_SEND_ONLY_INV to fix this. > > Signed-off-by: Jianchao Wang Reviewed-by: Zhu Yanjun > --- > drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c > index 61927c1..4cf1106 100644 > --- a/drivers/infiniband/sw/rxe/rxe_opcode.c > +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c > @@ -390,7 +390,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = { > .name = "IB_OPCODE_RC_SEND_ONLY_INV", > .mask = RXE_IETH_MASK | RXE_PAYLOAD_MASK | RXE_REQ_MASK > | RXE_COMP_MASK | RXE_RWR_MASK | RXE_SEND_MASK > - | RXE_END_MASK, > + | RXE_END_MASK | RXE_START_MASK, > .length = RXE_BTH_BYTES + RXE_IETH_BYTES, > .offset = { > [RXE_BTH] = 0,