From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Julien Stephan <jstephan@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andy Hsieh <andy.hsieh@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v6 5/5] arm64: dts: mediatek: mt8365: Add support for camera
Date: Mon, 29 Jul 2024 17:08:48 +0200 [thread overview]
Message-ID: <f2e4d8a1-f683-415d-853f-b55abdb8c27c@collabora.com> (raw)
In-Reply-To: <20240729-add-mtk-isp-3-0-support-v6-5-c374c9e0c672@baylibre.com>
Il 29/07/24 16:48, Julien Stephan ha scritto:
> Add base support for cameras for mt8365 platforms. This requires nodes
> for the sensor interface, camsv, and CSI receivers.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8365.dtsi | 125 +++++++++++++++++++++++++++++++
> 1 file changed, 125 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index 24581f7410aa..cabdb51f4041 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -10,6 +10,7 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/power/mediatek,mt8365-power.h>
> +#include <dt-bindings/memory/mediatek,mt8365-larb-port.h>
>
> / {
> compatible = "mediatek,mt8365";
> @@ -703,6 +704,23 @@ ethernet: ethernet@112a0000 {
> status = "disabled";
> };
>
> + mipi_csi0: mipi-csi0@11c10000 {
Names must be generic. This is mipi-csi-phy@xyz or csi-phy@xyz as it looks
like it's not the entire CSI interface but just its PHY. Am I wrong?
> + compatible = "mediatek,mt8365-csi-rx";
> + reg = <0 0x11c10000 0 0x2000>;
> + status = "disabled";
> + num-lanes = <4>;
> + #phy-cells = <1>;
> + };
> +
> + mipi_csi1: mipi-csi1@11c12000 {
Same for this one.
> + compatible = "mediatek,mt8365-csi-rx";
> + reg = <0 0x11c12000 0 0x2000>;
> + phy-type = <PHY_TYPE_DPHY>;
...so the secondary CSIPHY only supports DPHY, while the first one supports either
C or D?
> + status = "disabled";
> + num-lanes = <4>;
> + #phy-cells = <0>;
...and then, it's confusing, one CSI has got one PHY cell, one has got two?
> + };
> +
> u3phy: t-phy@11cc0000 {
> compatible = "mediatek,mt8365-tphy", "mediatek,generic-tphy-v2";
> #address-cells = <1>;
> @@ -773,6 +791,113 @@ larb2: larb@15001000 {
> mediatek,larb-id = <2>;
> };
>
> + seninf: seninf@15040000 {
> + compatible = "mediatek,mt8365-seninf";
> + reg = <0 0x15040000 0 0x6000>;
> + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&camsys CLK_CAM_SENIF>,
> + <&topckgen CLK_TOP_SENIF_SEL>;
> + clock-names = "camsys", "top_mux";
> +
> + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>;
> +
> + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>;
> + phy-names = "csi0", "csi1";
> +
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + };
> +
> + port@2 {
> + reg = <2>;
> + };
> +
> + port@3 {
> + reg = <3>;
> + };
> +
Empty ports, why?
Regards,
Angelo
prev parent reply other threads:[~2024-07-29 15:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 14:47 [PATCH v6 0/5] Add Mediatek ISP3.0 Julien Stephan
2024-07-29 14:48 ` [PATCH v6 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-29 14:57 ` AngeloGioacchino Del Regno
2024-07-29 15:08 ` AngeloGioacchino Del Regno
2024-07-30 12:38 ` Laurent Pinchart
2024-07-30 19:38 ` Rob Herring (Arm)
2024-07-29 14:48 ` [PATCH v6 2/5] dt-bindings: media: add mediatek ISP3.0 camsv Julien Stephan
2024-07-29 14:57 ` AngeloGioacchino Del Regno
2024-07-30 12:46 ` Laurent Pinchart
2024-07-30 19:40 ` Rob Herring (Arm)
2024-07-29 14:48 ` [PATCH v6 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-30 13:29 ` Laurent Pinchart
2024-07-31 13:33 ` Julien Stephan
2024-07-31 13:51 ` Laurent Pinchart
2024-07-30 15:15 ` Markus Elfring
2024-07-31 6:19 ` CK Hu (胡俊光)
2024-07-29 14:48 ` [PATCH v6 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv Julien Stephan
2024-07-30 14:09 ` Laurent Pinchart
2024-07-30 14:34 ` Markus Elfring
2024-07-30 15:00 ` Markus Elfring
2024-07-31 2:59 ` CK Hu (胡俊光)
2024-07-31 8:29 ` Laurent Pinchart
2024-08-07 1:31 ` CK Hu (胡俊光)
2024-08-07 15:20 ` Laurent Pinchart
2024-07-31 3:05 ` CK Hu (胡俊光)
2024-07-31 3:35 ` CK Hu (胡俊光)
2024-07-31 5:14 ` CK Hu (胡俊光)
2024-07-31 5:48 ` CK Hu (胡俊光)
2024-07-29 14:48 ` [PATCH v6 5/5] arm64: dts: mediatek: mt8365: Add support for camera Julien Stephan
2024-07-29 15:08 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2e4d8a1-f683-415d-853f-b55abdb8c27c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andy.hsieh@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jstephan@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®