From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC12E71D27 for ; Fri, 29 Sep 2023 12:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233093AbjI2Mav (ORCPT ); Fri, 29 Sep 2023 08:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232990AbjI2Mat (ORCPT ); Fri, 29 Sep 2023 08:30:49 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAF3C1AB for ; Fri, 29 Sep 2023 05:30:45 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5031ccf004cso22234172e87.2 for ; Fri, 29 Sep 2023 05:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695990644; x=1696595444; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9D6U3h7VvtySfjwCrXv2bKuHA6TCTGNwEjt2Sm81uJI=; b=PvGhUEWAMTx6/EQ83rQk2Wznq66kHeFJnoCXpQjCRbYFGa6wRT5KzuUsNF7XANgWr4 gTqot8OzzU/+4bEAYcRP+LKQ0SdM21xA1a+2T4cI6nhGWoV/KBmKjvTEjvvcJZJs8nVE hoBKPOYk/2XktF/WqiA/LxTqeL4sQ9E45LaP37ELq84UzTNWV9v9k1jCpnLOGT0KBUkC EtX1hseIO8XsFe7CrgH5Kmz3DMT0EmbakVM2fzkognDN9aVuDq4HMarM5zo7TpRksnZl Btcw78BpLoTdr36PAON3kC859bAYBaKurmuBWddlLVHbegiyAM09Aj38Tm6n4nkrRXx3 GP6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695990644; x=1696595444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9D6U3h7VvtySfjwCrXv2bKuHA6TCTGNwEjt2Sm81uJI=; b=SCft9HMjrA0WtZI42WqjdCkN0sdlTib5pB8H5QIL6QC2reX+LJZNHh0hkz88rngmdg 00RjB3PeI0EMWhSe9uA9VpDokc8e4IP24M4/eVj30inALlc4H3eqcsEnSAUl3sCG44Z1 jqJ8yfVsotJOWkcg3C31AzmYgvq6I5Ilmy59cU43Ujyx6Euwc1fUPPEnj62JlP/CxBAQ SCZ/QqvIhalnGm/XgC9Fu3WNsXveKF0m3BcS90OOuOsZT1HSny1AKSkcl8ZNClMN4N+0 PEzh/U+2ftO81A494o1cu8nl3LO/WKjv/Hb1+5J4ekmfYWlxhXKEdXceVduMvWJ3lkqh 5n9Q== X-Gm-Message-State: AOJu0Yw1CA18SSS9tAVRZ3LNTm6OYYhCjOl7Hmr4XN0ZSdwDjyhHDKI/ 4m7UanMpoaSe5RjUivJLMtIcTg== X-Google-Smtp-Source: AGHT+IG35Lyp3ifL3xVwb3OmKh0JKsFL2ah9iqCExGP1+exCUUTXAWhW83gBYHeI8P6flItc65Kebw== X-Received: by 2002:a05:6512:6c7:b0:504:7e12:4846 with SMTP id u7-20020a05651206c700b005047e124846mr3991988lff.30.1695990643555; Fri, 29 Sep 2023 05:30:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id g16-20020adfa490000000b003232380ffd5sm13431260wrb.106.2023.09.29.05.30.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 05:30:43 -0700 (PDT) Date: Fri, 29 Sep 2023 15:30:40 +0300 From: Dan Carpenter To: Christian Lamparter , Shiji Yang Cc: Linux Wireless , kernel-janitors@vger.kernel.org, open list , Wu Yunchuan , Jeff Johnson , Dan Carpenter , Kalle Valo Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Message-ID: References: <20230919044916.523308-1-yunchuan@nfschina.com> <87zg16iab3.fsf@kernel.org> <0b7623f7-561c-4f3b-91c1-aaf1c44f1158@kadam.mountain> <721a4c53-a253-4b0e-a5e0-fc4b992feb49@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <721a4c53-a253-4b0e-a5e0-fc4b992feb49@kadam.mountain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2023 at 03:26:17PM +0300, Dan Carpenter wrote: > On Fri, Sep 29, 2023 at 09:23:26AM +0200, Christian Lamparter wrote: > > I would like to take the chance to again point to this beauty: > > > > @Dan, @Jeff can you please comment on that too? > > I don't know how Shiji Yang generated this warning. The warning doesn't > make sense and I don't see how the patch helps. I tested with GCC (v12) > and Clang (random from git) and neither one generates a warning. What's > the point of having all the struct members in a group when struct itself > already forms a group? > > #confused Wait, all this was in the email thread from June but I didn't scroll down beyond the end of the patch... It was just a compiler bug in a GCC dot release. regards, dan carpenter