From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB853CF676 for ; Wed, 22 Apr 2026 12:20:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860445; cv=none; b=j/e8akQvkpvJDZJ6rJu3jLwQToIyUxlrEvXAbsFvuyrBpdyLKq42vzoYsA7qt0vbezW1OI500eyPMUK2R0Gm73XFlGs5/h3eCbTWwfRwOAkX1IYclzvpKc6D3AsujIPnw4n06AXgqfZUvYT04pmoGbj8FQnU09ZpjxwLeDX9lZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860445; c=relaxed/simple; bh=OvXI+HDA1Dp49/adXJMTdbdphaPTr8WY9JhjFactW4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E0XoVa9EeNw7C5Hg1PKjilO4WErgSWFBNO6iNjxk4B/LM/MIiILLgBVgTNRofV35RgO9csqHd1z+LfMmWSn/vafUFk5s1fDvFuJRbuW61yFWbBzl/4A8rmBt9aRaPf2ebesQzfVGXZFkkp+Xcc059XjuXloWKyqBz3fDtAKRCd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lyKNJZnd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EtLFN3tt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lyKNJZnd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EtLFN3tt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MARd6Y976940 for ; Wed, 22 Apr 2026 12:20:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dx+fo7SZ7LP6SxYmEnIte8ECjGbhzyTGN2xgQ+oIBFU=; b=lyKNJZndfWsjAiy/ Vdo4XuxpBMjaf8MyhqS8DEf+jViGKcOUyIFluoKqtfDgUgwS3hBYc8D8l4D4Ai6G d0NbwrDEfg3dzzLxmVxM1Uhb3IGhQW4LbcxkEpOZNkdsvVYGQm7+EPV0op1g/q9L vzbpyOvhvKJ9cL6lfWKQT30Xsdd0YDo21ue72tukj5bAHMnQLmMW94lVyWsc0Ffv udpahAqA76zAq8y9zug0WwRAGWdcX5v1ebqdxVmcBJt38k7H04cbgT1sUDmmXU0X ORnn17Op2+XFoOoIDEZO0IkQ1vJBSBJwLYclH8OMJZF4AADmwpKztRKHHr3+wh5A EGDRJg== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenebcvf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 12:20:40 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-6058daaee1fso273406137.1 for ; Wed, 22 Apr 2026 05:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776860439; x=1777465239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dx+fo7SZ7LP6SxYmEnIte8ECjGbhzyTGN2xgQ+oIBFU=; b=EtLFN3tt/vP2uZ83Wjj3Ty0ebj52CYTRqo7zk3nIPVHu785p8rNL8cojgLXhMjMtXT P3LdbhWoQ9SWKEj1GCSV/d6Yi6f5ISp4Csh1neXDu8x8T5jvo2TlYHp+WZV2NgnUMGOM CTUGwSAHs2pit0M0hUZh5VS7q1+p9L8APcDaPNKn3j9h4Ju5Le9Sf2TabTmyec5503x1 ArubX0NaevzvqS252NlrNan8xsZthdEN7KmDu9LBUxXIn4Wia3BIJz43TMogMmq5PEnA hSqiPaj1BDmIpdi8qAMNYXGOBb69GPOz6R0Cro+Hs3lk2cG1jge1e2/aEK1bT23Bmyj+ GO8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860439; x=1777465239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dx+fo7SZ7LP6SxYmEnIte8ECjGbhzyTGN2xgQ+oIBFU=; b=Z8x2osX8CRVjZnZLypyOFmgm3NQGSLmeU13Cxgb8+AMRNeu6WIpmdTIpel1dxM3ClW B8SgxCPc+lSuRZyf2ocmZv+eKpuWl6T0PlJo58d/5ta0YurX75EAvk7k6DJ4W27xzBTD PRW8p9yWC+lwLx6jWx1yQqPOUzF4Dm1owTw9GXyWrYisMZF4JUj7SGslqiBzBAtBxv1D N1pGYjXXVJIsmT4XBlw8IO5Uu21Ip080FdISwILP0e1luNFbPS3/LJNdofijxIr3qhOX inQtUgl21/PvPeIdcTd+ypB6/jUGoWTXbbsI3DdNa5oDJrXQbMHr5QGzFIMrFuC1HPiP xtIw== X-Forwarded-Encrypted: i=1; AFNElJ+YtxweulOq1uaD0TUd25A8LgiTpsXLYlZvkXna3aYSxes2qXc+dJMjf1u8C0Ziu+9D8uzR/TxvRDbJ7Cs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7P4Mc/wj5iuX9RlpWezhcUssW0kPTnjxRwCdsDfmtkzpvdBRp qAkjL6X0lEe857lHhZ6Jm1yK/ybnxZ+feHiJP7WCM2yYyv5Bm3RPGX9VZ+X5DJjiO9idZPnreaI ImLVhO2AUuiRGMGBAebJ4KIlsh0vxFXTKWKZmL86DDD8HJ51//9jhQdSVkLyQEg2d83vIBvMv+5 M= X-Gm-Gg: AeBDietfPOlh+l1HrJXg2BjKeT1wwNQVX3gWuGjlLAMY5aWkWK+obrlrCwYUbszKTzI X1DJlWDUbrOIgAxhhHyow2iXW4jrchbNS2x2Po7fEkVAxfde/2kBWJrEehW2B8OLatreMWnGK8X 5CxdNAq9fYeCgj5HE4wTjyIUKzvL7HfQVPVnxgTi2B+c9zrArav3Lg9TYNv/u75VNEMNYzuL2he 3aDBiNFtv66laOs8YExP8d2Xua+ddaNf7Jqr9RwT5wB7NHjXOikXgvgqgnPwultvnmDFnnDDeVB vdnVBvO4NsV4yDiZitKdh+1Q69DxJD/vYJmtkSR9+smxb5FGOqBf1QMVLCCsRjuKvs+3n+sqq0D T2y1i6pok7VdLFy6pXOQAGKsibVMEwCONQ2EEH7oealexWJr5Wp1aMv1i6GY3spLPKFQ4dFJSrI HjNXpmtOtsXAuZgg== X-Received: by 2002:a05:6102:f06:b0:610:2c3b:7d99 with SMTP id ada2fe7eead31-616f88a28d9mr4163580137.6.1776860438805; Wed, 22 Apr 2026 05:20:38 -0700 (PDT) X-Received: by 2002:a05:6102:f06:b0:610:2c3b:7d99 with SMTP id ada2fe7eead31-616f88a28d9mr4163560137.6.1776860438330; Wed, 22 Apr 2026 05:20:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6744dcdf29fsm2688364a12.30.2026.04.22.05.20.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 05:20:36 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 14:20:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> <20260422-iris-code-improvement-v1-2-8e150482212d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260422-iris-code-improvement-v1-2-8e150482212d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDExOSBTYWx0ZWRfX2/BDZc/vo6mI yJyKyfGheQFYV+BWNk37fbY8u4/F0c1g955U++heWc6m2n6TvCHVkVdcMgbxP7pv3K+viMvBRcx W43RX0IENjhZty+QEWtJvZXs8w13xnRqYxnK3QNJwCR4I6q8/+/FPfOqH8KJMCE3QRXxmW4rGG9 YF8VJ+tmN72L5xwL76mbs7ftMGEJ2+W9XO1MOBYfFQ9G9Ym7Rq5bC7IS9tltooMh6+STdjMmoZy k63Cb3FvPZuwzrBEupnUARFBzgHY+cO1ti2jE0yjTcmcvmpd2fWmV/0gFe6KFZ1KcD8WFZkp0N3 4qfXqodZE6f8GO3W1mjnsxPITifuGrBMRpRtQqjzw59bJM57IJcPzwHdHdNc3HbaYqD57vdi3+l 3XCkOs1NuSB/5saZaMnUR0+TIvt4PtOtj1X6Edz/BS8OOdlMQsmMHuvCBt+cJ5ZT+aER8VQpwSi AtXELp4+tVowJUxS4aA== X-Proofpoint-GUID: 2pGYZ6QtGZF3ofsTHerFGFUNEjfuleJI X-Proofpoint-ORIG-GUID: 2pGYZ6QtGZF3ofsTHerFGFUNEjfuleJI X-Authority-Analysis: v=2.4 cv=RoT16imK c=1 sm=1 tr=0 ts=69e8bd18 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=X6cb7EJwOZpD8-w0EOYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220119 On 4/22/26 1:16 PM, Dikshita Agarwal wrote: > The state‑change debug log in iris_inst_change_state() always prints the > same value for the old and new state, rendering it useless for > debugging. This happens because the state is updated before the log is > emitted. > > Log the transition before updating the state so the previous value is > preserved, consistent with the existing sub‑state handling. > > Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") > Signed-off-by: Dikshita Agarwal > --- I'd argue it prints the opposite of stale, but the fix is good! Reviewed-by: Konrad Dybcio Konrad