From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898273F3270 for ; Tue, 25 Aug 2026 10:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652730; cv=none; b=apZfQrkQRWS8c4PnJr4eqkmIor0eG3Zup+8NeFW84CoFF4ki7YKggHcDJLkAXNTEP41jQlqeLfscj+yB1ov2hUpq6YvkBw3GaCdpfY41rmezsPqDng8cCE0G/N+LR8VVg6A9nV6aneR2X358XIpfsqLIWOhmVfCk/8PmACElHlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652730; c=relaxed/simple; bh=EQSGiojsYALTSGZ5Y4YskmupYqjLh+q7MfWEhQtMbEI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XtRndi7Mu4op3UcvpfApxYPJk+Wsd6DY/zj5LLt9sH2P+rw0HwJrmlsmP5M68PMvatWIwMzHp7lMW5lbLbswNqlrbumCQln2M3LUDsxKg1UrfKsS0c1jfL9ll7pO2OTFKpXsrj/1c09HVwiHIWAw01gLl/OxLyVNe1I2Di4pk18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dvmQlg1W; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i0nXYuev; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dvmQlg1W"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i0nXYuev" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P88cTP1253617 for ; Tue, 25 Aug 2026 10:12:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZJEm0YAVf8sVvEnytUvJioE0+EoqWLxL+9jnYrfDyFg=; b=dvmQlg1W6qBdV8t5 7FwJqiHhyXr4gIu/49lbl63+mHf7l45oVoapZrq5gPw+a4vrnAACOMHOuNkkGym4 SB6NqfY1HhpSw7/0V+/H75a/xQIXjSJNTlkagZxuiK9K9vXEDxSYu6CVJHxa/88C 60hZxJ8qkA0Vu18yrL148a0y3iHVyHvxVKjciYrtTDKTBdz6TADlc3tB+Xkcupgc kyY1+QKKAy6WB7DXCb3kLY1SDJniDJqs57e3ynY00/sIpMLcvYFCqUFOzr8dNizU 7/K2+B53g/sPIstZy+67+nrZ4zUg58McZIxr7NYkkvXMLjhbw5UOYjr1PwfVvOHP 6Qm3vA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8t1s3cdn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 10:12:06 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d55d8cd938so84972255ad.1 for ; Tue, 25 Aug 2026 03:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787652726; x=1788257526; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZJEm0YAVf8sVvEnytUvJioE0+EoqWLxL+9jnYrfDyFg=; b=i0nXYuev8HRneTJzUe3MHSnlOyNVlfoWiflTbONXItcBWAYlh+fWwmQ03YQRnnmMK2 gF8qGstANUNkIfOgnZg99AbdgDwZB8kq8epkrsTxg13WDPtAXlj1zN7tsewsYgwvCMWV IOkOuk5p1b8Aym8WfCrdkaGuJRu60n+3urRABDvfHcA5mEtTLQdNDCvFTKRgtOkQrolZ 6xMbDlQV+QMiCk0QHVJHtwlQZuplUIqkrLX9LmRZtXxfqUveQ+cO0Tzfo/+I+EGRD+bq Wm/RjOyUwNcJBXmXM4AxXAattUELQppsUSAHy/wBEjvhUdE7CeuTjKMqOBZAZUF+ON/f /CRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787652726; x=1788257526; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZJEm0YAVf8sVvEnytUvJioE0+EoqWLxL+9jnYrfDyFg=; b=CY2JiWI7py0wQpcSs1qJPrEBlNsHFlbcMXrpbsrTIVvXYVz0PaXk9RFZ6Cc2+UUnS3 Bkx053gzZqoEBGF13QnzVjrd+SLtZ/SpZKIws5IXLeXxA3Go5KkozF5jrlIZufMJStYF qml69G9pMvpw7CDYvwHQma7qRJNglWupiTjfd9zUxK9OTm+1z4zDPusHAl9M0gSwu6u7 ocMC+Gw5kqc58ghlEpS8uRhPX7vclB4lQY2jLSDf5Pok2ccaSc2jgwPtl+o+5CTuCm4N ZOWFZqCJnO3hP4sMyMnR1Kd7robPqMmZrLG7FaZGXyyQBARV2E6gMZjJSMDCk8c3phdk lwBw== X-Forwarded-Encrypted: i=1; AHgh+RqvT0i5sxaDFCZWgWCo6/CQ6a8NQ8PyCaAM5zCZWgIvsoQGZ6PhouozQTdVZyTa59xYcpV4uVRhmUqo8pg=@vger.kernel.org X-Gm-Message-State: AFuF++nqmZeFRvPK59LgPNH9TOvIc+nH89Fw+laXUygLJ8G8P6Gr9WlF wXEzcvryVNxs1oZ64IGbAm+aePvHj6PbxGGK/R2MN14uGwQZ2qqwZ6BKY0VOsk5keNBAiRw1VVF sT/v29xGwc+6OCC5lAzt/Eeri+gIDXX70DYWcYGuWV7QNdmurt0YS8mnXor7UkJ4hg0Y= X-Gm-Gg: AR+sD11UCOWL2MwF5S+f4vSCjagViPT6JKa+gkRhYWBwXeNAou4waE1blpfRLithK7a LJKFXiBLnj9ucpmdj/oeVEeq6MBM5y/VjZ1g86x1nkHkkD1ye9MYhotxBvvXIKliIA58XVwhN8G k7uXInbZtmVyY5vH+Fe8ESE7UWAPLQfRHU1aF7qTAv44fhA2S1nhTaK2Cne2MziYLvrgH9jZ/qV eg2gVsLvISdFredYz6OvjVCmnAMfz3O1w1lwwHzl0ptJ68Ixd7PvoAENoRg3AaZkvk9+UphKYwz cllQYfYI/kD7j8AphO8IvOD/9zxtwjm0YkUNUBCTm2zOVjM2l6UWuTgEn/pwg29QcG25cOdfnj+ eibeBgjGrvBWQ0UXR3RrJNwYYl3fHmBg= X-Received: by 2002:a17:902:e541:b0:2cf:82e6:a5 with SMTP id d9443c01a7336-2d670cbd08cmr430892585ad.13.1787652725999; Tue, 25 Aug 2026 03:12:05 -0700 (PDT) X-Received: by 2002:a17:902:e541:b0:2cf:82e6:a5 with SMTP id d9443c01a7336-2d670cbd08cmr430891585ad.13.1787652725581; Tue, 25 Aug 2026 03:12:05 -0700 (PDT) Received: from [10.218.21.115] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d676761cf9sm26410825ad.7.2026.08.25.03.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 03:12:05 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 15:42:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260820-shikra_dtpm-v1-1-40d96b8238bb@oss.qualcomm.com> Content-Language: en-US From: Khalid Faisal Ansari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dxvH-0k6kxxwfGjKiTckPMVbFD7POscS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA4NiBTYWx0ZWRfX4mit/WQtHT8A XAWX4b5TgxHomD8TrS3iR7Y8H9aPVBXOl5ziSNhYXXhmEjuhRlWpwxprU8B119pnzUIQsDClfE+ kBvNqPUrOoh4ASPvO8X6QhtE8sGyYka6jEvT9QdamjkFtWyo1reYyb0OSYxLm/TfWlqUuW1zebn SWFdAJDrgnzwF+CNjTwsOcwDBLKjhts1ltszo88pz2aUZru0Noek0Nb7s1gGXxuCg+6Crr4Jj/d tf0V/qhaefFb3YykJ/nMhmFWzrUa33GVHodao2tV/nLQdidNchUt5zMMNYexFN3NKAdfvSzv87d V3nxtGyBySLBHG1I54kqJULzhiuU8ZIW9YGxLEaJo95HbvBJOPNxy5jHhnvcg1v59u/ePJx0GJa ZucUkDvGtlVypBRkM20BB7007qRvoNx+Q0z2eFdjfVoAIyTJNpFG9YxdMMhF6ItB4pduWJzYXad 3TB5GcOoSGf9uSJJGyw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA4NiBTYWx0ZWRfXyS3Ohfi9+k+l FxPG1cJ0ITw1iSKSHoQyAhsXAYL2etI8gXqDfyhtgZRZDK+KR7zuTddBUWPos3tzf9hCxNxRbqh UqBfJGG/7UGnuK73fSEG5SJDxcGYZLo= X-Authority-Analysis: v=2.4 cv=L7ItheT8 c=1 sm=1 tr=0 ts=6a8d6a76 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=zVusS4tTP7DiVzkMLGIA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: dxvH-0k6kxxwfGjKiTckPMVbFD7POscS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_02,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 impostorscore=0 spamscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250086 On 8/20/2026 2:52 PM, Konrad Dybcio wrote: > On 8/20/26 11:16 AM, Khalid Faisal Ansari wrote: >> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM >> connected via SPI5. Enable the SPI controller and add the TPM node >> with the ST33HTPM compatible and a 20 MHz max clock. >> >> Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/ > This is not a valid tag to put in the commit message > > Why haven't you sent the two clearly interdependent patches together? I referenced the SPI5 enabling patch because the TPM node addition depends on that change being present. I had followed a similar approach used in an earlier submission (https://lore.kernel.org/all/0afa55d5-20bf-487b-abe0-4e2126ccf453@oss.qualcomm.com/), where the dependency was mentioned in the commit message. Since the two changes originate from different internal ownership areas but are functionally interdependent, we have been handling them as separate submissions while documenting the dependency between them. >> Signed-off-by: Khalid Faisal Ansari >> --- >> The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM) >> connected over SPI5. Enable the SPI controller and add the TPM node for >> all three board variants. >> >> This series depends on the SPI5 node addition in shikra-evk.dtsi: >> https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/ >> --- >> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++ >> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++ >> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++ > Turn this into a single addition to shikra-evk.dtsi I intentionally kept the changes in the individual board DTS files rather than placing them in shikra-evk.dtsi. While the current EVK variants (CQM, CQS, and IQS) all carry the ST33 dTPM, a future board could potentially reuse shikra-evk.dtsi without supporting the TPM hardware. Keeping the node in the board-specific DTS files makes the hardware dependency explicit and avoids enabling TPM on boards where it may not be present. > > Konrad