From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdHLQ25 (ORCPT ); Sat, 12 Aug 2017 12:28:57 -0400 Received: from mout.web.de ([217.72.192.78]:59975 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbdHLQ2z (ORCPT ); Sat, 12 Aug 2017 12:28:55 -0400 To: alsa-devel@alsa-project.org, Arnd Bergmann , Jaroslav Kysela , Julia Lawall , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create() Message-ID: Date: Sat, 12 Aug 2017 18:28:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rJilyKz1VRGCPD5XR39xpkF/HFqXBNjgxTSOlEAJnPqX9Att1Uo eUjQMAgNCLrYo7iCb2bQIQRFPluq887Gv2AhA2b6b8W8lvnO6ogfRNKYsSbR5ZSgyf/62GR gBFHU/D1btApcte8n/tWhnt+jVLWR/Q/B9NSqG76yy83syBIcifyfv/MlJ/QHDLVUPlbe/4 3Ltg0Zt+9YeT6SDzaYehQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:M6TiEUtbhn8=:8t3/Z74YTDTqOLsTBTrnoT 82V2FJDOezlTWolFEcVlz8kN1MZBakqER/7G9a8mg1O8SmKyPvccbSCrJuoZSXrvxXbZ9tNfq u3sCbh/mz5pnRfNLsNJuBMeaDO1lCPKXcwOAP6U3J3RjTrrsqg3E9c6B2E6o5cDjC08O4xwFv WnUYu6xJw4Lzh+tmX3vcHvbpdkb6seMwIvqhrK4bcXAyNmPGTmKHNz3a6PwDoXC/n3VBWe+T9 kLBmN+05xu+43E+PpslZChGGKNZgGWkd2cdllfQ/V7MojJNCPz9uDt1WHRLQqFKVcrBRCxm+Z x0wfi7Urb9g6PrAOzwLdynfwoYtHFA+cZkF7Qy0z6wRg0VembDlse+1temoBJ1iqlcnQFl4Gv uZvoL+RE6fFX+JmZZStPGTQRXJTqrX9wbklC2xDQmcKFLchzQPFMu/MXgs2CbAwDYjODGbxJg n/1qHZkINCj5oYJAf4BMGh+d+RVSlac9QoO3SdfiIHppLLi47YTAG8/+i3RbI/FUF8yXbjHOx h7rvTUT0AiUe1bzI+mDTlt7F9PDImlemhm2wz561/SG+sJ8IgKPRa2wftH3LHHQy2t4rl//+9 AxyA20EggRcy1a7lwaJKL4DCBmstob1W0edNnsZebxuVpSd1W6S8qt2C+v1EbrAIimZnsqqKu 5rVE01BL+CXA56Z73VUvUtzX1Fs2M/Yo5E1lK6KZONDSvrdByLkBg5BouXb0gqLM4N3RR01uQ N6XWH3poEZpw1C492p/yBXyXGVJ+Bs1O2eVxpBBsoC7tZYmhT44uHoVFw0alxRAEqiK9WJQ7e G80DMhQkqdPaGnL1pM5j07zBn/QGgeOZ9ETcUxz34u1iumrXlc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 12 Aug 2017 18:14:54 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/pcxhr/pcxhr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c index fa919f52e225..376fd76caec2 100644 --- a/sound/pci/pcxhr/pcxhr.c +++ b/sound/pci/pcxhr/pcxhr.c @@ -1215,10 +1215,8 @@ static int pcxhr_create(struct pcxhr_mgr *mgr, }; chip = kzalloc(sizeof(*chip), GFP_KERNEL); - if (! chip) { - dev_err(card->dev, "cannot allocate chip\n"); + if (!chip) return -ENOMEM; - } chip->card = card; chip->chip_idx = idx; -- 2.14.0