From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
<alsa-devel@alsa-project.org>
Cc: "Maarten Lankhorst" <dev@lankhorst.se>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work.
Date: Tue, 10 Oct 2023 13:53:28 +0200 [thread overview]
Message-ID: <f30ee046-82b2-ad7e-f173-1ac9e8b29370@intel.com> (raw)
In-Reply-To: <4374f40f-b1ab-a009-8d7f-1f4b6f6355ee@intel.com>
On 2023-10-10 1:43 PM, Cezary Rojewski wrote:
> On 2023-10-04 4:55 PM, Maarten Lankhorst wrote:
...
>> @@ -465,10 +461,19 @@ static int avs_pci_probe(struct pci_dev *pci,
>> const struct pci_device_id *id)
>> pci_set_drvdata(pci, bus);
>> device_disable_async_suspend(dev);
>> + ret = snd_hdac_i915_init(bus, false);
>> + if (ret == -EPROBE_DEFER)
>> + goto err_i915_init;
>> + else if (ret < 0)
>
> The 'else' part seems redundant. s/else if/else/.
Spelling error on my part. What I meant is s/else if/if/.
>> + dev_info(bus->dev, "i915 init unsuccessful: %d\n", ret);
>> +
next prev parent reply other threads:[~2023-10-10 11:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 14:55 [PATCH v6 00/12] sound: Use -EPROBE_DEFER instead of i915 module loading Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 01/12] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 02/12] ASoC: SOF: core: Add probe_early and remove_late callbacks Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 03/12] ASoC: SOF: Intel: hda: start splitting the probe Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 04/12] ALSA: hda: Intel: Fix error handling in azx_probe() Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 05/12] ALSA: hda: i915: Allow override of gpu binding Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 06/12] ALSA: hda: i915: Add an allow_modprobe argument to snd_hdac_i915_init Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 07/12] ALSA: hda: i915: Allow xe as match for i915_component_master_match Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 08/12] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-10-10 11:43 ` Cezary Rojewski
2023-10-10 11:53 ` Cezary Rojewski [this message]
2023-10-04 14:55 ` [PATCH v6 09/12] ALSA: hda: Intel: " Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 10/12] ASoC: Intel: Skylake: " Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 11/12] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe Maarten Lankhorst
2023-10-04 16:59 ` Kai Vehmanen
2023-10-05 10:58 ` Péter Ujfalusi
2023-10-05 11:26 ` Maarten Lankhorst
2023-10-09 6:23 ` Takashi Iwai
2023-10-09 11:56 ` Maarten Lankhorst
2023-10-04 14:55 ` [PATCH v6 12/12] ALSA: hda: i915: Remove extra argument from snd_hdac_i915_init Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f30ee046-82b2-ad7e-f173-1ac9e8b29370@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=dev@lankhorst.se \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®