From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753643AbdJSPYz (ORCPT ); Thu, 19 Oct 2017 11:24:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40684 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753249AbdJSPYx (ORCPT ); Thu, 19 Oct 2017 11:24:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DE302601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds To: Amit Kucheria , linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org Cc: "David S. Miller" , Wei Yongjun , Olof Johansson , Rob Herring , Arnd Bergmann References: <5c7bbac3efb2149d79f5c1735f91e64e8ff303cf.1508360121.git.amit.kucheria@linaro.org> From: Timur Tabi Message-ID: Date: Thu, 19 Oct 2017 10:24:49 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5c7bbac3efb2149d79f5c1735f91e64e8ff303cf.1508360121.git.amit.kucheria@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/17 3:57 PM, Amit Kucheria wrote: > Enable panic and disk activity triggers to tie to LED activity Could you provide some explanation as to why we want this enabled for ARM64? I don't have a problem with the change itself, but I think patch descriptions for defconfig changes should include justifications. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.