From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbdBITpr (ORCPT ); Thu, 9 Feb 2017 14:45:47 -0500 Received: from resqmta-po-12v.sys.comcast.net ([96.114.154.171]:44504 "EHLO resqmta-po-12v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbdBITpp (ORCPT ); Thu, 9 Feb 2017 14:45:45 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] drivers: usb: usbip: Add missing break statement to switch References: <20170209074956.GA3840@embeddedgus> To: "Gustavo A. R. Silva" , valentina.manea.m@gmail.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter.senna@gmail.com, Shuah Khan , Shuah Khan From: Shuah Khan Message-ID: Date: Thu, 9 Feb 2017 12:44:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170209074956.GA3840@embeddedgus> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfLI0d0+2a+RG6IMNAjO2z5nbVFcnCh+pzTfUyE0HOmGR7otxfsoXnKMPTOX2nNlniN9JkMW5xDKagJ7aEggv6YQFHkCtDOMIArwleWa503jVag1k2s9o b7ulXkbxNTQ88S+c3JSawXEE1X1UXmqIgF/hEiVQMLdZQe8ZPdvJKcvgKS4tXtYO94Bo0fASj1bEaJExQYADAhuQCftVA7cbEQ9wApcJ3io93bjaxYp964gy cSUHX6tHTr7HuBvW5pg4O743ecIGnv4WdM2yG8vzXfgUlKXhX3hgR1TsqpDzocyvd/ycer212YGzTCB47R1bGTbHCFffmxJtOAOkaomQpyOAzynvciyb2Jfk O8adz4VGQnyPYH/+fisbhSH3Ee9Gvu9MEDREVdzRWv7Br74ysSBTTbEORzUgUTj32qMRoueOwufDUykb6LbfbQJMpIJ3iA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2017 12:49 AM, Gustavo A. R. Silva wrote: > Add missing break statement to prevent the code for case > USB_PORT_FEAT_C_RESET falling through to the default case. > > Addresses-Coverity-ID: 143155 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/usbip/vhci_hcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index c4724fb..e4cb9f0 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -313,6 +313,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, > default: > break; > } > + break; > default: > usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n", > wValue); > Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah