From: yumeng <yumeng18@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
<xuzaibo@huawei.com>, <wangzhou1@hisilicon.com>,
<linux-kernel@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
"Daniele Alessandrelli" <daniele.alessandrelli@linux.intel.com>,
Mark Gross <mgross@linux.intel.com>,
"Khurana, Prabhjot" <prabhjot.khurana@intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>
Subject: Re: [PATCH v7 4/7] crypto: add ecc curve and expose them
Date: Mon, 1 Feb 2021 11:45:16 +0800 [thread overview]
Message-ID: <f319d30d-4bd5-a8de-bd0a-bde9e6838ed1@huawei.com> (raw)
In-Reply-To: <20210128050354.GA30874@gondor.apana.org.au>
在 2021/1/28 13:03, Herbert Xu 写道:
> On Fri, Jan 22, 2021 at 03:09:52PM +0800, Meng Yu wrote:
>> 1. Add ecc curves(P224, P384, P521) for ECDH;
>
> OK I think this is getting unwieldy.
>
> In light of the fact that we already have hardware that supports
> a specific subset of curves, I think perhaps it would be better
> to move the curve ID from the key into the algorithm name instead.
>
> IOW, instead of allocating ecdh, you would allocate ecdh-nist-pXXX.
>
> Any comments?
>
> Thanks,
>
Yes，It is a good idea, thank you!
next prev parent reply other threads:[~2021-02-01 3:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 7:09 [PATCH v7 0/7] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2021-01-22 7:09 ` [PATCH v7 1/7] crypto: hisilicon/hpre - add version adapt to new algorithms Meng Yu
2021-01-22 7:09 ` [PATCH v7 2/7] crypto: hisilicon/hpre - add some updates to adapt to Kunpeng 930 Meng Yu
2021-01-22 7:09 ` [PATCH v7 3/7] crypto: hisilicon/hpre - add algorithm type Meng Yu
2021-01-22 7:09 ` [PATCH v7 4/7] crypto: add ecc curve and expose them Meng Yu
2021-01-28 5:03 ` Herbert Xu
2021-01-28 10:30 ` Ard Biesheuvel
2021-01-28 10:39 ` Herbert Xu
2021-02-01 17:09 ` Daniele Alessandrelli
2021-02-02 5:13 ` Herbert Xu
2021-02-02 9:27 ` Alessandrelli, Daniele
2021-02-02 9:42 ` Herbert Xu
2021-02-02 12:35 ` Alessandrelli, Daniele
2021-02-04 5:31 ` Herbert Xu
2021-01-29 2:49 ` Stefan Berger
2021-01-29 3:00 ` Herbert Xu
2021-02-08 6:35 ` Vitaly Chikunov
2021-02-08 6:47 ` Ard Biesheuvel
2021-02-08 21:27 ` Vitaly Chikunov
2021-02-01 3:45 ` yumeng [this message]
2021-02-03 18:03 ` Saulo Alessandre
2021-02-04 5:41 ` Herbert Xu
2021-01-22 7:09 ` [PATCH v7 5/7] crypto: add curve 25519 " Meng Yu
2021-01-22 7:09 ` [PATCH v7 6/7] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2021-01-22 7:09 ` [PATCH v7 7/7] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f319d30d-4bd5-a8de-bd0a-bde9e6838ed1@huawei.com \
--to=yumeng18@huawei.com \
--cc=ardb@kernel.org \
--cc=daniele.alessandrelli@linux.intel.com \
--cc=davem@davemloft.net \
--cc=elena.reshetova@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=prabhjot.khurana@intel.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®