From: Tom Lendacky <thomas.lendacky@amd.com>
To: Arnd Bergmann <arnd@kernel.org>, Borislav Petkov <bp@alien8.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Brijesh Singh <brijesh.singh@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Date: Tue, 17 Jan 2023 11:27:43 -0600 [thread overview]
Message-ID: <f32a336d-57bb-7b0a-6adf-be731cdfb684@amd.com> (raw)
In-Reply-To: <bce8c402-edbe-4ba2-9cde-1a9485255c02@amd.com>
Updating email for Boris.
On 1/17/23 11:26, Tom Lendacky wrote:
> On 1/17/23 11:13, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This driver fails to link when CRYPTO is disabled, or in a loadable module:
>>
>> WARNING: unmet direct dependencies detected for CRYPTO_GCM
>> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>> Depends on [m]: CRYPTO [=m]
>> Selected by [y]:
>> - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>>
>> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
>>
>> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files
>> to sev-guest")
>
> This has been present from when the driver was first added, so I think the
> correct Fixes: tag should be:
>
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
>
> Correct?
>
> Thanks,
> Tom
>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/virt/coco/sev-guest/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virt/coco/sev-guest/Kconfig
>> b/drivers/virt/coco/sev-guest/Kconfig
>> index f9db0799ae67..da2d7ca531f0 100644
>> --- a/drivers/virt/coco/sev-guest/Kconfig
>> +++ b/drivers/virt/coco/sev-guest/Kconfig
>> @@ -2,6 +2,7 @@ config SEV_GUEST
>> tristate "AMD SEV Guest driver"
>> default m
>> depends on AMD_MEM_ENCRYPT
>> + select CRYPTO
>> select CRYPTO_AEAD2
>> select CRYPTO_GCM
>> help
next prev parent reply other threads:[~2023-01-17 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 17:13 Arnd Bergmann
2023-01-17 17:26 ` Tom Lendacky
2023-01-17 17:27 ` Tom Lendacky [this message]
2023-06-09 14:09 ` [tip: x86/cc] virt: sevguest: Add " tip-bot2 for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f32a336d-57bb-7b0a-6adf-be731cdfb684@amd.com \
--to=thomas.lendacky@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®