From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpcmd0756.aruba.it (smtpcmd0756.aruba.it [62.149.156.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8007080E for ; Mon, 2 Mar 2026 08:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.149.156.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439268; cv=none; b=gc40iAbFdBXrZVfjsD38h1SETQpF/wGF0OruZNQ2qQPnG3729fvDleCcrXNOifKuLYjaIEyagQ67bVWR9M9YP2ZCrLMZegVdu29YgDSruHx+Hb5X3SzZaChqNe5rmkUjrtKjNgBB2qdZeXtSTqMMECwIZiKmImFDzKiLXyD9R8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439268; c=relaxed/simple; bh=WgA15JntbsAlurA21LVEqQO4BSZjHqyBonnpgz26+no=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UJpiLqGEIGIwpxIPd7IqIL35jhV8vXPk6SnZDOyKjAcM7CrAmYnAteEe/UMMvCEr8GKR0DLH1jd6VNPNV2j6bZzGhIVj8hNMP9ztW1xImlai0BOUOIl/l+Zn7EFYqrLtPhsXvxzvyIExdk7lDrYKi4J/vfC8LRVqYd+2v5Z+BPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com; spf=pass smtp.mailfrom=enneenne.com; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b=hocTtwR5; arc=none smtp.client-ip=62.149.156.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enneenne.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="hocTtwR5" Received: from [192.168.1.59] ([79.0.204.227]) by Aruba SMTP with ESMTPSA id wyN1vWSWftpTfwyN1vXVAZ; Mon, 02 Mar 2026 09:11:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1772439075; bh=WgA15JntbsAlurA21LVEqQO4BSZjHqyBonnpgz26+no=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=hocTtwR5JGJyc5X5LLyfyaOBLLVfvDm/4ghZ4W99RgLQe1ckvtkibJEzIiysZesrl srlKvpZR1NnCPOTZpUqeawwbK0kWWvsStKe7BB52UewEbjAAV1L0OhMfDsLOloUQnd T8+IMYT5JdF+VBHHN/5oNOWP+BCFquBMaPQ4p4kUlYGQOlFpCsxcX6H88ipSKUcwA/ voSYYenQ85mgAoJGP8cAArlXrT8IftPiUcaidoAqRwPk3GCJLluNyhIIiFOIAKp5aV ANIYUpocW6/CoHJNBVs492r8VKCcFcSlf80ue1C2KmeXV55CP38Fo7Z5lnPfXNUXJ3 7A6tpOByJdFkQ== Message-ID: Date: Mon, 2 Mar 2026 09:11:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pps: clients: pps-gpio: fix echo pin configuration Content-Language: en-US To: dylan.laduranty@mesotic.com Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton References: <20260227-drivers-pps-clients-fix-echo-pin-setup-v1-1-a5a5f52d7d96@mesotic.com> From: Rodolfo Giometti In-Reply-To: <20260227-drivers-pps-clients-fix-echo-pin-setup-v1-1-a5a5f52d7d96@mesotic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfAeSriSp6GkVpIi36N5zqJ9JhJ8+qo+f5XsGs7SDEQ6B10RCenLzgz0FE1XPYf2bzqMCizjHq2ac4Pq02m2LPqFsV+0omA/kPM36L4T7UQ6TxtsHHPVe v2JILl9sSt3ecDylVQXCSt3LqdkViO6m4KRadmB7lLdXwHBw5fG0yV85rHSE01wO9iS+tWyToxnht5aranGZhP32A4NrUBjdbAqoUB7ThW6uA6NjlvWptdIh 9yCBhhOpIYj4RgUoDK9hyPy9Awz2XfDKtrtvpY0A0qq+BnVBOjf4Z3XBTCPNHhmdnQR7rf+PZwJDSEKCx70diA== On 2/27/26 16:45, Dylan Laduranty via B4 Relay wrote: > From: Dylan Laduranty > > This patch adds PPS_ECHOASSERT and PPS_ECHOCLEAR to pps_default_params > when needed. > > The pps_gpio_echo() function will check if these flags are set inside > params.mode to update the echo pin state. > > However, these flags need to be set during probe sequence otherwise > pps_gpio_echo() function will never update the pin's state. > > Signed-off-by: Dylan Laduranty Acked-by: Rodolfo Giometti > --- > drivers/pps/clients/pps-gpio.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c > index 935da68610c701e6d9de53c667237f77438d7107..83ca24118eccfdb9eebe272023ef4980c9d54cf2 100644 > --- a/drivers/pps/clients/pps-gpio.c > +++ b/drivers/pps/clients/pps-gpio.c > @@ -200,8 +200,13 @@ static int pps_gpio_probe(struct platform_device *pdev) > > /* register PPS source */ > pps_default_params = PPS_CAPTUREASSERT | PPS_OFFSETASSERT; > - if (data->capture_clear) > + if (data->echo_pin) > + pps_default_params |= PPS_ECHOASSERT; > + if (data->capture_clear) { > pps_default_params |= PPS_CAPTURECLEAR | PPS_OFFSETCLEAR; > + if (data->echo_pin) > + pps_default_params |= PPS_ECHOCLEAR; > + } > data->pps = pps_register_source(&data->info, pps_default_params); > if (IS_ERR(data->pps)) { > dev_err(dev, "failed to register IRQ %d as PPS source\n", > > --- > base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 > change-id: 20260227-drivers-pps-clients-fix-echo-pin-setup-fe52d3b8596f > > Best regards, -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming