From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E49A31353C for ; Tue, 9 Jun 2026 14:07:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014079; cv=none; b=FaMGFH/jg30752mnfnjCxKO4Rh/JL8XCoLcYBlhuTDFclkF7VrN2kn//j5kSyzsv9Y+NnXwkWhvLgKbNti0S90Mlz3VuHUyH1NHNkWNO9Mp90qlDYpF3NIC4QbueTy100DkzLWL/ceVN09K/y1cyQyE23EaUggAFup1lKAaiOqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781014079; c=relaxed/simple; bh=FmDYsp2scSZ3q54ZHGgu4ZeWYbFYjiOygsbrYNCfSmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GxCD5qXNWMP0HXRreUeNGH/WqoMVEA+51Ix/iqa9SNowYht4CwyC07OFInKTwTpV9gR+cedTzawRyYdmieimVCiaYSNrQRZHBsr4JsgUQ2Z2zCL1yXZszuRwIzENj5A6tUU13BQHGKmWBmQjfzTZaUKCN14wi864Yz4BKd7bgqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CuuL3/D+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YCwZzN16; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CuuL3/D+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YCwZzN16" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659ClY9q2706226 for ; Tue, 9 Jun 2026 14:07:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RFeXds4R5J9h3sAk6YnSG7bweitI9YW6z24vpi9kFXo=; b=CuuL3/D+mCccoNjH 5T9SQwC6HOXMLJWquMrPX3L6NRdEnwcaOhhyiFaHda1R13zG5vomdkLEBdp+HIdg aVfbtWyaO+AcQ2xmTMTUXKyf/4rLihm02xWJ0RX2UTBDDw/Bk7tASAPVGu0+foFi e+QpE8kdDVngz2h7qOszfqSp+KL1yaV1B5IrDst9H4z9MgMr7FJzfpula1htzR3V cFFZ68dFWlNkSJ+LAf0o96Eg4vX1P3yZxg8EgAXP+sxm+xHpQQ/teVyZVxIknFf+ /tvqvNqqqfU2go0Yh7hGPFTs5q/GandbCrbit6/9/A/s20y66DAXFsRKd0HUDAb/ mqk0vw== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epfdt1h2p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 14:07:57 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-6cfe512ea6bso237126137.3 for ; Tue, 09 Jun 2026 07:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781014077; x=1781618877; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RFeXds4R5J9h3sAk6YnSG7bweitI9YW6z24vpi9kFXo=; b=YCwZzN16qx0ZKJZWPmitnsiq5yQxm95bNwKTHiQyiFSx5T6sYb6BKriWu60f/lCQb5 7t14XH7IFe91w++Vir16k2HsPCOBJIPl/7p6J4i484BQrntjM3HvGaShgauahsWYZnGN HbJkTXfH1rzarFgQHkKaeECqqvLWIKTL5SHUdDkrzpdhEoWWZ3WM5bROZRS82kdOO95M 9uEluoCfByKK1IOIk4eZfCD6pFkvK06AnTqqaOi8Sp7n/g1S+/t5yi/yqOvw3HtKAZx/ 1EyxH4YOODplKL6aaYw815EkAEn4e7qgKzihMi/6Zxkhe26xHjzDjjXXPQhXu20yMuSI kq9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781014077; x=1781618877; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RFeXds4R5J9h3sAk6YnSG7bweitI9YW6z24vpi9kFXo=; b=lsWZYdhVBUOmpLe/EVksECcsBALFIIFATO10KhXy/8Qycf9E9gn5DtukQpaMri2vrr VRMp+wr9ZlbjyygCB0jULk5lQXKw9CYZCZ71grEoZCiPghw/I86Fu72Mx91lNHhTtcyD 3aRk0OUFLd545tVdDNmzWxBbGeM7hShlIBqMHfoUfAc6InKTXjVtuYSWb/z/oKsEUDUT fkb070fafICafQ/fPawKQBlUgjZe1UURvE66hgPK7an2gvlk4nIqk4kfGRKw1N7wJUR+ VtnCPEcgzNcAsrlzUz97kv8xoBNV1ltb2qw8KRb+1me8b+vJcTG5Uam6ecWnPFoTuAQd iNbg== X-Forwarded-Encrypted: i=1; AFNElJ+O8udnItJhiJMDwvQaj4hKLkx22lZ9VQFsPjBMoi7tNukhEVknVN3marpRVneOyoYFHjSkKUtzgS63Cpg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg/qB9v15aT63oAq35Aw2NsYvutwr+WfHtTGompCO2mB4zDm6S Wuyd/2gMtlKs4jbGyzT1t9BEFwcAseCozqZ2pQrFmYrbScDpcGbK2eoCDhzPJTNJdBztMr9M6m3 Bf1FuaLTMKYevuukx+KBxpWCO0qExMlA5jRHFIs+BMBZGef2AHbmkWCMgxnOb8jPHgw0= X-Gm-Gg: Acq92OG/Sn4q8L3GDTvlO3N24KHiL1Ea3uQ9qQdKNAtfQ+b2cZc3wVM9vnAfdo+6eV9 svvRrkVWr2KFSYFrSSKrKuz4PrZTYCOq06wK85VDzXNloTBMvT78pCqvWkvqmIrhpcslgLeyJYK h/slZYorOYREQ2DD9EKNcHngU6jYy9dX6/hxN0UstfKRwAOpk5c1YCPLMnJaU+U86d0yZfLWPGb lLu0nRHXP9HYFScYSYBPlGEpfXQHHojGe+qwVvLVCBjw6C2TN6v77OeH0ul9TWG5ouKf7aSiHSr 0Ay/olGXUCVMTMjgOHsYcmT4CNx9f01qTbIfik8LTMWL4E1Mly94Atsy/xUz/YF5jyIWLGGwsui Iz+eqEshlGMoh9xmIv0WRYup5G77Zvf2HqFQdIaeiJOZwFMkQrNsjJqc0 X-Received: by 2002:a05:6102:548c:b0:633:3bf6:977c with SMTP id ada2fe7eead31-719160955fbmr459842137.1.1781014076817; Tue, 09 Jun 2026 07:07:56 -0700 (PDT) X-Received: by 2002:a05:6102:548c:b0:633:3bf6:977c with SMTP id ada2fe7eead31-719160955fbmr459805137.1.1781014076231; Tue, 09 Jun 2026 07:07:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0517714c5sm1061974666b.2.2026.06.09.07.07.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 07:07:55 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 16:07:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Drop fake PCIe phy 3B To: Krzysztof Kozlowski , Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420133616.88740-2-krzysztof.kozlowski@oss.qualcomm.com> <5c1f7955-883f-4fa8-a0e5-513a987bd3a9@oss.qualcomm.com> <0710caaf-ec73-4c4c-b6cb-7fe716724f4b@oss.qualcomm.com> <13349811-31e3-4658-911f-6f93d74efaaa@kernel.org> <658358a6-45bb-424e-8d8c-5b0b09cf479d@oss.qualcomm.com> <569f9eed-09b4-462f-b90b-9d8cb7867148@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <569f9eed-09b4-462f-b90b-9d8cb7867148@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: mlGxiTVdTyLOZ35L5uGbZJbnlRYKH9EY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEzNCBTYWx0ZWRfX6EYK4T5fqz0q XIx1F8IV3Y3lHs/zmpfdHf3j/kO+hDwx85ycuZkFFnVwOrNeQ3wYJXCcEEGSZEZnlJjnIpPE0Xz 7OlB/5ivgoDDWBcO7wOg6cC+ajI2U94CveszYglSz+E/vMeNti9sExWdCPdFGR2ybPAiKbFbCs/ DHTcNATWGvO/45/o2qHlnLwrOpSumObkk3b2ldjweGpL+LZdnAVuq0dcmX8GeKYgXM8IhL101u4 /kaIqFQJpSxK3Q3EofrXU37MNxxfJjeTE2rlk/PAoU5cXcgBbauvXeNcRzGUpXZhRcY54s6/nkE 827C4h1THxoVExPZzpP/e4xewOX4wy48pVKuSOs43GyOkFmDNJgJ2sneXymQuY+4lD7v7mIAB8U PePePQ6c1CNVi+ubwCqbjMEF1o+ZBIR2Kvv+CdQIYY4YoF8XKhve13gzBSXljpmoa7uXYyHQ3ym /114wRzef6kiFXRYEGg== X-Proofpoint-GUID: mlGxiTVdTyLOZ35L5uGbZJbnlRYKH9EY X-Authority-Analysis: v=2.4 cv=doTrzVg4 c=1 sm=1 tr=0 ts=6a281e3d cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=XrpWG4DannpcGcY-z3sA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090134 On 6/9/26 3:41 PM, Krzysztof Kozlowski wrote: > On 09/06/2026 15:33, Konrad Dybcio wrote: >> On 6/9/26 12:28 PM, Krzysztof Kozlowski wrote: >>> On 24/04/2026 13:09, Konrad Dybcio wrote: >>>> On 4/23/26 9:16 AM, Krzysztof Kozlowski wrote: >>>>> On 22/04/2026 22:08, Dmitry Baryshkov wrote: >>>>>> On Tue, Apr 21, 2026 at 08:41:14AM +0200, Krzysztof Kozlowski wrote: >>>>>>> On 20/04/2026 20:02, Dmitry Baryshkov wrote: >>>>>>>> On Mon, Apr 20, 2026 at 03:36:17PM +0200, Krzysztof Kozlowski wrote: >>>>>>>>> According to user manual / programming guide there is no separate PCIe >>>>>>>>> phy 3A and 3B, but one 8-lane QMP PCIe Gen5 PHY which consists of two >>>>>>>>> 4-lane blocks. This is also visible in memory map, where the 0xf00000 >>>>>>>>> is marked as the main block with additional sub blocks for each 4-lane >>>>>>>>> phys. >>>>>>>>> >>>>>>>>> Describing the sub phys without the rest is not correct from hardware >>>>>>>>> description, even if it works. >>>>>>>> >>>>>>>> Is this the case for the other bifurcated PHYs? >>>>>>>> >>>>>>> >>>>>>> There's more? Oh damn... >>>>>> >>>>>> In the previous generations. I think Hamoa had one. >>>> >>>> Any PHY with a name ending in -A or -B. That means: >>>> >>>> $ rg 'PCIE_.[AB]_' drivers/clk/qcom/ -l >>>> drivers/clk/qcom/gcc-x1e80100.c >>>> drivers/clk/qcom/gcc-glymur.c >>>> drivers/clk/qcom/gcc-sc8280xp.c >>>> >>>> >>>> And, quite predictably, some PHYs may not only bifurcate, but also >>>> tri- or quadfurcate (on Nord). >>>> >>>>> Ah, I did not check the others and there is little we can do there - >>>>> it's released DTS. This cannot be easily changed while keeping DTS >>>>> compatible with users, because probably two PHY nodes will be replaced >>>>> by one with different compatible. >>>> >>>> I think no one utilized the non-reference configuration of those PHYs >>>> in practice. Should a device like that come around though, we'll think >>>> about what to do then.. >>>> >>> >>> What is the resolution of this discussion? I have impression that no one >>> objected to my patch, so maybe I should resend it? >> >> Qiang is working on a proper solution to this. PCIe3B is nominally used >> for a secondary NVMe, so on the occasion that someone has one inserted, >> this isn't really a huge loss (the Yoga laptop and the CRD both have >> a primary NVMe on PCIe5 IIRC) > > This still should be removed now from the DTS, before you get more users > of it and any change will have impact... That's what I meant, in a convoluted way, yeah Konrad