From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F249F358D27 for ; Tue, 17 Mar 2026 09:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773738949; cv=none; b=GKh99ZJZFT3hdlashTv/94t/5h+YHldHt7CKrkC/XcXd6QJphIKW7/OMpJX7mGp/AvpmERBc4T8YO1AG00XFkxHcHuzuvyib+XITa2zVDsKkJZGg08OR7SCONSFrEkGxt+UZ1I8RWtCkhWOI3LEIBj99HHPlfkW92Sk/m7Cf8Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773738949; c=relaxed/simple; bh=tLDsJ3xH3Spdcca9pdvNzIb9hidWDi/5wO6TJ9xN0hk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r9sgYYH5t5BCEtAQkwvuSqbShgm4rdRhCX26fUDgxc1CJglFh89BHE8zvEalPMgIPcEIRFKb/OVkFEyPHp+WPzgqrh0mLQ2S6yaXhlmVa7ZXTbDZByxYctDJX/xZY7di9AZ3x9zcPqr9BEj1/m+dIsN7S/0R1DvpNHc/9pUaSYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LpA55TNu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UmfYvzh8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LpA55TNu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UmfYvzh8" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H97pEp3124594 for ; Tue, 17 Mar 2026 09:15:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vOuiJ6MeDMkaWLveMBBkfhjpipSzpptBgVxbpSymF94=; b=LpA55TNuDvPNJoZJ o2ILbP6uuKoSILs/FaBIqRvUNZ3rXskSgY0pe81mRBUvlXjly7VqErYdDVHkSMyl 5Phvwp6ukaLmdxsEpnSGz9YvXu97wZj+sSBdPaiFBpVT8z+FKETtM23WP5UWEbSp PDJZpysve5jZKLKrzg5V6ympYdkRal7q7DrD+dPYwwijhpG6Bc2XRoXIGjPO6HFU 5mPc5T+DC5BY/WjjNVTl6jgxo4Ubpxa04CQFzd/rYgUa7UKELDjoxeGLITkf7Bqn TWCXdulkZg+Yks3teRIS/oIzbGqFSlLlfNQLz7bsLGZeOCWdMtJVPf8/IpJjzXHP tUwg4Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxfsmmeh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:15:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb38346fdbso398584085a.0 for ; Tue, 17 Mar 2026 02:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773738945; x=1774343745; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vOuiJ6MeDMkaWLveMBBkfhjpipSzpptBgVxbpSymF94=; b=UmfYvzh8Ru4caShAWZS0a4yn32y8OyztfdOgNZfLRK4yBy8AVtUT0EhUnmoz2NcmUm T0WZNjXhBsdOebUKgqxlFL1BWOWF/S6CbM5LEyabGXKZ/BK66oyJxwg9PvXbgGh8lL94 nB8Q9zxMA8uKmS2S/IJRL/opQW7QnDhGNue8UrUIfMml+rIYDoXCOqSG9IZxL9UeQKLu SfRVvqkviiYeIojMDrtUr+/MXVMZAZqnsebS5UwvPOgAY+mqc8065KaFSfhsL4KgAUCg AvJ+teA+yd56jVaAvMxTJA644TkrdJ5f8V2LI9s/JZAUshZjON8ec0pMINoTEHZPYV1U 7MZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773738945; x=1774343745; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vOuiJ6MeDMkaWLveMBBkfhjpipSzpptBgVxbpSymF94=; b=jbzX0j1TmK7aa7XH3wJvoxwcGgOZ5rt7WXHxIXWIzbZvVyHRRFYY9jyWNLHYXg7pP5 8YmAOQ5K+HhX3vl4mCt+PQr8TFKasirEMfPeVGy8ZbAqblPIGx3YbrCrjoA3cXsp0Qry kZU56czrAOy1hRkiZAHQBOGcxnHMnYQcMVLHMKv+AmdITD4H7tukiCL3E3tvd0yIZo2I +pxAl6iBCPwqeiXdbJd3YfVusEhvgKXpOEuIp6wIbuTyqXu3SbeplUO0ip7plaH5q+h6 uzm2SRuTU46YXB7npCOcSvQwDQgrFABtEQIif1TVbvi4CukqwtUvsWuNoYuwe6C+8Ycg ROgQ== X-Forwarded-Encrypted: i=1; AJvYcCU7jInmNeZBqASxBxz4JFqGQmXchkHbPZZmWMPX/7Fo+eMEmEgaKWmiRU2QkVWK/e7sSb02Zyu49q8ljJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwWKpulzhwcbOdHBSLziGlqhWpejtMPVQxCkc1fNa2WAtCt7gAG LqhbZPQyQCOblJ6bTuSDtdql9ZKfGax3E+SdHqnedzi10HS5h+PyAZtP+OosVgL1HmIEdDTrwc4 mQ+6MqFX0BThzLe2XhURhPKBttFbgDHYt6povFTv9FpVqZC/8Se8kmiy2HSCOuylLlzg= X-Gm-Gg: ATEYQzxc+D2z4gJA93+LbjkRyNGou30Rc3uKUSFlbvwr2uvVi9nrfm+RvjheM/7ndyO XMKDCXWC8qdLKZD/5gYqvyNpr9zRvyf9MTrATrzXWavDSGT+MclTs+VehmoNsmv/b3arUKvYtI1 ArPz4bO3xt8kLsW31irHsLzq2Pz1vjabyaMOzc49gJeuk7D905tbtjhppSHxs3vqtiFlUrnSm8S /yBZ5FpTciNapGeW6yFBR5wkHY2+ooh4ypQw26jhq5TzOiC38VGv0E9s6vcVxqgVQM5H//d3Uu8 YsZBUiA2unSN3VbeeEc4KbaCJHXbMkzkpFfpgtds6iUBZoczMbhUA272cxA85JmXRWSDZQ7pUFb vzEPGeB7Rqjs0uYYf+XtV7DxWN4BFuC7wEVTtWZ+CdC9g1zIM5F7YktAPHHUKImWgEpgRgqhT/k Pxmac= X-Received: by 2002:a05:620a:1a0d:b0:8cd:78b6:e261 with SMTP id af79cd13be357-8cdb5a2d5cfmr1661636485a.2.1773738944993; Tue, 17 Mar 2026 02:15:44 -0700 (PDT) X-Received: by 2002:a05:620a:1a0d:b0:8cd:78b6:e261 with SMTP id af79cd13be357-8cdb5a2d5cfmr1661633985a.2.1773738944550; Tue, 17 Mar 2026 02:15:44 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66350d73f14sm6262122a12.30.2026.03.17.02.15.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 02:15:43 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 10:15:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] PCI: qcom: Add D3cold support To: Krishna Chaitanya Chundru , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Will Deacon Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com, bjorn.andersson@oss.qualcomm.com References: <20260311-d3cold-v3-0-4d85dc7c2695@oss.qualcomm.com> <20260311-d3cold-v3-5-4d85dc7c2695@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260311-d3cold-v3-5-4d85dc7c2695@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MSBTYWx0ZWRfX558GRk9QS/3C zGamAwBIouv9bzW/zj9KwFfoVUVmod1Os9PYf2LAsgdEJbYnYsnc6NNSXI0pYCBb5WLawL3ScIx kNetR0gFHEWXtlWaCARX7uYIvD+MG7Mbdv9qi0tC4EeiEFp/XgQeQ+sSWOj8TACl29IRPYTQSmK k0qgCh423J+DMW7sPpineuwTGeHMAmEyU1P4nGrKtc4bk+6Q7Ef3NzWhmlQVt0QaixdnFD1Lts0 BQ5VXvqyo3R7wO6PKKkgeTUm9kYoe1f8u65SSdekagq0uSykZ5uQrqcNg9Ga71iNE5VXC6ZbNha rAe8clBmuncur4Jm6L8BCu7/e3/Df/cCVUM7e+MsJ49Mnf7ns93szcUohrxjrDG8ldzLH7QhdLe wdwmXLe2fYxLcelNa+/Eb/jtcZcQCd3MwhsUjzKlXwYXSVkPlQgoVcMYQclLJGlHdL46ChEMGHk kRgPf9RqGPXkOtzSbIA== X-Proofpoint-GUID: AO4CJ0aXjYGi6vWCXsx-J5NZFCyIchBO X-Authority-Analysis: v=2.4 cv=V/hwEOni c=1 sm=1 tr=0 ts=69b91bc2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=U-o9HKKhJ6a-R5p13S8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: AO4CJ0aXjYGi6vWCXsx-J5NZFCyIchBO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170081 On 3/11/26 11:26 AM, Krishna Chaitanya Chundru wrote: > Add support for transitioning PCIe endpoints & bridges into D3cold by > integrating with the DWC core suspend/resume helpers. > > Implement PME_TurnOff message generation via ELBI_SYS_CTRL and hook it > into the DWC host operations so the controller follows the standard > PME_TurnOff-based power-down sequence before entering D3cold. > > When the device is suspended into D3cold, fully tear down interconnect > bandwidth, OPP votes. If D3cold is not entered, retain existing behavior > by keeping the required interconnect and OPP votes. > > Drop the qcom_pcie::suspended flag and rely on the existing > dw_pcie::suspended state, which now drives both the power-management > flow and the interconnect/OPP handling. > > Signed-off-by: Krishna Chaitanya Chundru > --- [...] > ret = icc_disable(pcie->icc_cpu); > if (ret) > dev_err(dev, "Failed to disable CPU-PCIe interconnect path: %d\n", ret); > > if (pcie->use_pm_opp) > dev_pm_opp_set_opp(pcie->pci->dev, NULL); Does calling .suspend not drop the vote by itself? [...] > @@ -2132,25 +2138,46 @@ static int qcom_pcie_resume_noirq(struct device *dev) Similarly, I'd expect that .resume restores it (and you didn't do it manually) Konrad