mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Rakuram Eswaran <rakuram.e96@gmail.com>, linux-can@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mailhol@kernel.org, mkl@pengutronix.de
Subject: Re: [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs for CAN XL
Date: Tue, 9 Dec 2025 17:17:38 +0100	[thread overview]
Message-ID: <f33bb7a6-75c7-4ee4-baae-755ff25d81d6@hartkopp.net> (raw)
In-Reply-To: <20251208141904.8737-1-rakuram.e96@gmail.com>

Hello Rakuram,

On 08.12.25 15:19, Rakuram Eswaran wrote:
> On Fri, 28 Nov 2025 at 00:49, Rakuram Eswaran <rakuram.e96@gmail.com> wrote:
>>
>> This RFC series introduces two changes related to CAN XL support:
>>
>>    1. Add termination configuration support to the dummy_can driver,
>>       enabling termination testing with iproute2.
>>
>>    2. Update the SocketCAN documentation to describe CAN XL operation,
>>       including MTU changes, bittiming/XBTR settings, mixed-mode
>>       behaviour, error signalling, and example iproute2 usage.
>>
>> The goal of this RFC is to validate whether the proposed behaviour and
>> documentation match the expectations for the ongoing CAN XL upstream
>> work. Feedback from the maintainers is highly appreciated.
>>
>> Base commit:
>> commit 30f09200cc4a ("Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux")
>>
>> For testing, this series was applied on top of the following patchsets:
>>
>>    * "treewide: remove can_change_mtu()" (Vincent Mailhol)
>>          b4 am 20251003-remove-can_change_mtu-v1-1-337f8bc21181@kernel.org
>>          git am ./20251003_mailhol_can_treewide_remove_can_change_mtu.mbx
>>
>>    * "can: netlink: add CAN XL support" (Marc Kleine-Budde)
>>          b4 am 20251126-canxl-v8-0-e7e3eb74f889@pengutronix.de
>>          git am ./v8_20251126_mkl_can_netlink_add_can_xl_support.mbx
>>
>> Testing was performed using the iproute2-next tree (canxl-netlink branch),
>> which contains the required CAN XL netlink support for validating
>> these changes.
>>
> 
> Hello,
> 
> Gentle ping — any feedback on this documentation update patch series?

Many thanks for the patches.

The termination patch should be commented by Vincent, who is currently 
pretty busy.

But as the next merge windows is far away this can be managed in 
January. No hurry.

The documentation is almost fine but still has error-signalling in the 
ip options and there's definitely no xl-cc-len16-dlc option.

Please use the latest iproute2 code to generate the examples:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/

Best regards,
Oliver


  reply	other threads:[~2025-12-09 16:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 19:18 Rakuram Eswaran
2025-11-27 19:18 ` [RFC PATCH 1/2] can: dummy_can: add CAN termination support Rakuram Eswaran
2025-12-23 21:33   ` Vincent Mailhol
2025-12-25  7:28     ` Rakuram Eswaran
2025-12-25 11:10       ` Vincent Mailhol
2025-11-27 19:18 ` [RFC PATCH 2/2] docs: can: update SocketCAN documentation for CAN XL Rakuram Eswaran
2025-12-08 14:19 ` [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs " Rakuram Eswaran
2025-12-09 16:17   ` Oliver Hartkopp [this message]
2025-12-18 16:06     ` Rakuram Eswaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f33bb7a6-75c7-4ee4-baae-755ff25d81d6@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=rakuram.e96@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®