From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368F1343D85 for ; Tue, 16 Jun 2026 08:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781597140; cv=none; b=U42GiMUTGNokA+bW5G7YOdim5J7aPu4zDptwag8Zi05vdB2vDuPlFrOsM6WBNM27xriVj9PAys16eBO518KuyIlA3P9WqOlyVqqIed8G929qMgqpxz/TclbJ//Xf71ghnTPybmrlnqq1ZstPn4V15q5SynxWfcVoCwrW7R77snU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781597140; c=relaxed/simple; bh=LH85bdQfVmzgrqpeuQMNParDNf5GJDQCKxnh6gYkn7I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P7EN6ul5M+bATOlYjFe9vv4f4VMWuT4LBKoKSiHRB0oKUJQJ9GCmaphz3JEpJyGzhSD9WMBXqd5cCgiTZrlsLr937ri9npZr3R+/Oq8OmpuO2kmODYqtkaFAoZHxgnwzHUpDAUmVPFhh960Eci4v7wvxJJjS+ZN4a2gm2NVkUiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gy+xzCTt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W+vsnyRw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gy+xzCTt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W+vsnyRw" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G6PU7P2402220 for ; Tue, 16 Jun 2026 08:05:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LH85bdQfVmzgrqpeuQMNParDNf5GJDQCKxnh6gYkn7I=; b=gy+xzCTtVI63Ep/E FUadRmYKzfYsdAzJngwpzbvavI6W5Yigma98iLsB3CxCn4UWkj96g4EDK9NmOiPV BH7nFGLo674pUfOhRrKmULHe8dYUjqO4DIX++ttT3NsPrvkitYl+HV9An76x1Yfw +UmTPOC2We1B0DLDShKD2OgY2RVhA5rY5z5cJGQKTDWy6jPotoafgXh3dok2b1uu aZYPmOTNsZUuyKwaRE6/wehuUtEgJ2q1RoyAxMHPBw363znecda2G0CTBBOxEsOD 1lQbugRKtv736xlUwVkgTCYBOJIeakC4Tp2uWATh04pfe5kmnliOj0xgC2fAb9Fr jMTVoA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1760ddv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 08:05:38 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c0c20f7581so44243635ad.0 for ; Tue, 16 Jun 2026 01:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781597137; x=1782201937; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LH85bdQfVmzgrqpeuQMNParDNf5GJDQCKxnh6gYkn7I=; b=W+vsnyRwUuTg1TbrbE5lKLKcYkDrxprYXYvXRi5U67v3KnsOe49RK1XcGLbvWXUq/Q SYhJsK+JBfIrUqQfPXDtZCwT/LdQqjI58LpxSE+Ivc4kFNDaDhvbvPIxiamyIm3pMfk7 LBIvrSbmLc0qmt8UOh9O9fVz0cay/Nrt5mR5nisN2HLswHEY5I1m4q1OFk8TtTv0g3zx lOg8GeY/9RIZ0UAIsuLE0vej7E/ni4fuH29r1E3p2UPAbvCIv9IQUiO4p0Qae5YcdWlf 6i/QxZvMQX08txcbf1OcptzC92+RpAGwCbwymttI0Y9ZwEzvTUbMLB4G5VPUBKGBQBIi 78HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781597137; x=1782201937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LH85bdQfVmzgrqpeuQMNParDNf5GJDQCKxnh6gYkn7I=; b=cGA5oN/vc7LC6/TAWKWFIRua6YWFavUEYF1lv4TMp+tskhNvQ/u5nSL2uKP7UwN5Qr 11HHl0eSHwsA+OBzyxFUBVkSNGiATVOZBoHifNB7eA5eSUHeXG29+jxnrpSlbDPuoA5y E4mDgq2U+z/Z3qW9rm30BgFU6MFZz9n0A6q4VMR0JuiflexXFBMH9LrHrlVQmONx5KkV S4QDau9E3r3eko/Zw7M0Hk7/nh4LcrOIhqatN1yl4x0NRWmdNqKlv6mO4f7PeBIq+5pv 3oVW0aZtijRQaddherCySUZ6YocyMhh/MsQPXns3p52yx2hmIV/Nbr8DfIf5J9OUEilY O32g== X-Forwarded-Encrypted: i=1; AFNElJ9qKYqFWmaJNGyLn7zxJOZK8l0dJdx00qFoDHw46aFG3QnMBLlz9op3EESV0bmcELRgvg7PaOYw3cWuhVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3VjxnlnccIqR7rOnkB5xchdqs1+Xoca9DDHSUHmXQDj+4wSP8 QKt3QBvbjoxen0RPmmUia/YnMzNZcyND2NpytW4Z/WHCKVjERlD4+iyDdiH6IRokiqe86rciLZ9 ulilKq46ojxRZhb/m2vu9QGjrhGbnmPURcHxQ1IJcKfY221A7c1Ja6fn3LU5/6i7TNJo= X-Gm-Gg: Acq92OFcGMByZHKQvRHpGDbPlhWstkwZvgJvKV6nz4zCdbLAzIHyaMPm2kWgC9DU6A6 R/Vt+lm20I+3ETyUvnSI5RdYpI91l165kpran6v6bw6i0u0dlGUD0nb/xuaMdARM+77foBO6dY3 KTrnMAcRpjJW+8/SA7tjmiBZmelBedJCbK8IVy1CzBPnIqFG1GHe8dNCsWX3dkHTHsV/J0Zk/vG 3QvD2CokBXM+iMhYAgnzL6OtnYRselyYF/kIPtETzc9gX9RKsZ+3iA75vp/wh5GX+RycZ2Abj2W wQrsVbHPsHBpdZXpT1PLKjLJU6AxTC6v4TnA4VyaaDSqqZUyc4GpX9P4bBXEQgoZQ3vsoyKfhDb lu24TACe4tcoTXr3nGWuitJcZWZlxjCNa1b+3UBnbD/7degHtrR4EFGtrP4auHmntSMcE6jSQu/ 0SHmhlxAS3Gg== X-Received: by 2002:a17:902:f54a:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c69a186b1amr27844465ad.24.1781597137469; Tue, 16 Jun 2026 01:05:37 -0700 (PDT) X-Received: by 2002:a17:902:f54a:b0:2c0:a746:7aff with SMTP id d9443c01a7336-2c69a186b1amr27844095ad.24.1781597137038; Tue, 16 Jun 2026 01:05:37 -0700 (PDT) Received: from [10.133.33.52] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c433369c8asm126370745ad.73.2026.06.16.01.05.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 01:05:36 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 16:05:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/2] scsi: ufs: core: Add support for static TX Equalization settings To: Bart Van Assche , krzk@kernel.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , Ram Kumar Dwivedi , Nitin Rawat , open list References: <20260615132834.2985346-1-can.guo@oss.qualcomm.com> <20260615132834.2985346-3-can.guo@oss.qualcomm.com> <35a67c82-f71d-4a20-8560-05c2b1361b06@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <35a67c82-f71d-4a20-8560-05c2b1361b06@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ZGPAQTK86GP2y_Uf5WojPCDeVEHv0BtH X-Proofpoint-ORIG-GUID: ZGPAQTK86GP2y_Uf5WojPCDeVEHv0BtH X-Authority-Analysis: v=2.4 cv=I4RVgtgg c=1 sm=1 tr=0 ts=6a3103d2 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=eY37RKT_pTjDV0uVlbAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA4MCBTYWx0ZWRfX4k/fTN2FsAr7 GEzIOKTb1wNC62+4zmchvI0Scp/MxszZMFQtkYB0YdN37bU2RBs3esqNQzUuSr1027dISvjYwlG u4V0pmdWs7rmDoAnrLvpXsexwK/hOFU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA4MCBTYWx0ZWRfXzZgyKghkfsL8 lK0iFvqnmmcW+ar+OUCbqH6DIDZVu1xkPIJslJoGDNmWREuqeEIt11e7XCo6dwmTWwrenc9ILeT JtaofJbGiVafRQCVgZP7i9RYpCeAwvlDdktrBCx5VTUr1bW3ttZ+w5roZs0pfvvaoh8gttAcBYE NztniRuHAB3qIiSuL1FYDkUr91ZA1WSLR95a1f/vu3Aaofa/XViYhgCpPvplcE91dhC49XbXZOi tiC9o6HmYKU/iI/dG6y3MihTcX4NEKgtJi3GF7Tjc6iZWXBzMptiBPGTUqNhP2B+c95Wycd8xnG imiThI/ZGAKk04tmi1NhY0cS9XBCr4r+iaBo+HfUEKLCguin73PTLRtt+1n+BzLqWvwz1Ggbunc m39xkavjnlHOfVmz4e7UQjGDyHOgi1cQrUz4rMCV09EdZQ0FIOEl877jminaveLSjzMyzJOyV/M Ydj1QQkUNAyf6bnWD5g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_02,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160080 On 6/15/2026 9:38 PM, Bart Van Assche wrote: > On 6/15/26 6:28 AM, Can Guo wrote: >> +    prop = of_find_property(dev->of_node, prop_name, NULL); >> +    if (!prop) >> +        return 0; >> + >> +    count = of_property_count_u32_elems(dev->of_node, prop_name); >> +    if (count < 0) >> +        return count; > > Can the above two of_*() calls be combined into a single of_*() call, > e.g. as follows? > > count = of_property_count_u32_elems(dev->of_node, prop_name); > if (count == -EINVAL || count == -ENOENT) >     return 0; > if (count < 0) >     return count; Sure, will do. Thanks, Can Guo. > > Thanks, > > Bart.